From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D8AC44EAD6 for ; Fri, 13 Jun 2025 08:34:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id F2AC068C432; Fri, 13 Jun 2025 11:34:24 +0300 (EEST) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D48F268C112 for ; Fri, 13 Jun 2025 11:34:17 +0300 (EEST) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-553b165c80cso403581e87.2 for ; Fri, 13 Jun 2025 01:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1749803657; x=1750408457; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=S4EbiwSqY+Irnf81/cEmIV6ZZMdBCvxpBEQgWFUaGm4=; b=tTcf8MO4Ed+cKZKjwsbIjbCCUgNkQpGhc8YUhcnr8ZZENHO6cELt9tr42TigbIEsIJ Lei2P55BexBv7XslRgRk53FjdjOObfXauyD6/naCRuTaKsxTqroaQMaywfHMQzXIwmB0 Debhygii1/JYrlX7PBp3ZfeSMD3kBIcmTlVY3qdNjZx9srdSfD/vp0TCXLmffEhX0jTN x59Q6zYHo7dq3CN5jnwqD2Dql9T16g3XSxJeLH2/EwN4lddpzkf2cGI+Gx88+DBZLFEV 6CWxfJEYBQ6oknmPRJDeiD2b/ZlUY/tCtdtN1nMKFWejIc/7VlehxIblxSVqC2FnEQtl wuMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749803657; x=1750408457; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S4EbiwSqY+Irnf81/cEmIV6ZZMdBCvxpBEQgWFUaGm4=; b=SpKWfdHIct/6GCqhSeGemjgZftBuc/OOk5qaT3j6bpHv6y+08rduDJr9i8LbVO76VS adegwRcKbf58ZOqf7hwNmHrAaRMTqEfwKwTVmOtOOxczUy0l/qHnmFFHZg5f/KFrTSYu ++U0FJnYSCu0QVTsgOOn8RPNAfN0dbT41gmatI55dNxeM03zsY8Xl5gm7JnBWSHxD53J 2NJgQaIGxje48dNQFYkWNyQF0yCvgpGSJDAKW+GgaETkhWmFcU48si9zSgE3e+Coe1Tu 4+CJJC/vCrLy1OJ3FH0fkYYtuVZNgmPP4+TWgnxJkUVs+sdXc22wa5KleIxfAZ4SDGQm C4iQ== X-Gm-Message-State: AOJu0YyqtC3P8rcxyF2CYD5LkMcSKugGNJBlO9R5cXOkuSsDJUo1Qjw6 gZZZ0LMgZCdGTvL43hqZjB8hMYAq4zd9s0IODKyojvTqP15yGlioMWAhw4nVdeY6kX4Y6hX7y6E taYE5/w== X-Gm-Gg: ASbGncutpbWqO+TUUwzkR33nlaTRcqtC9n3KcAHB82DtRzJFD8ZL2SkwZS9vaz3s8aC rgU6to9Ivfl5WwCoNl7tlrSMKlNByjZCvtHoPlNAxXfhHcQjkhLTB9fe73NiVPOkXWlnaatPgDF p8Me3DX/jZXb5OI76xboK5WyF+c5SOBVdcRlQbhYkwY0UWJB6sEyHJ7X7UxwDOSf4TxGZxmBPC3 qo7f/aYNwSehDPDfQRT9FZUXqBirtCYTd5ohR8fYCchGW/6is1X/Ctip2vjOlb5HyhH1E8hhVio o995+aIH3X3sdH5iIt3nYm3mqU4SRuJbUPOh/jKi+7gwzYnc6z4HLFH4Z8SaTJjUsQjBCponGXg W5Iu98hkJUfLER13V8lgyFvUQPLqRIqfCAxgtXnFWupX+9ft5EjzpqGqJiw== X-Google-Smtp-Source: AGHT+IF513FPbbizmIhG1zXvxcZYfj9ezQbBaM7hBH4MgMIOR5Yssx53kbyG1bIXherRtnB0L3M74Q== X-Received: by 2002:a05:6512:3d10:b0:553:ae47:685f with SMTP id 2adb3069b0e04-553af99eebamr492250e87.38.1749803656587; Fri, 13 Jun 2025 01:34:16 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553ac1fc1d8sm363709e87.255.2025.06.13.01.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 01:34:16 -0700 (PDT) Date: Fri, 13 Jun 2025 11:34:12 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20250612093933.395475-1-martin@martin.st> Message-ID: References: <20250612093933.395475-1-martin@martin.st> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avutil: Fix linking x86 asm constants with Clang in MSVC mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-15"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 12 Jun 2025, Martin Storsj=F6 wrote: > This fixes building with Clang in MSVC mode, for x86, which was > broken in 6e49b8699657b808b7dc80033f2c3f2d0e029fa3 (in Nov 2024); > previously it failed with undefined symbols for the constants > defined with DECLARE_ASM_CONST, accessed via inline assembly. > > Before 57861911a34e1c33796be97f2b2f44e05fffd647, there was an > #elif defined(__GNUC__) || defined(__clang__) > case before the > #elif defined(_MSC_VER) > case for defining DECLARE_ASM_CONST, which included av_used. > (This case included the explicit "defined(__clang__)" since > f637046d3134a331e4b5a7243ac3dfb92735b8a5.) > > After 57861911a34e1c33796be97f2b2f44e05fffd647, it used the > generic definition of DECLARE_ASM_CONST that also included > av_used - which also worked for Clang in MSVC mode. But after > 6e49b8699657b808b7dc80033f2c3f2d0e029fa3, Clang in MSVC mode > ended up using the MSVC specific variant which lacked the > av_used declaration, causing linker errors due to undefined > symbols. > --- > libavutil/mem_internal.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavutil/mem_internal.h b/libavutil/mem_internal.h > index d58881d09c..78adc4f407 100644 > --- a/libavutil/mem_internal.h > +++ b/libavutil/mem_internal.h > @@ -82,8 +82,8 @@ > #define DECLARE_ASM_CONST(n,t,v) alignas(FFMIN(n, 16)) static cons= t t av_used v > #elif defined(_MSC_VER) > #define DECLARE_ALIGNED_T(n,t,v) __declspec(align(n)) t v > - #define DECLARE_ASM_ALIGNED(n,t,v) __declspec(align(n)) t v > - #define DECLARE_ASM_CONST(n,t,v) __declspec(align(n)) static cons= t t v > + #define DECLARE_ASM_ALIGNED(n,t,v) __declspec(align(n)) t av_used v > + #define DECLARE_ASM_CONST(n,t,v) __declspec(align(n)) static cons= t t av_used v > #else > #define DECLARE_ALIGNED_T(n,t,v) alignas(n) t v > #define DECLARE_ASM_ALIGNED(n,t,v) alignas(n) t av_used v > -- = > 2.43.0 OK'd by Hendrik on irc, as I've tested it with both clang and actual MSVC = - will push. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".