From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D4F3346D68 for ; Mon, 10 Jul 2023 08:13:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 73DB868C504; Mon, 10 Jul 2023 11:13:49 +0300 (EEST) Received: from smtp-fw-9106.amazon.com (smtp-fw-9106.amazon.com [207.171.188.206]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3675C68C4EF for ; Mon, 10 Jul 2023 11:13:41 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.it; i=@amazon.it; q=dns/txt; s=amazon201209; t=1688976828; x=1720512828; h=from:to:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding:subject; bh=5Fulfb80P8e0qh05a1vA6Tvtqy7p0diGY9+4ofL8Dso=; b=HVzvQk711aPhuW8/exbPyQz0iCxkx+1o5qbIcvDZTWcLI9Wu6KMirJ5Y IKNkSZSeGL3orJklphWn75av2mY32i1MCw4JiSoKB7Svqvq9Dm8Jgy70G 5fjMDVO7lRxV0yk/cUgKTYesBNSlbUuIMNeVnOpK0Y2qdRYFc93L+Sbz0 U=; X-IronPort-AV: E=Sophos;i="6.01,194,1684800000"; d="scan'208";a="658941843" Thread-Topic: [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-iad-1e-m6i4x-b538c141.us-east-1.amazon.com) ([10.25.36.214]) by smtp-border-fw-9106.sea19.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 08:13:34 +0000 Received: from EX19D011EUA001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1e-m6i4x-b538c141.us-east-1.amazon.com (Postfix) with ESMTPS id 5F0DEA1034 for ; Mon, 10 Jul 2023 08:13:32 +0000 (UTC) Received: from EX19D025EUC003.ant.amazon.com (10.252.61.205) by EX19D011EUA001.ant.amazon.com (10.252.50.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Mon, 10 Jul 2023 08:13:31 +0000 Received: from EX19D025EUC002.ant.amazon.com (10.252.61.247) by EX19D025EUC003.ant.amazon.com (10.252.61.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Mon, 10 Jul 2023 08:13:31 +0000 Received: from EX19D025EUC002.ant.amazon.com ([fe80::c9fe:e3a8:dd4f:e087]) by EX19D025EUC002.ant.amazon.com ([fe80::c9fe:e3a8:dd4f:e087%3]) with mapi id 15.02.1118.030; Mon, 10 Jul 2023 08:13:31 +0000 From: "Carotti, Elias" To: FFmpeg development discussions and patches Thread-Index: AQHZsmboYAhJxWLRAUmD+TP6DduJa6+ypyXg Date: Mon, 10 Jul 2023 08:13:31 +0000 Message-ID: References: <168742346237.21886.2119907118968452752@lain.khirnov.net> <168760449144.21886.5224052304919615682@lain.khirnov.net> <2fe8e0027d33c25e2de01e57ea1dd7b0cef300bf.camel@amazon.it> <168795695865.21886.2879227621245771333@lain.khirnov.net> <168820043273.21886.17648463695363628461@lain.khirnov.net> <20230709110529.29490-1-anton@khirnov.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.21.151.21] MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: -----Original Message----- From: ffmpeg-devel On Behalf Of Lynne Sent: Sunday, July 9, 2023 3:11 PM To: FFmpeg development discussions and patches Subject: RE: [EXTERNAL][FFmpeg-devel] [PATCH] lavu: add AVVideoHint API CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. Jul 9, 2023, 13:05 by anton@khirnov.net: > From: Elias Carotti > > Add side data type to provide hint to the video encoders about > unchanged portions of each frame. > > Signed-off-by: Anton Khirnov > --- > I've made couple small changes: > * rebased against current master > * consistently refer to rectangles or AVVideoRect, not blocks > * use size_t instead of int for AVVideoHint.nb_rects > * build unconditionally -- this is public API, it must always be > available regardless of what encoders are or are not available > * tweaked documentation > > If you have no objections to the changes, I'll push this in a few days. > --- > doc/APIchanges | 3 ++ > libavutil/Makefile | 2 + > libavutil/frame.h | 10 ++++ > libavutil/version.h | 2 +- > libavutil/video_hint.c | 82 +++++++++++++++++++++++++++++++ > libavutil/video_hint.h | 108 +++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 206 insertions(+), 1 deletion(-) create mode 100644 > libavutil/video_hint.c create mode 100644 libavutil/video_hint.h > AVVideoHint is a bad name for something like this. Could you borrow some wording from graphics and call it AVVideoDamagedHint or maybe AVVideoChangedAreaHint or a combination of both? I'd prefer the former, damage is standard language in graphics circles about what has changed since the last frame. Hi, I have no strong objections on this. Personally I also like the AVVideoDamagedHint name best, my only concern is that it is strictly related to the current use/implementation (it's true right now that's the only kind of hint) while it may turn out to be a bad naming decision should other forms of hinting for the encoder be added in the future. That said, I am fine with the change too. Elias _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".