* Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/nvenc: Enable recovery point SEI for intra refresh mode
[not found] <20250203174043.141F7412710@natalya.videolan.org>
@ 2025-02-04 12:25 ` Martin Storsjö
2025-02-04 12:58 ` Timo Rothenpieler
0 siblings, 1 reply; 4+ messages in thread
From: Martin Storsjö @ 2025-02-04 12:25 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: zhilizhao, timo
On Mon, 3 Feb 2025, Zhao Zhili wrote:
> ffmpeg | branch: master | Zhao Zhili <zhilizhao@tencent.com> | Thu Jan 23 22:17:29 2025 +0800| [1438f6997db70945173f01aea1768e3b27ce2679] | committer: Zhao Zhili
>
> avcodec/nvenc: Enable recovery point SEI for intra refresh mode
>
> Otherwise all frames can be dropped after seek without the
> output_corrupt/showall flags.
>
> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
> Reviewed-by: Timo Rothenpieler <timo@rothenpieler.org>
>
>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=1438f6997db70945173f01aea1768e3b27ce2679
> ---
>
> libavcodec/nvenc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
> index c52e47734e..c359c2bc8a 100644
> --- a/libavcodec/nvenc.c
> +++ b/libavcodec/nvenc.c
> @@ -1281,6 +1281,7 @@ static av_cold int nvenc_setup_h264_config(AVCodecContext *avctx)
> h264->intraRefreshPeriod = cc->gopLength;
> h264->intraRefreshCnt = cc->gopLength - 1;
> cc->gopLength = NVENC_INFINITE_GOPLENGTH;
> + h264->outputRecoveryPointSEI = 1;
This change breaks building with older versions of nv-codec-headers
installed.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/nvenc: Enable recovery point SEI for intra refresh mode
2025-02-04 12:25 ` [FFmpeg-devel] [FFmpeg-cvslog] avcodec/nvenc: Enable recovery point SEI for intra refresh mode Martin Storsjö
@ 2025-02-04 12:58 ` Timo Rothenpieler
2025-02-04 13:23 ` Martin Storsjö
0 siblings, 1 reply; 4+ messages in thread
From: Timo Rothenpieler @ 2025-02-04 12:58 UTC (permalink / raw)
To: Martin Storsjö, ffmpeg-devel; +Cc: zhilizhao
On 04/02/2025 13:25, Martin Storsjö wrote:
> On Mon, 3 Feb 2025, Zhao Zhili wrote:
>
>> ffmpeg | branch: master | Zhao Zhili <zhilizhao@tencent.com> | Thu Jan
>> 23 22:17:29 2025 +0800| [1438f6997db70945173f01aea1768e3b27ce2679] |
>> committer: Zhao Zhili
>>
>> avcodec/nvenc: Enable recovery point SEI for intra refresh mode
>>
>> Otherwise all frames can be dropped after seek without the
>> output_corrupt/showall flags.
>>
>> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
>> Reviewed-by: Timo Rothenpieler <timo@rothenpieler.org>
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?
>>> a=commit;h=1438f6997db70945173f01aea1768e3b27ce2679
>> ---
>>
>> libavcodec/nvenc.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
>> index c52e47734e..c359c2bc8a 100644
>> --- a/libavcodec/nvenc.c
>> +++ b/libavcodec/nvenc.c
>> @@ -1281,6 +1281,7 @@ static av_cold int
>> nvenc_setup_h264_config(AVCodecContext *avctx)
>> h264->intraRefreshPeriod = cc->gopLength;
>> h264->intraRefreshCnt = cc->gopLength - 1;
>> cc->gopLength = NVENC_INFINITE_GOPLENGTH;
>> + h264->outputRecoveryPointSEI = 1;
>
> This change breaks building with older versions of nv-codec-headers
> installed.
Even the 8.1 SDK has this, which is the oldest version still supported
by FFmpeg:
https://github.com/FFmpeg/nv-codec-headers/blob/sdk/8.1/include/ffnvcodec/nvEncodeAPI.h#L1279
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/nvenc: Enable recovery point SEI for intra refresh mode
2025-02-04 12:58 ` Timo Rothenpieler
@ 2025-02-04 13:23 ` Martin Storsjö
2025-02-04 13:32 ` James Almer
0 siblings, 1 reply; 4+ messages in thread
From: Martin Storsjö @ 2025-02-04 13:23 UTC (permalink / raw)
To: Timo Rothenpieler; +Cc: zhilizhao, ffmpeg-devel
On Tue, 4 Feb 2025, Timo Rothenpieler wrote:
> On 04/02/2025 13:25, Martin Storsjö wrote:
>> On Mon, 3 Feb 2025, Zhao Zhili wrote:
>>
>>> ffmpeg | branch: master | Zhao Zhili <zhilizhao@tencent.com> | Thu Jan 23
>>> 22:17:29 2025 +0800| [1438f6997db70945173f01aea1768e3b27ce2679] |
>>> committer: Zhao Zhili
>>>
>>> avcodec/nvenc: Enable recovery point SEI for intra refresh mode
>>>
>>> Otherwise all frames can be dropped after seek without the
>>> output_corrupt/showall flags.
>>>
>>> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
>>> Reviewed-by: Timo Rothenpieler <timo@rothenpieler.org>
>>>
>>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?
>>>> a=commit;h=1438f6997db70945173f01aea1768e3b27ce2679
>>> ---
>>>
>>> libavcodec/nvenc.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
>>> index c52e47734e..c359c2bc8a 100644
>>> --- a/libavcodec/nvenc.c
>>> +++ b/libavcodec/nvenc.c
>>> @@ -1281,6 +1281,7 @@ static av_cold int
>>> nvenc_setup_h264_config(AVCodecContext *avctx)
>>> h264->intraRefreshPeriod = cc->gopLength;
>>> h264->intraRefreshCnt = cc->gopLength - 1;
>>> cc->gopLength = NVENC_INFINITE_GOPLENGTH;
>>> + h264->outputRecoveryPointSEI = 1;
>>
>> This change breaks building with older versions of nv-codec-headers
>> installed.
>
> Even the 8.1 SDK has this, which is the oldest version still supported by
> FFmpeg:
> https://github.com/FFmpeg/nv-codec-headers/blob/sdk/8.1/include/ffnvcodec/nvEncodeAPI.h#L1279
Sorry, I quoted the wrong part of the patch.
The case in NV_ENC_CONFIG_H264 does indeed exist in older SDKs, but the
one in NV_ENC_CONFIG_HEVC doesn't seem to exist in 8.1, or in 11.1 either.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/nvenc: Enable recovery point SEI for intra refresh mode
2025-02-04 13:23 ` Martin Storsjö
@ 2025-02-04 13:32 ` James Almer
0 siblings, 0 replies; 4+ messages in thread
From: James Almer @ 2025-02-04 13:32 UTC (permalink / raw)
To: ffmpeg-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 1950 bytes --]
On 2/4/2025 10:23 AM, Martin Storsjö wrote:
> On Tue, 4 Feb 2025, Timo Rothenpieler wrote:
>
>> On 04/02/2025 13:25, Martin Storsjö wrote:
>>> On Mon, 3 Feb 2025, Zhao Zhili wrote:
>>>
>>>> ffmpeg | branch: master | Zhao Zhili <zhilizhao@tencent.com> | Thu
>>>> Jan 23 22:17:29 2025 +0800|
>>>> [1438f6997db70945173f01aea1768e3b27ce2679] | committer: Zhao Zhili
>>>>
>>>> avcodec/nvenc: Enable recovery point SEI for intra refresh mode
>>>>
>>>> Otherwise all frames can be dropped after seek without the
>>>> output_corrupt/showall flags.
>>>>
>>>> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
>>>> Reviewed-by: Timo Rothenpieler <timo@rothenpieler.org>
>>>>
>>>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?
>>>>> a=commit;h=1438f6997db70945173f01aea1768e3b27ce2679
>>>> ---
>>>>
>>>> libavcodec/nvenc.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
>>>> index c52e47734e..c359c2bc8a 100644
>>>> --- a/libavcodec/nvenc.c
>>>> +++ b/libavcodec/nvenc.c
>>>> @@ -1281,6 +1281,7 @@ static av_cold int
>>>> nvenc_setup_h264_config(AVCodecContext *avctx)
>>>> h264->intraRefreshPeriod = cc->gopLength;
>>>> h264->intraRefreshCnt = cc->gopLength - 1;
>>>> cc->gopLength = NVENC_INFINITE_GOPLENGTH;
>>>> + h264->outputRecoveryPointSEI = 1;
>>>
>>> This change breaks building with older versions of nv-codec-headers
>>> installed.
>>
>> Even the 8.1 SDK has this, which is the oldest version still supported
>> by FFmpeg:
>> https://github.com/FFmpeg/nv-codec-headers/blob/sdk/8.1/include/
>> ffnvcodec/nvEncodeAPI.h#L1279
>
> Sorry, I quoted the wrong part of the patch.
>
> The case in NV_ENC_CONFIG_H264 does indeed exist in older SDKs, but the
> one in NV_ENC_CONFIG_HEVC doesn't seem to exist in 8.1, or in 11.1 either.
Just sent a patch, can you test it?
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-04 13:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250203174043.141F7412710@natalya.videolan.org>
2025-02-04 12:25 ` [FFmpeg-devel] [FFmpeg-cvslog] avcodec/nvenc: Enable recovery point SEI for intra refresh mode Martin Storsjö
2025-02-04 12:58 ` Timo Rothenpieler
2025-02-04 13:23 ` Martin Storsjö
2025-02-04 13:32 ` James Almer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git