From: Marton Balint <cus@passwd.hu> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vbn(dec|enc): Remove empty close function Date: Wed, 13 Apr 2022 00:08:36 +0200 (CEST) Message-ID: <bb95b084-1359-7740-5f3c-be15962bdd7d@passwd.hu> (raw) In-Reply-To: <AS8PR01MB7944B16EA54AE2AE468332218FED9@AS8PR01MB7944.eurprd01.prod.exchangelabs.com> On Tue, 12 Apr 2022, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> > --- > libavcodec/vbndec.c | 6 ------ > libavcodec/vbnenc.c | 6 ------ > 2 files changed, 12 deletions(-) Thanks, all the VBN patches in this series LGTM. Regards, Marton > > diff --git a/libavcodec/vbndec.c b/libavcodec/vbndec.c > index d6f8121e12..916421925d 100644 > --- a/libavcodec/vbndec.c > +++ b/libavcodec/vbndec.c > @@ -176,11 +176,6 @@ out: > return ret; > } > > -static av_cold int vbn_close(AVCodecContext *avctx) > -{ > - return 0; > -} > - > const FFCodec ff_vbn_decoder = { > .p.name = "vbn", > .p.long_name = NULL_IF_CONFIG_SMALL("Vizrt Binary Image"), > @@ -188,7 +183,6 @@ const FFCodec ff_vbn_decoder = { > .p.id = AV_CODEC_ID_VBN, > .init = vbn_init, > FF_CODEC_DECODE_CB(vbn_decode_frame), > - .close = vbn_close, > .priv_data_size = sizeof(VBNContext), > .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_SLICE_THREADS, > .caps_internal = FF_CODEC_CAP_INIT_THREADSAFE > diff --git a/libavcodec/vbnenc.c b/libavcodec/vbnenc.c > index 5c855bcd73..0b2c4dced2 100644 > --- a/libavcodec/vbnenc.c > +++ b/libavcodec/vbnenc.c > @@ -132,11 +132,6 @@ static av_cold int vbn_init(AVCodecContext *avctx) > return 0; > } > > -static av_cold int vbn_close(AVCodecContext *avctx) > -{ > - return 0; > -} > - > #define OFFSET(x) offsetof(VBNContext, x) > #define FLAGS AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM > static const AVOption options[] = { > @@ -163,7 +158,6 @@ const FFCodec ff_vbn_encoder = { > .p.priv_class = &vbnenc_class, > .init = vbn_init, > FF_CODEC_ENCODE_CB(vbn_encode), > - .close = vbn_close, > .priv_data_size = sizeof(VBNContext), > .p.pix_fmts = (const enum AVPixelFormat[]) { > AV_PIX_FMT_RGBA, AV_PIX_FMT_RGB24, AV_PIX_FMT_NONE, > -- > 2.32.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-04-12 22:08 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-12 19:23 Andreas Rheinhardt 2022-04-12 19:25 ` [FFmpeg-devel] [PATCH 2/5] avcodec/vbn(dec|enc): Avoid leaving stale pointers in context Andreas Rheinhardt 2022-04-12 19:25 ` [FFmpeg-devel] [PATCH 3/5] avcodec/vbn(dec|enc): Avoid always-false checks Andreas Rheinhardt 2022-04-12 19:25 ` [FFmpeg-devel] [PATCH 4/5] avcodec/vbnenc: Add AV_CODEC_CAP_DR1 Andreas Rheinhardt 2022-04-12 19:25 ` [FFmpeg-devel] [PATCH 5/5] avcodec/mss12: Constify slice context->parent context pointer Andreas Rheinhardt 2022-04-12 19:29 ` Paul B Mahol 2022-04-12 19:27 ` [FFmpeg-devel] [PATCH 1/5] avcodec/vbn(dec|enc): Remove empty close function Paul B Mahol 2022-04-12 22:08 ` Marton Balint [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bb95b084-1359-7740-5f3c-be15962bdd7d@passwd.hu \ --to=cus@passwd.hu \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git