From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3526B493F6 for ; Fri, 9 Feb 2024 19:47:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F0FB68CF84; Fri, 9 Feb 2024 21:47:28 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9363268CD10 for ; Fri, 9 Feb 2024 21:47:21 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 419JlKJ1020879-419JlKJ2020879; Fri, 9 Feb 2024 21:47:20 +0200 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id 2F8ECA4D03; Fri, 9 Feb 2024 21:47:19 +0200 (EET) Date: Fri, 9 Feb 2024 21:47:19 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20240209112649.16556-1-connorbworley@gmail.com> Message-ID: References: <20240209112649.16556-1-connorbworley@gmail.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/dxv: align to 4x4 blocks instead of 16x16 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Connor Worley Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 9 Feb 2024, Connor Worley wrote: > The previous assumption that DXV needs to be aligned to 16x16 was > erroneous. 4x4 works just as well, and FATE decoder tests pass for all > texture formats. > > On the encoder side, we should reject input that isn't 4x4 aligned, > like the HAP encoder does, and stop aligning to 16x16. This both solves > the uninitialized reads causing current FATE tests to fail and produces > smaller encoded outputs. > > With regard to correctness, I've checked the decoding path by encoding a > real-world sample with git master, and decoding it with > ffmpeg -i dxt1-master.mov -c:v rawvideo -f framecrc - > The results are exactly the same between master and this patch. > > On the encoding side, I've encoded a real-world sample with both master > and this patch, and decoded both versions with > ffmpeg -i dxt1-{master,patch}.mov -c:v rawvideo -f framecrc - > Under this patch, results for both inputs are exactly the same. > > In other words, the extra padding gained by 16x16 alignment over 4x4 > alignment has no impact on decoded video. > > Signed-off-by: Connor Worley > --- > libavcodec/dxv.c | 6 +++--- > libavcodec/dxvenc.c | 14 +++++++++++--- > tests/ref/fate/dxv3enc-dxt1 | 2 +- > 3 files changed, 15 insertions(+), 7 deletions(-) LGTM, will push soon to get FATE back to green again. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".