From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D26A447329 for ; Tue, 5 Sep 2023 11:26:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7FF9668C733; Tue, 5 Sep 2023 14:26:34 +0300 (EEST) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A0CB568C60E for ; Tue, 5 Sep 2023 14:26:27 +0300 (EEST) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1c4f4d67f5bso1701706fac.0 for ; Tue, 05 Sep 2023 04:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693913185; x=1694517985; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=VvrlEtdhcyKl0rVBQ/SFsvCMbyGIuHcNnXF3mq+n4d0=; b=c1hNOBZ2NaS9z4wt5Q8fl47cbUV/R5GLmtfpdwqar59sLABcuQ/8JX1ntw3tajtAEp AkRFaKkPJW92rZ6/Hoy8biPGYMWqiMz2RncpSSjHkxKrqRNggPy1GY1iel8vr88dxOh+ gi8Xj4Ox6/5tT0KuP0H1LSxm4aiSW2wFK1OqAqHD23/NOdk8lDs0hy6MhBIjvfNWyYBl NEYaxGe1O3r1+fT6veePH5XMmi5NimDxXg/dT8DuZkfbpZo0y/dL51Hf4MgCAGGtw+XP 5GwyFwrksQBRaiZR7MKmaR533qb6roNf8BT64iInW+/M8D0KI0GLyl2njBLuU5BT7f9c 8FGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693913185; x=1694517985; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VvrlEtdhcyKl0rVBQ/SFsvCMbyGIuHcNnXF3mq+n4d0=; b=N8JCd8LORmvcqtKSsjTiw+ahoOu4MgY7x8lWzgLZRIQz5xpodgqhZ6PyIzarCNzZkZ beZlHOBMTASSDin99eoRZKNxLODd9PRgMV360zYl3mjSeO1GBCVgI4ZMD31Km0ODm9N9 37ERB4ZPqHDXXUi14/CYOKgXEirgHO9DDE+DoFx7SIo1FsVfqqJ1Pu3o2bgd4vXU+e/C BbWQA6JVjz1OAPwHh5UZwcFnDdH894wR6gt0Y1++6WfqxkdsP8czCdxRCjqa7ac/ynTF NOBus2q4T2+vBodsO8AyjrvfdQGl6GCEtu6F/FeGdldfEVi8aqGxUbB0Nn7t8mNJywW+ FiRw== X-Gm-Message-State: AOJu0YyJLXm06k5tzQbUUGSHbjRj4ou6YNCy7PtSrEL2r5mz0X/yZo4b A9o86eWyFJleOMH8iN5loDL+eIdeH+g= X-Google-Smtp-Source: AGHT+IE5cybx9gSzfWGxKxP2D2Us38/H7ohLj1iuNcxHyYDXUOmOFeKW18SQn4N9a+BKjGH159pX/A== X-Received: by 2002:a05:6870:4621:b0:1bf:77e2:95cc with SMTP id z33-20020a056870462100b001bf77e295ccmr14746300oao.17.1693913185042; Tue, 05 Sep 2023 04:26:25 -0700 (PDT) Received: from [192.168.0.10] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id ds47-20020a0568705b2f00b0019f188355a8sm6436332oab.17.2023.09.05.04.26.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 04:26:24 -0700 (PDT) Message-ID: Date: Tue, 5 Sep 2023 08:26:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 To: ffmpeg-devel@ffmpeg.org References: <20230904150411.56777-2-jamrial@gmail.com> <20230904220848.21900-1-jamrial@gmail.com> <169391205232.20400.15738564387019560241@lain.khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <169391205232.20400.15738564387019560241@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 01/17] avcodec/avcodec: add side data to AVCodecContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/5/2023 8:07 AM, Anton Khirnov wrote: > Quoting James Almer (2023-09-05 00:08:48) >> This will allow the propagation of global side data within the AVCodecContext >> instead of having to do it inside packets, and thus be available during init(). >> Global and frame specific side data will therefore be distinct. > > This commit message is misleading - there is already > AVCodecContext.coded_side_data for exactly this purpose. And after the > changes from the last iteration I see even less of a reason to replace > it with a new field. I insist the new field in the form of a set is better, for the sake of unified helpers that can be used in avctx, codecpar, avstream, and potentially others in the future. It will also be the packet counterpart of Jan's frame side data set field. coded_side_data is currently used only to export CPB props, so the amount of users is probably very small (Maybe only lavf, even). I think the benefits in the long run outweigh the cons from the breakage that would mean replacing coded_side_data. Also, my interpretation of coded is still that it refers to a coded stream, much like we make a distinction between coded and raw for bits_per_sample, and in decoding scenarios, side data entries would have information that refer to the decoded raw stream (hdr, etc). That said, I don't want to keep delaying this set much longer, so if you're really against that change I'll try to remove it from the set and keep the rest. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".