Re: [FFmpeg-devel] [PATCH] swscale/aarch64/output: Implement neon assembly for yuv2nv12cX_c()

From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Dash Santosh Sathyanarayanan
	<dash.sathyanarayanan@multicorewareinc.com>,
	Logaprakash Ramajayam
	<logaprakash.ramajayam@multicorewareinc.com>
Subject: Re: [FFmpeg-devel] [PATCH] swscale/aarch64/output: Implement neon assembly for yuv2nv12cX_c()
Date: Fri, 6 Jun 2025 10:07:49 +0300 (EEST)
Message-ID: <ba91f12b-eba0-141f-3422-fd66d5541dbb@martin.st> (raw)
In-Reply-To: <PN2P287MB1165DAC8027869113203CB14D66EA@PN2P287MB1165.INDP287.PROD.OUTLOOK.COM>

On Fri, 6 Jun 2025, Harshitha Sarangu Suresh wrote:

> Changed indentation, checked for FATE tests and gha-aarch64 git 
> workflow. Everything passed.

I doubt that everything passed; this doesn't even compile. See below:

> @@ -275,7 +291,10 @@ av_cold void ff_sws_init_swscale_aarch64(SwsInternal *c)
>         ASSIGN_VSCALE_FUNC(c->yuv2plane1, neon);
>         if (c->dstBpc == 8) {
>             c->yuv2planeX = ff_yuv2planeX_8_neon;
> +            if(isSemiPlanarYUV(c->opts.dst_format)
> +               ASSIGN_YUV2NV12_FUNC(c->yuv2nv12cX, neon, c->opts.dst_format);
>         }
> +

src/libswscale/aarch64/swscale.c: In function 
‘ff_sws_init_swscale_aarch64’:
src/libswscale/aarch64/swscale.c:294:51: error: expected ‘)’ before ‘if’
   294 |             if(isSemiPlanarYUV(c->opts.dst_format)
       |               ~                                   ^
       |                                                   )

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".