Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0

From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "anton@khirnov.net" <anton@khirnov.net>,
	"ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0
Date: Wed, 6 Apr 2022 03:38:09 +0000
Message-ID: <ba710109f8cef7f5ece8f254c36d0097be69c7e8.camel@intel.com> (raw)
In-Reply-To: <164915940053.21047.6940981970361137655@lain.red.khirnov.net>

On Tue, 2022-04-05 at 13:50 +0200, Anton Khirnov wrote:
> Quoting Xiang, Haihao (2022-03-11 09:16:25)
> > From: Haihao Xiang <haihao.xiang@intel.com>
> > 
> > Audio isn't supported for MFX_VERSION >= 2.0[1][2]. This is in
> > preparation for oneVPL support
> > 
> > [1]: 
> > https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_intel_media_sdk.html#msdk-full-name-feature-removals
> > [2]: https://github.com/oneapi-src/oneVPL
> > ---
> >  libavcodec/qsv.c     | 5 +++++
> >  libavfilter/qsvvpp.c | 6 ++++++
> >  libavfilter/qsvvpp.h | 2 ++
> >  3 files changed, 13 insertions(+)
> 
> Why not just remove this completely?
> None of our QSV code  does anything with audio.

It was removed in an older version, however someone objected the removal of
this.  See 
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.443304-2-haihao.xiang@intel.com/

Thanks
Haihao

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".