From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D618547500 for ; Wed, 10 Jan 2024 02:30:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 02E4D680068; Wed, 10 Jan 2024 04:30:06 +0200 (EET) Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5449E680068 for ; Wed, 10 Jan 2024 04:29:59 +0200 (EET) Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-6dddc655a60so1184625a34.2 for ; Tue, 09 Jan 2024 18:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704853797; x=1705458597; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CtTEtSvgW6DQEP9K0+RCoVENd5wknb3Ww86hAvVfavE=; b=GkKLp4x+mv/TW3wnBveSDUvlPLthK/gqXei7D9bkF1+nzYAO8xdofHt0brmjHzdWic M6kiHoUg5sTDpydwNIW0RtPc/ax47CAr22Dmf1JUpPM6mVq2RdPafFG1ETV4NNdCBZGB tg3dK7+cDA5ynVtzb4tJlJ7HBflhykjvgYqrHvHcRslazLsEiyKT+s/V9a0uBbEwUPDb ddwb27dhwsWvPjmJ5uYmLlLNizvDJsf3NtUmB4UVbxfOXVMJ9TjpWnQaZnMXVmnyQVhI J+hr5L6O4l2T2tZe63xDcf3D5UFnWnOpBfedHcyxniY4RTFOxkE2LOtgLA/weDvLhjlK HyIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704853797; x=1705458597; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CtTEtSvgW6DQEP9K0+RCoVENd5wknb3Ww86hAvVfavE=; b=tVK/ROLnPg4RybbmJwJMQxAJectnGvndef6hXYFGRucdZx7LiAa9GcHHI+slwY++Fa oz84YAZKxDGEADfjBhlX74rbZpKJm3SH61KgBnFArYr38TDqCXRbv18NeuxlqKyy/G4l puqem//f7wWey5v/2Z68a6DWnSjzbLKezXjmXLfg3c7mhONsfmmSOiIvCkJnkxz7Qtj2 pPB2IooXZnB9HUTnf9RpUGtxb9qtkHrYcCX6PbAwEMapRlowdtfyYbCcTAyJzJjFtEje as0arWcijumuXLKAfosJUcyGy6LQyd0nB3qAjQpPHbqiMi+MoZA3O32mj2ROo0qXwK2b PJog== X-Gm-Message-State: AOJu0YwC8g+DhKK6vuK9uDT8LILwKWlhkcRT6zl1GsuXin7r/+Qcd1QV bYoqOsDKo19xSPNawgdMV3uvsM5ep7k= X-Google-Smtp-Source: AGHT+IH+hg9XjDn2pVDwTWc1usk9YkpkHen8mGT1KCiukX+l0mqfuyt4G+Gl+XU6LKmPRvs3lFbsNQ== X-Received: by 2002:a05:6808:3027:b0:3bc:3c51:d066 with SMTP id ay39-20020a056808302700b003bc3c51d066mr403724oib.36.1704853796727; Tue, 09 Jan 2024 18:29:56 -0800 (PST) Received: from [192.168.0.13] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id i128-20020a625486000000b006d99056c4edsm2430669pfb.187.2024.01.09.18.29.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jan 2024 18:29:56 -0800 (PST) Message-ID: Date: Tue, 9 Jan 2024 23:30:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240109221741.60485-1-jamrial@gmail.com> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: attempt to set SAR even if no hardware decoding is available X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/9/2024 11:30 PM, Andreas Rheinhardt wrote: > James Almer: >> Should fix fate failures in avif tests when no external decoder is >> available. >> >> Signed-off-by: James Almer >> --- >> libavcodec/av1dec.c | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c >> index da05a0f039..43b5aef687 100644 >> --- a/libavcodec/av1dec.c >> +++ b/libavcodec/av1dec.c >> @@ -1227,7 +1227,7 @@ static int av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame) >> av_log(avctx, AV_LOG_ERROR, >> "Failed to get pixel format.\n"); >> s->raw_seq = NULL; >> - goto end; >> + continue; >> } >> } >> >> @@ -1248,6 +1248,16 @@ static int av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame) >> case AV1_OBU_FRAME: >> case AV1_OBU_FRAME_HEADER: >> if (!s->raw_seq) { >> + // Attempt to set dimensions in all cases >> + if (s->pix_fmt == AV_PIX_FMT_NONE) { >> + ret = update_context_with_frame_header(avctx, &obu->obu.frame.header); >> + if (ret < 0) { >> + av_log(avctx, AV_LOG_ERROR, "Failed to update context with frame header\n"); >> + return ret; >> + } >> + ret = AVERROR(ENOSYS); >> + goto end; >> + } >> av_log(avctx, AV_LOG_ERROR, "Missing Sequence Header.\n"); >> ret = AVERROR_INVALIDDATA; >> goto end; > > You should instead implement FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM for this > decoder so that one does not get a wall of error logs when probing > without proper hardware. > > - Andreas I fixed the problem in a different way already, so this patch can be dropped. I might look at FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM later. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".