From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 68EB643D61 for ; Tue, 9 Aug 2022 11:02:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EEB7F68B7F8; Tue, 9 Aug 2022 14:02:08 +0300 (EEST) Received: from mail8.parnet.fi (unknown [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 530D468B78D for ; Tue, 9 Aug 2022 14:02:02 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 279B213b020527-279B213c020527 for ; Tue, 9 Aug 2022 14:02:01 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 3E41FA1468 for ; Tue, 9 Aug 2022 14:02:01 +0300 (EEST) Date: Tue, 9 Aug 2022 14:02:00 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220623180407.21081-1-jdek@itanimul.li> Message-ID: References: <20220623180407.21081-1-jdek@itanimul.li> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 1/3] checkasm/hevc_add_res: add 12bit test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 23 Jun 2022, J. Dekker wrote: > Signed-off-by: J. Dekker > --- > tests/checkasm/hevc_add_res.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/tests/checkasm/hevc_add_res.c b/tests/checkasm/hevc_add_res.c > index 0c896adaca..f17d121939 100644 > --- a/tests/checkasm/hevc_add_res.c > +++ b/tests/checkasm/hevc_add_res.c > @@ -36,14 +36,14 @@ > } \ > } while (0) > > -#define randomize_buffers2(buf, size) \ > +#define randomize_buffers2(buf, size, mask) \ > do { \ > int j; \ > for (j = 0; j < size; j++) \ > - AV_WN16A(buf + j * 2, rnd() & 0x3FF); \ > + AV_WN16A(buf + j * 2, rnd() & mask); \ > } while (0) > > -static void compare_add_res(int size, ptrdiff_t stride, int overflow_test) > +static void compare_add_res(int size, ptrdiff_t stride, int overflow_test, int mask) > { > LOCAL_ALIGNED_32(int16_t, res0, [32 * 32]); > LOCAL_ALIGNED_32(int16_t, res1, [32 * 32]); > @@ -53,7 +53,7 @@ static void compare_add_res(int size, ptrdiff_t stride, int overflow_test) > declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *dst, int16_t *res, ptrdiff_t stride); > > randomize_buffers(res0, size); > - randomize_buffers2(dst0, size); > + randomize_buffers2(dst0, size, mask); > if (overflow_test) > res0[0] = 0x8000; > memcpy(res1, res0, sizeof(*res0) * size); > @@ -69,6 +69,7 @@ static void compare_add_res(int size, ptrdiff_t stride, int overflow_test) > static void check_add_res(HEVCDSPContext h, int bit_depth) > { > int i; > + int mask = bit_depth == 8 ? 0xFFFF : bit_depth == 10 ? 0x03FF : 0x07FF; Previously we always used the mask 0x03FF, while we now use 0xFFFF for 8 bit. I presume that means that for 8 bit, we mask two pixels with one 0xFFFF (and keep all bits), and previously we accidentally masked out everything but the lowest two bits, from every other pixel, in 8 bit mode? The patch LGTM, but it'd be good to acknowledge this existing issue in the commit message. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".