Re: [FFmpeg-devel] [PATCH v3 0/5] Fix FFmpeg compilation without DCE

["L. E. Segovia" <amy@amyspark.me>]

Hi again,

Pinging again for review. I've asked for clarification about how should
the EXTERNAL_<arch> checks be dealt with, but I've not received any
response here.

Best,

amyspark

On 07/11/2022 11:48, L. E. Segovia wrote:
> Ping for review.
> 
> amyspark
> 
> On 03/11/2022 13:36, L. E. Segovia wrote:
>> Hi all,
>>
>> This new version is intended to make Patchwork log the set correctly.
>> (My apologies there, I'm not used to send patches through the command line.)
>>
>> v3 changes (same as v2):
>>
>> - Split indentation fixes for hevcdsp_init into its own commit
>> - Fixed spurious indentation in vf_ssim_init
>> - Implemented the macro approach for expanding the CONFIG_FOO checks in fftools
>> - Added the missing HAVE_X86ASM check in vc1dsp_init
>> - Added a missing HAVE_INLINE_ASM check in hpeldsp_init (see below)
>> - Fixed the HAVE_X86ASM check wrongly covering the INLINE_FOO clause in hpeldsp_init
>> - Removed the duplicate HAVE_X86ASM check in me_cmp_init
>> - Inlined the HAVE_X86ASM and ARCH_X86_64 checks in mlpdsp_init and vf_convolution_init 
>>
>> L. E. Segovia (5):
>>   all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2
>>   avcodec/x86/hevcdsp_init: Fix indentation after the ARCH_FOO changes
>>   all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO
>>   all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM
>>   all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM
>>
>>  fftools/ffprobe.c                          |  16 +-
>>  fftools/opt_common.c                       |  12 +-
>>  libavcodec/x86/aacencdsp_init.c            |   2 +
>>  libavcodec/x86/aacpsdsp_init.c             |   2 +
>>  libavcodec/x86/ac3dsp_init.c               |   4 +
>>  libavcodec/x86/audiodsp_init.c             |   2 +
>>  libavcodec/x86/bswapdsp_init.c             |   2 +
>>  libavcodec/x86/cavsdsp.c                   |   2 +
>>  libavcodec/x86/celt_pvq_init.c             |   2 +
>>  libavcodec/x86/cfhddsp_init.c              |   2 +
>>  libavcodec/x86/cfhdencdsp_init.c           |   2 +
>>  libavcodec/x86/dcadsp_init.c               |   2 +
>>  libavcodec/x86/dct_init.c                  |   2 +
>>  libavcodec/x86/dnxhdenc_init.c             |   2 +
>>  libavcodec/x86/exrdsp_init.c               |   2 +
>>  libavcodec/x86/fdctdsp_init.c              |   2 +
>>  libavcodec/x86/fft_init.c                  |   2 +
>>  libavcodec/x86/flacdsp_init.c              |   8 +-
>>  libavcodec/x86/g722dsp_init.c              |   2 +
>>  libavcodec/x86/h263dsp_init.c              |   2 +
>>  libavcodec/x86/h264_intrapred_init.c       |   2 +
>>  libavcodec/x86/h264chroma_init.c           |   2 +
>>  libavcodec/x86/hevcdsp_init.c              | 549 +++++++++++----------
>>  libavcodec/x86/hpeldsp_init.c              |   4 +
>>  libavcodec/x86/hpeldsp_vp3_init.c          |   2 +
>>  libavcodec/x86/huffyuvdsp_init.c           |   2 +
>>  libavcodec/x86/huffyuvencdsp_init.c        |   2 +
>>  libavcodec/x86/idctdsp_init.c              |  11 +-
>>  libavcodec/x86/jpeg2000dsp_init.c          |   2 +
>>  libavcodec/x86/lossless_videodsp_init.c    |   2 +
>>  libavcodec/x86/lossless_videoencdsp_init.c |   2 +
>>  libavcodec/x86/mdct15_init.c               |   2 +
>>  libavcodec/x86/me_cmp_init.c               |   2 +
>>  libavcodec/x86/mlpdsp_init.c               |   6 +-
>>  libavcodec/x86/mpegvideoencdsp_init.c      |   2 +
>>  libavcodec/x86/opusdsp_init.c              |   2 +
>>  libavcodec/x86/pixblockdsp_init.c          |   2 +
>>  libavcodec/x86/pngdsp_init.c               |   2 +
>>  libavcodec/x86/proresdsp_init.c            |   2 +
>>  libavcodec/x86/rv34dsp_init.c              |   2 +
>>  libavcodec/x86/sbcdsp_init.c               |   2 +
>>  libavcodec/x86/sbrdsp_init.c               |   2 +
>>  libavcodec/x86/svq1enc_init.c              |   2 +
>>  libavcodec/x86/utvideodsp_init.c           |   2 +
>>  libavcodec/x86/v210enc_init.c              |   2 +
>>  libavcodec/x86/vc1dsp_init.c               |   6 +-
>>  libavcodec/x86/vorbisdsp_init.c            |   2 +
>>  libavcodec/x86/vp3dsp_init.c               |   2 +
>>  libavcodec/x86/vp6dsp_init.c               |   2 +
>>  libavfilter/x86/af_afir_init.c             |   2 +
>>  libavfilter/x86/af_anlmdn_init.c           |   2 +
>>  libavfilter/x86/af_volume_init.c           |   2 +
>>  libavfilter/x86/avf_showcqt_init.c         |   2 +
>>  libavfilter/x86/colorspacedsp_init.c       |   6 +-
>>  libavfilter/x86/vf_atadenoise_init.c       |   8 +-
>>  libavfilter/x86/vf_blend_init.c            |   2 +
>>  libavfilter/x86/vf_bwdif_init.c            |   2 +
>>  libavfilter/x86/vf_convolution_init.c      |   2 +-
>>  libavfilter/x86/vf_framerate_init.c        |   2 +
>>  libavfilter/x86/vf_fspp_init.c             |   2 +
>>  libavfilter/x86/vf_gblur_init.c            |   2 +
>>  libavfilter/x86/vf_hflip_init.c            |   2 +
>>  libavfilter/x86/vf_limiter_init.c          |   2 +
>>  libavfilter/x86/vf_maskedclamp_init.c      |   2 +
>>  libavfilter/x86/vf_maskedmerge_init.c      |   2 +
>>  libavfilter/x86/vf_overlay_init.c          |   2 +
>>  libavfilter/x86/vf_pp7_init.c              |   2 +
>>  libavfilter/x86/vf_psnr_init.c             |   2 +
>>  libavfilter/x86/vf_removegrain_init.c      |   2 +
>>  libavfilter/x86/vf_ssim_init.c             |   6 +-
>>  libavfilter/x86/vf_stereo3d_init.c         |   2 +
>>  libavfilter/x86/vf_threshold_init.c        |   2 +
>>  libavfilter/x86/vf_tinterlace_init.c       |   2 +
>>  libavfilter/x86/vf_transpose_init.c        |   2 +
>>  libavfilter/x86/vf_v360_init.c             |   2 +
>>  libavfilter/x86/vf_w3fdif_init.c           |   6 +-
>>  libavfilter/x86/vf_yadif_init.c            |   2 +
>>  libavformat/rtmpproto.c                    |  24 +-
>>  libavutil/x86/fixed_dsp_init.c             |   2 +
>>  libavutil/x86/float_dsp_init.c             |   2 +
>>  libavutil/x86/imgutils_init.c              |   2 +
>>  libavutil/x86/lls_init.c                   |   2 +
>>  libavutil/x86/pixelutils_init.c            |   2 +
>>  libswresample/x86/audio_convert_init.c     |   2 +
>>  libswresample/x86/resample_init.c          |   6 +
>>  libswscale/x86/rgb2rgb.c                   |   2 +
>>  libswscale/x86/swscale.c                   |   2 +
>>  87 files changed, 517 insertions(+), 299 deletions(-)
>>
> 

-- 
amyspark 🌸 https://www.amyspark.me
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".