From: Gabriel Hege <g+ffmpeg@hege.cc> To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] avformat/movenc: fix VVC encoding with leading pictures Date: Tue, 27 May 2025 16:52:44 +0200 Message-ID: <b940a72a-66b5-4cb8-8a40-4f94d26f7c59@hege.cc> (raw) In-Reply-To: <CAFXK13fqrO9BDzgSD5ofGcjRm8G7AiyB-_F-bjT-pDnuad03KA@mail.gmail.com> On 25.05.25 04:08, Nuo Mi wrote: > On Thu, May 22, 2025 at 4:35 PM Gabriel Hege <g+ffmpeg@hege.cc> wrote: > >> >> On 17.05.25 04:26, Nuo Mi wrote: >>> On Fri, May 16, 2025 at 7:05 PM Gabriel Hege <g+ffmpeg@hege.cc> wrote: >>> >>>> This is a resubmission with a corrected commit message. >>>> >>>> >>>> The default behavior for VVenC (since v1.10.0) is to create an IDR with >>>> leading pictures for the first picture in decoding order (POC 32). This >>>> leads to FFmpeg generating an edit list with an empty entry, skipping >>>> the leading pictures. >>>> >>>> This patch fixes the calculation for the start_pts, while the DTS is >>>> negative (as produced by libvvenc). >>>> >>>> >>>> How to reproduce the issue (needs --enable-libvvenc and a recent >>>> libvvenc, e.g. v1.13): >>>> >>> Hi Gabriel, >>> Thank you for your patch. It addresses the MP4 issue, but it looks like >> MKV >>> has the same problem as well. >> >> Hi Nuo Mi, >> >> I'm sorry I don't really have an understanding of the MKV format. I had >> a quick look at the code, but the processing seems quite different and I >> didn't really find the corresponding code locations to fix the problem >> there. >> > Hi Gabriel, > Thank you for checking. > Could you help create a similar issue for MKV? Someone familiar with MKV > might pick it up. I filed a bug report: https://trac.ffmpeg.org/ticket/11611 > Hi James and all, > If no one objects, I’ll push this. > > Thank you. > >> >> >>> Hi @James Almer <jamrial@gmail.com> , >>> Could you please take a look at the patch when you have a moment? You've >>> been the most active contributor to this file recently. >>> >>>> >>>> Encode VVC directly into MP4 container: >>>> ./ffmpeg -i /data/YUV/foreman_352x288_30Hz_i420_8.y4m -an -preset faster >>>> -vcodec vvc test.mp4 >>>> >>>> -> encodes 300 frames. >>>> >>>> Decode to YUV (or play back using ffplay): >>>> ./ffmpeg -i test.mp4 test.yuv >>>> >>>> -> outputs 271 frames >>>> >>>> When dumping the mp4-structure using 'MP4Box -diso test.mp4', I see the >>>> following EditListBox, which skips the first couple of >>>> frames:<EditListBox Size="40" Type="elst" Version="0" Flags="0" >>>> Specification="p12" Container="edts" EntryCount="2"> >>>> <EditListEntry Duration="1033" MediaTime="-1" MediaRate="1"/> >>>> <EditListEntry Duration="8967" MediaTime="18432" MediaRate="1"/> >>>> </EditListBox> >>>> >>>> >>>> With the fix applied 300 frames are decoded as expected and the >>>> EditListBox looks like this: >>>> <EditListBox Size="28" Type="elst" Version="0" Flags="0" >>>> Specification="p12" Container="edts" EntryCount="1"> >>>> <EditListEntry Duration="10000" MediaTime="2560" MediaRate="1"/> >>>> </EditListBox> >>>> _______________________________________________ >>>> ffmpeg-devel mailing list >>>> ffmpeg-devel@ffmpeg.org >>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>> >>>> To unsubscribe, visit link above, or email >>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>> >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> >>> To unsubscribe, visit link above, or email >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-27 14:52 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-05-16 11:05 Gabriel Hege 2025-05-17 2:26 ` Nuo Mi 2025-05-22 8:34 ` Gabriel Hege 2025-05-25 2:08 ` Nuo Mi 2025-05-27 14:52 ` Gabriel Hege [this message] 2025-05-31 1:51 ` Nuo Mi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b940a72a-66b5-4cb8-8a40-4f94d26f7c59@hege.cc \ --to=g+ffmpeg@hege.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git