Re: [FFmpeg-devel] [PATCH 3/5] avformat/mxfdec: Check container_ul->desc before use

From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/5] avformat/mxfdec: Check container_ul->desc before use
Date: Tue, 18 Jun 2024 16:31:49 +0200
Message-ID: <b935904a449e5c1916645028df47273769e57023.camel@haerdin.se> (raw)
In-Reply-To: <20240607003215.1723906-3-michael@niedermayer.cc>

fre 2024-06-07 klockan 02:32 +0200 skrev Michael Niedermayer:
> Fixes: CID1592939 Dereference after null check
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavformat/mxfdec.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index e65cec74c23..820b03940aa 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -3031,6 +3031,7 @@ static int
> mxf_parse_structural_metadata(MXFContext *mxf)
>              if (container_ul->desc)
>                  av_dict_set(&st->metadata, "data_type",
> container_ul->desc, 0);
>              if (mxf->eia608_extract &&
> +                container_ul->desc &&
>                  !strcmp(container_ul->desc, "vbi_vanc_smpte_436M"))
> {
>                  st->codecpar->codec_type = AVMEDIA_TYPE_SUBTITLE;
>                  st->codecpar->codec_id = AV_CODEC_ID_EIA_608;

OK

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".