From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AED044988E for ; Thu, 20 Jun 2024 15:54:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9437B68D879; Thu, 20 Jun 2024 18:54:18 +0300 (EEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E591968D816 for ; Thu, 20 Jun 2024 18:54:11 +0300 (EEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1f9b364faddso9434215ad.3 for ; Thu, 20 Jun 2024 08:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718898850; x=1719503650; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=7HLWJxZLrp4PNgXh7AE53lJmOVvg7CymRYw05VGnuDM=; b=i2u31428yf6+QbT0jdXq1nfoneH4JNUYy+wP8UsBjQd9IP+YPLvr6vST030n/KNivD CpTPrr7s6fs3hdfesrOSpedhp8zT65Odq6fHaztvqS843hmAPVb9hRV+6R55XdWcVOpg pweDt0C8A/K78cYq3BNEnyEq5XZVLpYnNAg4QPoIveHm1pSidgZvFFANfTD7U4g5LeyO 4Z+KU5Rxz4KhE4ZVOwJsjgjFsZb+LCfI0Havt6IQgm1BuaAzcdGgxBRu9lyVgJKhpGGb gDrf+FlHy2F9DusstZdZ+lbX4bcyZdbSTosWWzClOP4s5p13RzjevRQmtg++crX/dvbS OHeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718898850; x=1719503650; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7HLWJxZLrp4PNgXh7AE53lJmOVvg7CymRYw05VGnuDM=; b=iyiKHEQKnN63+eabFjek+gy6BDjQ6zCqD+sndfbRjnWbZ7o+TdUrfd34hq/mluLgVf fZy7/J50zljlbc2T7hh3RnVeX7K0H2PJXo1lC8hsGWUncgBHzCrACGBJxv9kPkW3I6Fq ASYzUxjv//d5leA3M9KSsaW/6PiI87yZG05OJN0+nzkUJbxvKGSP5taYT9XzLcoVkLAU tGY/hZ79LPYf2t8Vhbm3gbuEtONLZLBvS/+F2WnVeDwHI0tcikbheB7BuvQ2vQS+HCF4 5CpQ57uFZIwrz8DnSs2WVGd9FyM1XCjibapay8YrT6nsULQhu7K/CDG6WVCkT91/A6EY vkzA== X-Gm-Message-State: AOJu0YwXvhDV5MLkLodN3Jkl+o93k1Ephkvh+nDkLpLNBta3l2e78R0Y 2ZUgbCeyuNuLIEZFfEXFLGsgt8B5x+61MK9tOUFza7BsLurYApsNzyBwzw== X-Google-Smtp-Source: AGHT+IG5fpbIXl0K3VDBJAoHyxHbDmDBmMsHSxGgFnYwoNzTaTPXsfW2VJiQTqeYA5BdOc5lkgk/pQ== X-Received: by 2002:a17:903:2352:b0:1f9:c0db:a3df with SMTP id d9443c01a7336-1f9c0dbafaamr35525905ad.42.1718898849632; Thu, 20 Jun 2024 08:54:09 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9e3fadca3sm950015ad.30.2024.06.20.08.54.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 08:54:09 -0700 (PDT) Message-ID: Date: Thu, 20 Jun 2024 12:54:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20240618192034.5027-1-jamrial@gmail.com> Content-Language: en-US In-Reply-To: <20240618192034.5027-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 1/3] avutil/ambient_viewing_environment: set a sane default value for AVRational fields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/18/2024 4:20 PM, James Almer wrote: > Prevent potential divisions by 0 when using them immediately after allocation. > > Signed-off-by: James Almer > --- > libavutil/ambient_viewing_environment.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/libavutil/ambient_viewing_environment.c b/libavutil/ambient_viewing_environment.c > index c47458cfa8..e359727776 100644 > --- a/libavutil/ambient_viewing_environment.c > +++ b/libavutil/ambient_viewing_environment.c > @@ -21,6 +21,13 @@ > #include "ambient_viewing_environment.h" > #include "mem.h" > > +static void get_defaults(AVAmbientViewingEnvironment *env) > +{ > + env->ambient_illuminance = > + env->ambient_light_x = > + env->ambient_light_y = (AVRational) { 0, 1 }; > +} > + > AVAmbientViewingEnvironment *av_ambient_viewing_environment_alloc(size_t *size) > { > AVAmbientViewingEnvironment *env = > @@ -28,6 +35,8 @@ AVAmbientViewingEnvironment *av_ambient_viewing_environment_alloc(size_t *size) > if (!env) > return NULL; > > + get_defaults(env); > + > if (size) > *size = sizeof(*env); > > @@ -44,6 +53,7 @@ AVAmbientViewingEnvironment *av_ambient_viewing_environment_create_side_data(AVF > return NULL; > > memset(side_data->data, 0, side_data->size); > + get_defaults((AVAmbientViewingEnvironment *)side_data->data); > > return (AVAmbientViewingEnvironment *)side_data->data; > } Will apply the set soon if nobody objectx. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".