From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6917D46A9D for <ffmpegdev@gitmailbox.com>; Fri, 21 Mar 2025 21:59:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6E4E0687C12; Fri, 21 Mar 2025 23:59:23 +0200 (EET) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B1836687B8F for <ffmpeg-devel@ffmpeg.org>; Fri, 21 Mar 2025 23:59:16 +0200 (EET) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5499659e669so2889806e87.3 for <ffmpeg-devel@ffmpeg.org>; Fri, 21 Mar 2025 14:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1742594356; x=1743199156; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=iA8Ygcp2Y2aBUMERMUWihPd3dpJ7ZJT5idJsizRff1Y=; b=IA8aOkoWmQTWJmRaM9OpOhkZztBxkQYA0CYQCBhV0Jze39Z9t0NHDzg2Z/JVnmDVtE 1kov3H0otmEc3iF7+ARV8txgwCvfSW8eU0no3TrY2poyT8Oz5oCiyUYjnwhiL64TIq8R hF2BWUnrPU/IFkKAr6YT7syDAlZpWQt9BKJHvmRkchoC9vyVUsU21rGzDGBUkX5+krj/ tCYaKXoAT2dICN5Yu9RZvanZJiJXUWkVIXyvcp3ucj7Gri14POc11lG+98pMEjvB62yz KMvm2puL5riEVP5PGoeBxQTX0nVG1s8Hgfk/bXguVxjyuqSN6PAk4fRUvGF1Tn62i8kX BJUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742594356; x=1743199156; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iA8Ygcp2Y2aBUMERMUWihPd3dpJ7ZJT5idJsizRff1Y=; b=TSHn0X23RwKiA6N7TpBeTPMsT7PTjtM206z5IqaMrIROpQ1F/0BQ9b3fpzsijdONyr +XBQ8CLLgYFZEnJde3j1CSOwCzDDRZxETpljgIa7V/6wmy/rR2cCU5oNQHJVDq3VEPD6 MamErEmv7tGDud6q5XENWVMIZhddtTALXmvDDctmyDdzlA6NH+708cHqOrR/XR8CUK8W E0M0no7Y1ERZnlK44A6VxhAqc+wrCu5r+hyt6L+slmk6bCC3CftC8WxA+rQKCrF8/EW+ WMszwSji2q/rMFo5gztdhRPN11CyaVF+vFhlknQ3QpLxX/2XmB2iyVl6kYrjdz6N5z+O pNfA== X-Gm-Message-State: AOJu0YxDdvBhk7EW6JAlFaY512TbBlNa4dTIsh+6hObQtM0rl/4w9xv6 FNDFsmD3ks2/6C4ZVLzJG7Wken6X3R1QvLCDzwASTFjyIJk/bANjFDafVZa4XlIVg7VKa+ESCLg 77w== X-Gm-Gg: ASbGncuWesO6kexV43aQf7DllCoZWIdbocvXzLv+LplKqwtjtZMGJNyeiMSEV4MlEcG epfhfHXMpIz372JtKsqe/Ovzl4E/qOg+CIEgJKEl04sYFBrhG21tjscQHzjE2iKXUH3hOPJaMFS pM0Qjsavz/ZJ/QXRAgnuja9Seeh3dWFoWG6Mop8WEs+uow0Q40U2dysLlCM6mSaCUg6wc3bf6PX OerRO4+7zXnE0MSJAgz2SIzzHJcCKleHSEea7ffTIb7kC7axJMK86p2Kt5zHioO8SUMq63fX1TL WoEyj2C3kfxALW2S0/n2fssUUb7tPHwgAi94hp2N/ah95aEGuamq1g6GE3J4VbOzsaF3c/4eUSr 6x2mDdCs+5ogHh2yU05CgtsPslaLwKwvnTrci9xMvXK8ji5xekL4= X-Google-Smtp-Source: AGHT+IFnM3rhxgbOeJEHsNnCYVLBX+d4T8D+PGXULoBeiOLfjYp5ma2tErw/t6UaIKT98WM6DR6+Lg== X-Received: by 2002:a05:6512:e96:b0:545:9e1:e824 with SMTP id 2adb3069b0e04-54ad650ca46mr2145544e87.48.1742594355258; Fri, 21 Mar 2025 14:59:15 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54ad651156bsm273631e87.212.2025.03.21.14.59.14 for <ffmpeg-devel@ffmpeg.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 14:59:14 -0700 (PDT) Date: Fri, 21 Mar 2025 23:59:13 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> In-Reply-To: <20250321104136.54347-1-ffmpeg@gyani.pro> Message-ID: <b8df6d89-2f93-5031-1b1c-1e1f2a141841@martin.st> References: <20250321104136.54347-1-ffmpeg@gyani.pro> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/b8df6d89-2f93-5031-1b1c-1e1f2a141841@martin.st/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> On Fri, 21 Mar 2025, Gyan Doshi wrote: > Avoids echo failing due to the same ARG_MAX limit that prompted > response files to be used with the linker. I presume this is only a fix for a hypothetical issue, _if_ echo would be a native windows executable and not the msys2/cygwin one which bypasses the limit? > --- > ffbuild/library.mak | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/ffbuild/library.mak b/ffbuild/library.mak > index 7e1871b74c..15302852ec 100644 > --- a/ffbuild/library.mak > +++ b/ffbuild/library.mak > @@ -36,7 +36,8 @@ endif > $(SUBDIR)$(LIBNAME): $(OBJS) $(STLIBOBJS) > $(RM) $@ > ifeq ($(AR_OBJS),true) > - $(Q)echo $^ > $@.objs > + -$(RM) $@.objs > + $(Q)$(foreach ARG,$^,echo -n "$(ARG) " >> $@.objs;) Does this instance even work, it looks broken, like it is missing something? > $(AR) $(ARFLAGS) $(AR_O) @$@.objs > else > $(AR) $(ARFLAGS) $(AR_O) $^ > @@ -73,7 +74,9 @@ $(SUBDIR)$(SLIBNAME): $(SUBDIR)$(SLIBNAME_WITH_MAJOR) > $(SUBDIR)$(SLIBNAME_WITH_MAJOR): $(OBJS) $(SHLIBOBJS) $(SLIBOBJS) $(SUBDIR)lib$(NAME).ver > $(SLIB_CREATE_DEF_CMD) > ifeq ($(AR_OBJS),true) > - $(Q)echo $$(filter %.o,$$^) > $$@.objs > + -$(RM) $$@.objs > + $(Q)$(eval LDARGS=$$(filter %.o,$$^)) > + $(Q)$(foreach ARG,$$(LDARGS),echo -n "$(ARG) " >> $$@.objs;) Wouldn't this be quite significantly slow on msys2, where process creation is much slower than on unix? I think it's not worth to make things that much slower (which I only guess here) to fix a hypothetical issue. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".