From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C1D9848C30 for ; Sat, 23 Mar 2024 11:17:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 98DE468D438; Sat, 23 Mar 2024 13:17:37 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7C71D68D198 for ; Sat, 23 Mar 2024 13:17:30 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 46A0AEA1EE for ; Sat, 23 Mar 2024 12:17:30 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ir6bRNyczPae for ; Sat, 23 Mar 2024 12:17:28 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 2EFBDE9A30 for ; Sat, 23 Mar 2024 12:17:28 +0100 (CET) Date: Sat, 23 Mar 2024 12:17:28 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <383e7f14-4393-47b9-c138-069b8357b832@passwd.hu> Message-ID: References: <20240317195611.11278-1-cus@passwd.hu> <383e7f14-4393-47b9-c138-069b8357b832@passwd.hu> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov_chan: respect channel order when parsing and creating chan atom X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 18 Mar 2024, Marton Balint wrote: > > > On Mon, 18 Mar 2024, Andreas Rheinhardt wrote: > >> Marton Balint: >>> Previously we always assumed that the channels are in native order, even >>> if >>> they were not. The new channel layout API allows us to signal the proper >>> channel order, so let's do so. >>> >>> Fixes ticket #98. >>> --- >>> libavformat/mov_chan.c | 464 +++++++++++++++++++---------------------- >>> 1 file changed, 211 insertions(+), 253 deletions(-) >>> [...] >>> +#define TAG(_0) (struct >>> MovChannelLayoutMap){.tag = _0} >>> +#define ID(_0) (struct >>> MovChannelLayoutMap){.id = c_##_0} >> >> Code like >> >> typedef struct Foo { >> int a; >> } Foo; >> >> Foo bar[] = { >> (Foo) {.a = 1}, >> }; >> >> is not valid C11 (or C17), because initializers for static objects are >> subject to severe restrictions; in particular, compound literals are not >> allowed. GCC and Clang ignore this except when using -pedantic, but MSVC >> does not: https://godbolt.org/z/hvnrh63za >> Just remove the "(MovChannelLayoutMap)". > > Ok, will do, thanks. Will apply. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".