From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6125942588 for ; Fri, 18 Mar 2022 22:44:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B5D0168B12A; Sat, 19 Mar 2022 00:44:12 +0200 (EET) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6AB5768AF4C for ; Sat, 19 Mar 2022 00:44:06 +0200 (EET) Received: by mail-oi1-f182.google.com with SMTP id n7so10330444oif.5 for ; Fri, 18 Mar 2022 15:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=MNmF/t8vHts9hHWBAY03avj+uO+X8ogFufO8iEqZCpQ=; b=k6eEsijlFuyZE7RSHzMCLubU1GECcTo7jEHyhll/Y+ZoW3+dh8SIQEV3SMkQ4l1qqm O4FEFfJMGpSTG5JMhDZYF2244g3+3+vdGkmSsIRTSxj8c4WD8Ce6gwywQfprtNZ6G/Ex DAvgZUmv5kOyDqhK6+WIjEf2EkX9c2pdd3CKk5hcZza2ltGvyv0d9q7aoELya12v9vIw dwQjU3ztjWNyQeu3F3WO4cND86a8YgyOLgl1Usyvse5ayM5UcHTeStcna0lD4jppebAW SWMN2uDXPGLawK35XOggFHnpwjo9caUFyyqGFtLoWmWDqI9GFHygTxYjufVoXVwTAfgO Ouuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=MNmF/t8vHts9hHWBAY03avj+uO+X8ogFufO8iEqZCpQ=; b=5Q9kpe40qM6BLCej1OQwOeXthNG4MogpfIIKl6sxymeU9ILjiX2BrAgh0dPDm2Gbz+ 05h5aYPuCNLygsvENFPbY+WunO4LMfdNaxQynryXym0BEuBwLAtOj+whQDEOGRk1wulo u0G62vchzeWKI1iOpPZZcI5BNdOAdvU0u6DgCxoKB/DZR7HcBuiu03G7cMmsgIf1jBJC 9D9Bha1rOEizCY0ck8+aXTANFRkVA67cqKdEAmURWSRtTF2l6fQ/u4MTiiSpHFDX7UWS BDplzG9sWIrt9HwGOMlwyL0yRcGcUTdGnyyWeT/4zNmN3VnlBBmSPyfwyT1/7g/d/fBg /X5g== X-Gm-Message-State: AOAM5312Iv6+NGAU0fe8jiLDprTgPRiv3aqTie4aQY9EsoNTXFWfuO92 Ezewsh5YX3f6gOG7csET39wNoDs+GEULLw== X-Google-Smtp-Source: ABdhPJx954okB04ZKk8U+Kn0d31CUur25U7qGqu29h1SOVcrNFhZNuJQ+HNJcUvyKnucpMOF9m9CcA== X-Received: by 2002:a05:6808:2218:b0:2d9:c3f2:4042 with SMTP id bd24-20020a056808221800b002d9c3f24042mr8861351oib.270.1647643444701; Fri, 18 Mar 2022 15:44:04 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id b188-20020aca34c5000000b002da579c994dsm4315798oia.31.2022.03.18.15.44.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Mar 2022 15:44:04 -0700 (PDT) Message-ID: Date: Fri, 18 Mar 2022 19:44:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220318221907.44594-1-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/slndec: add support to set channel layout X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/18/2022 7:41 PM, Andreas Rheinhardt wrote: > James Almer: >> Signed-off-by: James Almer >> --- >> libavformat/pcmdec.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c >> index dcd13787d5..a2bcfc2814 100644 >> --- a/libavformat/pcmdec.c >> +++ b/libavformat/pcmdec.c >> @@ -170,7 +170,8 @@ PCMDEF(vidc, "PCM Archimedes VIDC", NULL, VIDC) >> #if CONFIG_SLN_DEMUXER >> static const AVOption sln_options[] = { >> { "sample_rate", "", offsetof(PCMAudioDemuxerContext, sample_rate), AV_OPT_TYPE_INT, {.i64 = 8000}, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM }, >> - { "channels", "", offsetof(PCMAudioDemuxerContext, channels), AV_OPT_TYPE_INT, {.i64 = 1}, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM }, >> + { "channels", "", offsetof(PCMAudioDemuxerContext, channels), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM }, >> + { "ch_layout", "", offsetof(PCMAudioDemuxerContext, ch_layout), AV_OPT_TYPE_CHLAYOUT, {.str = "mono"}, 0, 0, AV_OPT_FLAG_DECODING_PARAM }, >> { NULL }, >> }; >> > > There is no avformat/slndec. And I presume it is possible to set an > unspecified channel layout via AV_OPT_TYPE_CHLAYOUT, so why don't you > deprecate the now redundant channels option? There is no slndec, but it's the sln demuxer, so it seemed better than to write pcmdec. I can change it if you want. And yes, I was going to deprecate the channels option, but in a separate patch(set). > > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".