From: Andrew Kelley <andrew@ziglang.org>
To: FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>,
Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths
Date: Wed, 10 Apr 2024 14:06:44 -0700
Message-ID: <b878d8d4-a330-425b-8c49-9d752ed80f6e@ziglang.org> (raw)
In-Reply-To: <AS8P250MB074494704C2B246B486366F98F062@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On 4/10/24 07:11, Andreas Rheinhardt wrote:
> I don't
> see a simplification of the Makefile.
Relevant part from the diff:
--- a/libavcodec/bsf/Makefile
+++ b/libavcodec/bsf/Makefile
@@ -45,5 +45,3 @@ OBJS-$(CONFIG_VP9_SUPERFRAME_BSF) +=
bsf/vp9_superframe.o
OBJS-$(CONFIG_VP9_SUPERFRAME_SPLIT_BSF) += bsf/vp9_superframe_split.o
OBJS-$(CONFIG_VVC_METADATA_BSF) += bsf/h266_metadata.o
OBJS-$(CONFIG_VVC_MP4TOANNEXB_BSF) += bsf/vvc_mp4toannexb.o
-
-libavcodec/bsf/%.o: CPPFLAGS += -I$(SRC_PATH)/libavcodec/
>
>>
>> It also reduces ambiguity, since there are many instances of same-named
>> header files existing in both libavformat/ and libavcodec/
>> subdirectories.
>
> What ambiguity?
For example, if a contributor sees #include "vvc.h", they do not know if
that is libavformat/vvc.h or libavcodec/vvc.h without also being aware
of other context, such as the above line in the Makefile. The
explicitness reduces the amount one must know in order to read the code.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-10 21:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 21:13 Andrew Kelley
2024-04-10 0:04 ` Lynne
2024-04-10 1:11 ` Andrew Kelley
2024-04-10 1:23 ` James Almer
2024-04-10 4:54 ` Anton Khirnov
2024-04-10 13:47 ` Lynne
2024-04-10 14:11 ` Andreas Rheinhardt
2024-04-10 18:35 ` Paul B Mahol
2024-04-10 21:06 ` Andrew Kelley [this message]
2024-04-10 21:27 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b878d8d4-a330-425b-8c49-9d752ed80f6e@ziglang.org \
--to=andrew@ziglang.org \
--cc=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git