From: "Martin Storsjö" <martin@martin.st>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] fate/matroska: Stop using unicode in command line paramters
Date: Tue, 22 Aug 2023 22:08:48 +0300 (EEST)
Message-ID: <b8594c77-6249-a188-7283-90e82b176de@martin.st> (raw)
In-Reply-To: <20230821201518.2132316-1-martin@martin.st>
On Mon, 21 Aug 2023, Martin Storsjö wrote:
> The fate-run.sh shell script exports LC_ALL=C before invoking the
> test executables; this is probably done for consistency.
>
> When executing Windows binaries with Wine, it normally handles
> UTF-8 command line parameters just fine - but with LC_ALL set to
> C, it treats them as plain ASCII.
>
> As the unicode command line parameters wasn't the main thing
> being tested here, just convert them to plain ASCII, for
> portability. This fixes the test for all test configurations that
> use Wine.
> ---
> tests/fate/matroska.mak | 6 +++---
> tests/ref/fate/matroska-stereo_mode | 10 +++++-----
> 2 files changed, 8 insertions(+), 8 deletions(-)
OK'd by Andreas on irc, will push.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-08-22 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 20:15 Martin Storsjö
2023-08-22 19:08 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8594c77-6249-a188-7283-90e82b176de@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git