From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 57A3042FFD for ; Fri, 17 Jun 2022 05:14:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7770868B73C; Fri, 17 Jun 2022 08:14:51 +0300 (EEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BE6FD6801A2 for ; Fri, 17 Jun 2022 08:14:44 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655442890; x=1686978890; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=y8MAU6/FpssrpTb1RJOT105AgCFopFsrnU+zVtexRys=; b=PeuaFiyKIX0ynMg7lami3mgOyRTLDWiQkykx5/MWyO1890a6NXz9g+jG V37UzKSI7TBpfXzc3Xz6Nt7iBgd7peB4NnCmvS4P2Y5LavG8PDbgdZcrq 0MjwkscydR1jvC0uJZbd/6vPVb+Cf3Jfs07bHtiqJz8XQjovpOhxaxJ5w 9n3HcKUjJ/7MMhkL60/+rw9xK7izkDFJXA9ntFmB1CU2xnNwQzsGTYADn PCl/CKjtk2zarZEE3w3pduwnzefxRqxHxR/nt4Ymivo5kPRtwrEtJ+/rv 6Swye9gWGab6aS/J+JLvYeS/sY5KuPWr2f2ADJe8cbjENvCgpTcZ2TWAA w==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="278218236" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="278218236" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2022 22:14:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="619147432" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 16 Jun 2022 22:14:29 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 16 Jun 2022 22:14:29 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 16 Jun 2022 22:14:28 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 16 Jun 2022 22:14:28 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.42) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 16 Jun 2022 22:14:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HBUvkP5gLuFL8CYQWF7aZi6Xhqk/G15+E6hDGSsh8c9QxEE1weX899dfmgP9Qm0L3Dy4c/ofUob/WmmTtwDugXWhx7znUHGr9CSNZ+SemYle7uuhzOpoC/ub+rLvOHdvpFzSCahI5CSZLgrMvd3dWoQ+Im4519fLwtLG8kIW8UOsl73qcuUEjDIPweztsTi07KaE90eQW5uN34ourt23RL8stnk0tBAa+BiRzubfdFuQE5zZC7ubt1W0LayjOd8CONHItUxO0FI8SAszGygxM2pYUMaywD8LwQ1qFmAvbz9btWu2GuHWYnB1B/3f2om9km2175IGsNBlgzizyXU4lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y8MAU6/FpssrpTb1RJOT105AgCFopFsrnU+zVtexRys=; b=FsWwuWk/xSLt6E57+ut3jYH8Ouc1LgpEWOinJQbEqBJSyRO8CVqewMjKMWXVxK7BE+Hck6XsRWlBHVfncZ1XTShYT+INEM/QNCGeci0USdtAUdni5752GcouZp8mpQjC+7Bi4id+sA3neaeb+xnBgBA4lXrRIoOKa03MtaULqKRHeItTMgcC9UhPeyvp7jRUFUrozKoIH+HCxGx0SKa6tO/n79/gnffWWfzQDCZClvMXBXhTh4CUXS0tw08d/Cd6z4tUF6G/EYv89DCYKv0RqDm1TV+temzG/wsoyPgCkNuERIFijQ8fSI/s+5spRjeM/CUcC26mB/fRhD7bIlYJkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MN2PR11MB4287.namprd11.prod.outlook.com (2603:10b6:208:189::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.15; Fri, 17 Jun 2022 05:14:27 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::65d2:4e26:5290:7b5f]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::65d2:4e26:5290:7b5f%5]) with mapi id 15.20.5353.015; Fri, 17 Jun 2022 05:14:27 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2] lavc/vaapi_hevc: fill rext luma/chroma offset in the right way Thread-Index: AQHYfMnf9sqDkXSZxU6JQQEtUO6uya1TGKWA Date: Fri, 17 Jun 2022 05:14:26 +0000 Message-ID: References: <20220610124747.2767836-1-fei.w.wang@intel.com> In-Reply-To: <20220610124747.2767836-1-fei.w.wang@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 31334ca5-01e7-4159-17d3-08da50204008 x-ms-traffictypediagnostic: MN2PR11MB4287:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MPTe6Hwx+ePXRvRkl6ZRumfFT5twzKFYQ9uiCr6S0odfe3FCGspC6Mqn215Sn2uEqGG72sPDwRUCCyepiE2EkPDH/fKTwXT63z3AgHKFuXersTh85jUN+mMG36QwX6cPmuGunJuQ083PSYrQsWYTivoZ79v90fFj0lVBfZU6zDFduHuaPGGzCJE4KvtXZQxyq4sFwtON5sijX4dEg0tk71H470py04Okjs/x9e3+5nky8+GAjgWheNwRnLGl3fLpA3uRQQxIlKnCoQ+9PWwXqvaQAznxzb+eQGSjY7p1/lsNwWSG0thEnVX2XC3ssCKYPsyWVBfoGfNgZx0YuFDm9ktMtU+NIK5PJEhre25c7YVCq2fXIBEdrbD0l4/FTp93Wyt81bE2qL13kCS6Xks9CHLzjSyeXh5h0pvd/ETArXtjjxAxQLtw4ZHOA4b/guU8Kn8JDL/wf5WyBxR1zBPclitcsSDw0LZwt8WgUKaRxd0UCjZdcrjEeZXkKmSe5YZTfSUB1+WO9MMPbRFq0XFq0RapySRIDgmWDuJWsUKleaGylA4LY4z+O1BRnP/NPBXME08mK6kPAB3S5BPDGq49AYwOyU02UD6MXaaxJvlq71nKBwb7W47MzGCDQgDG+FQ/1986wSp+zRaRLZ6sGCseIEHN5Olf8q5XdtV4J0A0Dx7hxeFifbkNrylZOTqC2mawWOwJasRhY908Zh4nyciMx9hlkE5iWMgAZN4fxySnyZU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(54906003)(186003)(66556008)(76116006)(71200400001)(64756008)(4326008)(8676002)(91956017)(8936002)(2616005)(6506007)(6512007)(66446008)(66476007)(6916009)(66946007)(83380400001)(26005)(86362001)(38100700002)(36756003)(316002)(5660300002)(508600001)(2906002)(122000001)(82960400001)(38070700005)(6486002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YldKY0lLVTFSY2pZejdDTklhcEZ0bk5tVE8wVzV0OGt4R3VVRTF3cG11ZGZh?= =?utf-8?B?R1lNd1l2K0VFNDhyeVdaWkw2M2hOUjdNbDR1N2ZnOHRhSzcvWno2aUxEemNO?= =?utf-8?B?VHRqbHVBVFU2WkFXV250c3ZtTkpHWXo3dkdHMnV3Zlg0KzdjMnFLQ2ppQWNn?= =?utf-8?B?U0VBOVVkYzZtWk9HczU5VCt2d2EwUklDY1pJckZnV1IyM29XWGtONndpc0Vq?= =?utf-8?B?cUdlSzdFTkxGYUlBNEhzcWtZQkFsZVQyUkxyY0xPZ2FRV2JUREdzOERiRTVo?= =?utf-8?B?ZXR3TDVOWXRFZ0pyT0pCU1NiVHR1YjhjekpBMVAwVm0xOGUrSjFML1FUYVd2?= =?utf-8?B?eUZIZ1M4UlNFZmNvZkRad2Z3bTRKS0MwaE1qRHVKNFpUQjZaMlhma2pabmRp?= =?utf-8?B?cWxhR3h0UEFxTEtPZk13aldEdWhCeUV5dGQ4cDhsSjh4R2Y5cXNJblBwWks5?= =?utf-8?B?TlhLdEtHMUhOWmlkQnpDZXJSSHoxUG9jWlV0dUVKZ2doTTg3RFp2TFN0cnh6?= =?utf-8?B?K0Z3TEk4YUE0Z0NrWGQwUStGeGNKd0pETGV2STBLV1VQQkdnU0NpbE5wT2FW?= =?utf-8?B?ZllpejZFQmM0SUlkY0d5TjBKTVFkUXRTNXZ4Nk5waDlmYnFBVEtiaEFmdzg0?= =?utf-8?B?RHg2OHhrREE5YVkrc2pFbHlpODQ2QzViVDU4RCs4OWFkN1RMVWE1b1JQQUQx?= =?utf-8?B?VVJCUEl1U3RnQURTTys0WVdCcmhobW1kOEdrSFpjV3drVWpuMWc4YklqbWxD?= =?utf-8?B?UEs2YVJMSk5oTDAybkJveVljaWgvWlNsRWZJY0FaU1hoNUphRzl4cmt6bVFs?= =?utf-8?B?THJJNWJvRDQ5ZXhiZU1XbHVrQ2RiZDBMZ1IrODhkbWRTdEZPZTlaTGszNXlz?= =?utf-8?B?ZXI0R0RtdTcwSkZTNUdReUFyQVhxU3JkZ2Z4eGF0dFdKcUwveW96djAzM1BN?= =?utf-8?B?TFlqcndCbVZvcU5EeW1YR0E4bTRFdnFQelJTdldBcithb0J3clJuTjBpRk1K?= =?utf-8?B?TFNtZkZVeFVNcGM3T2lieEYzeTJnMTI0b1RaSkJ5SVVJb0pDL0ZCUWRYcXJn?= =?utf-8?B?aHFZWkc4Q29YaVVxWnhzdGtmOFk4QnVIZWZ0bmhvTHB1bXYyTy92UTh0Y29U?= =?utf-8?B?c2VLQWxCNGlVREgydm4xNTlaRk5McnltUE90K2lPcDMxdllob283QXR3azJX?= =?utf-8?B?QmdlaGgwY3VLWVhNeldmNkhINmZBRUZRSHdFN2FmQXZOVjJheHQ1d2FzUHZG?= =?utf-8?B?bUZwTDd3N3VFZnN1UzVsN2xDWDN1SElUdjhabFlQOUxUQUhwb3JKZWNGdUdV?= =?utf-8?B?VnBvUWJUQm9mTTdMbHpwTHFDMzY4UWZaSkF1bmxjTEpmRzNJQ05rVmhuckpD?= =?utf-8?B?cmJoLzN4U0JwbEtJVmpwNEhRRTNHTGNsdkVZdDVQaTRGYUxqZ1c5bmtxTXlR?= =?utf-8?B?cEpzb0NjWU9oVlN2UjExbGxtOHZwc2FPcWx5azk4cjdkeXhZdFZqeHVubXVF?= =?utf-8?B?S1h3MFlFU0pSSXpqOUpxR0lHODRwSUNHRG1TN1FkSEs5NSthZDhGWllMTWV6?= =?utf-8?B?RFBCbDBzVDNRRVM2cEpHT0JJTVVoQ2N6V3YvY1JiU24vMk9Sc0hlQytRUU9C?= =?utf-8?B?SmtUYnFpOUdPOE9wcnVjRUR0cXVCeno2ekdzQWNIZWRUR1FpbHhPODBkVml1?= =?utf-8?B?SVpaWG82V2RyQzZzVWd0aHpBVXh1aVlXaWhpSmJoZldSZmZUZVNBamYyejdQ?= =?utf-8?B?cm1xckowc0lBYnZRMVdib01WT25uVmVBbHhvaFlFL05ZeG0wOHBVR0RhRnBa?= =?utf-8?B?REIzOTRCTjhKOFZnV3J4UTd0d3F5aW91Q0pNTnBVQ3Y3ZDNyVFZmZVhzaXB5?= =?utf-8?B?dWVMMENnWmYyNWRna2RUcFRhbTJyN3Vad0w4enVJM05WMTdxRmhkUXVHN0Vm?= =?utf-8?B?TWI3WmIzL1I4dUl0VUZSYTFVWkRRK0p5TlpreU5QbnBFMjFPTGJpNVRaUXY3?= =?utf-8?B?NnB5YmxXNFV3N0k5UWxrZWdDVUVNVWpIOC9pSkdteVQrNUxxMXcvYlFpSWRC?= =?utf-8?B?TDVGNzZ0S0VVMkpUNEhrY0JoQWh0YXB6WDlpMHdKVVdPdEVlYzhBa1JhU2ZT?= =?utf-8?B?N0MvRE91eURWeCtiZ0VYVkFTZVdzN2hFTUkvNEtOMWNLdE16T0V3QURLa3lL?= =?utf-8?B?TVBmellpV2lUUXA1Z1R6Z3ZUL3J0Q0Q2RkVUYno0ckkyM2VRWWxqM2RqUEli?= =?utf-8?B?MGxJd0pCa3N2ME53WnRtc3Z4L3hNeE91YTB0WmxiOGFiTmVBcU5ibGhTdklv?= =?utf-8?B?T3lkNXlNdlYvcmUzbkc3cmJBanAwTlZsa3NNMzZ5YVM1UXcxVjMrYm03UUR3?= =?utf-8?Q?n5bFrtFIFzAxvfvY=3D?= Content-ID: <62285F61A9647546AE5F9B89C53553CD@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31334ca5-01e7-4159-17d3-08da50204008 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2022 05:14:26.9481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IlweHsPVMfIqRdeQOGbqvuUYe9ViPueqvjDyO6qRxocSfUL26rGXV9FyFR8Fdx/qDaKMXcxIZ0jOCPZdqR1yhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4287 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/vaapi_hevc: fill rext luma/chroma offset in the right way X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Xu, Guangxin" , "linjie.justin.fu@gmail.com" , "Wang, Fei W" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2022-06-10 at 20:47 +0800, Fei Wang wrote: > From: Xu Guangxin > > For range extension, the luma/chroma offset is larger than 8 bits, we > need fill the 16 bits version. > > Signed-off-by: Xu Guangxin > Signed-off-by: Linjie Fu > Signed-off-by: Fei Wang > --- > update: > 1. Add some warning log. > > libavcodec/vaapi_hevc.c | 55 +++++++++++++++++++++++++++++------------ > 1 file changed, 39 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/vaapi_hevc.c b/libavcodec/vaapi_hevc.c > index 9083331c45..d82975979a 100644 > --- a/libavcodec/vaapi_hevc.c > +++ b/libavcodec/vaapi_hevc.c > @@ -322,11 +322,20 @@ fail: > return ret; > } > > -static void fill_pred_weight_table(const HEVCContext *h, > +static void fill_pred_weight_table(AVCodecContext *avctx, > + const HEVCContext *h, > const SliceHeader *sh, > VASliceParameterBufferHEVC *slice_param) > { > int i; > +#if VA_CHECK_VERSION(1, 2, 0) > + int is_rext = avctx->profile >= FF_PROFILE_HEVC_REXT; > +#else > + int is_rext = 0; > + if (avctx->profile >= FF_PROFILE_HEVC_REXT) > + av_log(avctx, AV_LOG_WARNING, "Please consider to update to VAAPI > 1.2.0 " > + "or above, which can support REXT related setting > correctly.\n"); > +#endif > > memset(slice_param->delta_luma_weight_l0, 0, sizeof(slice_param- > >delta_luma_weight_l0)); > memset(slice_param->delta_luma_weight_l1, 0, sizeof(slice_param- > >delta_luma_weight_l1)); > @@ -353,21 +362,25 @@ static void fill_pred_weight_table(const HEVCContext *h, > > for (i = 0; i < 15 && i < sh->nb_refs[L0]; i++) { > slice_param->delta_luma_weight_l0[i] = sh->luma_weight_l0[i] - (1 << > sh->luma_log2_weight_denom); > - slice_param->luma_offset_l0[i] = sh->luma_offset_l0[i]; > slice_param->delta_chroma_weight_l0[i][0] = sh- > >chroma_weight_l0[i][0] - (1 << sh->chroma_log2_weight_denom); > slice_param->delta_chroma_weight_l0[i][1] = sh- > >chroma_weight_l0[i][1] - (1 << sh->chroma_log2_weight_denom); > - slice_param->ChromaOffsetL0[i][0] = sh->chroma_offset_l0[i][0]; > - slice_param->ChromaOffsetL0[i][1] = sh->chroma_offset_l0[i][1]; > + if (!is_rext) { > + slice_param->luma_offset_l0[i] = sh->luma_offset_l0[i]; > + slice_param->ChromaOffsetL0[i][0] = sh->chroma_offset_l0[i][0]; > + slice_param->ChromaOffsetL0[i][1] = sh->chroma_offset_l0[i][1]; > + } > } > > if (sh->slice_type == HEVC_SLICE_B) { > for (i = 0; i < 15 && i < sh->nb_refs[L1]; i++) { > slice_param->delta_luma_weight_l1[i] = sh->luma_weight_l1[i] - (1 > << sh->luma_log2_weight_denom); > - slice_param->luma_offset_l1[i] = sh->luma_offset_l1[i]; > slice_param->delta_chroma_weight_l1[i][0] = sh- > >chroma_weight_l1[i][0] - (1 << sh->chroma_log2_weight_denom); > slice_param->delta_chroma_weight_l1[i][1] = sh- > >chroma_weight_l1[i][1] - (1 << sh->chroma_log2_weight_denom); > - slice_param->ChromaOffsetL1[i][0] = sh->chroma_offset_l1[i][0]; > - slice_param->ChromaOffsetL1[i][1] = sh->chroma_offset_l1[i][1]; > + if (!is_rext) { > + slice_param->luma_offset_l1[i] = sh->luma_offset_l1[i]; > + slice_param->ChromaOffsetL1[i][0] = sh- > >chroma_offset_l1[i][0]; > + slice_param->ChromaOffsetL1[i][1] = sh- > >chroma_offset_l1[i][1]; > + } > } > } > } > @@ -462,7 +475,7 @@ static int vaapi_hevc_decode_slice(AVCodecContext *avctx, > last_slice_param->RefPicList[list_idx][i] = get_ref_pic_index(h, > rpl->ref[i]); > } > > - fill_pred_weight_table(h, sh, last_slice_param); > + fill_pred_weight_table(avctx, h, sh, last_slice_param); > > #if VA_CHECK_VERSION(1, 2, 0) > if (avctx->profile == FF_PROFILE_HEVC_REXT) { > @@ -471,15 +484,25 @@ static int vaapi_hevc_decode_slice(AVCodecContext > *avctx, > .cu_chroma_qp_offset_enabled_flag = sh- > >cu_chroma_qp_offset_enabled_flag, > }, > }; > + for (i = 0; i < 15 && i < sh->nb_refs[L0]; i++) { > + pic->last_slice_param.rext.luma_offset_l0[i] = sh- > >luma_offset_l0[i]; > + pic->last_slice_param.rext.ChromaOffsetL0[i][0] = sh- > >chroma_offset_l0[i][0]; > + pic->last_slice_param.rext.ChromaOffsetL0[i][1] = sh- > >chroma_offset_l0[i][1]; > + } > + > + for (i = 0; i < 15 && i < sh->nb_refs[L0]; i++) { > + pic->last_slice_param.rext.luma_offset_l0[i] = sh- > >luma_offset_l0[i]; > + pic->last_slice_param.rext.ChromaOffsetL0[i][0] = sh- > >chroma_offset_l0[i][0]; > + pic->last_slice_param.rext.ChromaOffsetL0[i][1] = sh- > >chroma_offset_l0[i][1]; > + } > > - memcpy(pic->last_slice_param.rext.luma_offset_l0, pic- > >last_slice_param.base.luma_offset_l0, > - sizeof(pic- > >last_slice_param.base.luma_offset_l0)); > - memcpy(pic->last_slice_param.rext.luma_offset_l1, pic- > >last_slice_param.base.luma_offset_l1, > - sizeof(pic- > >last_slice_param.base.luma_offset_l1)); > - memcpy(pic->last_slice_param.rext.ChromaOffsetL0, pic- > >last_slice_param.base.ChromaOffsetL0, > - sizeof(pic- > >last_slice_param.base.ChromaOffsetL0)); > - memcpy(pic->last_slice_param.rext.ChromaOffsetL1, pic- > >last_slice_param.base.ChromaOffsetL1, > - sizeof(pic- > >last_slice_param.base.ChromaOffsetL1)); > + if (sh->slice_type == HEVC_SLICE_B) { > + for (i = 0; i < 15 && i < sh->nb_refs[L1]; i++) { > + pic->last_slice_param.rext.luma_offset_l1[i] = sh- > >luma_offset_l1[i]; > + pic->last_slice_param.rext.ChromaOffsetL1[i][0] = sh- > >chroma_offset_l1[i][0]; > + pic->last_slice_param.rext.ChromaOffsetL1[i][1] = sh- > >chroma_offset_l1[i][1]; > + } > + } > } > #endif LGTM, will apply. -Haihao > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".