From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 81DA041A23 for ; Wed, 16 Feb 2022 19:57:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 238D668B249; Wed, 16 Feb 2022 21:57:13 +0200 (EET) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 387C568B1B5 for ; Wed, 16 Feb 2022 21:57:07 +0200 (EET) Received: by mail-oi1-f181.google.com with SMTP id q8so3611633oiw.7 for ; Wed, 16 Feb 2022 11:57:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:to:references:subject :content-language:from:in-reply-to:content-transfer-encoding; bh=JRAdpUlDYuVJC6owmSS0xl0l6OQQvp9YeJsDfDGwYyc=; b=DrN/NZgc1EEm3pWvSHtvL9UvxJaRFxgLxRhwwHuBKqGueTcWnGgz02IqX6gDT0AGyo YQs106UIcuFl3xpj3Lc60McQYuIWJ4mw+PMVKI08K4hnYAWU61nWyjyDXtenzephKewc 64TaeBk5XHNBHQ6iURoNfwMeafm0QJ/uO3Kmnh70as2ZmiidxLP8Rs9/ylxa+nvajlce g3zMoKvBV7iq/xUbAS+9hJxI9AsQ1QnsW5R8Ir35LxdizMQY+HgRmEFJaO1HNLJYxoGE RqlDzxb7k3bIVqTgQ4CYHhgjMkEoV/fYFzdjYIzER1YQZFosYDDhpYQkPbEgEgMqqWuQ iX7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:to :references:subject:content-language:from:in-reply-to :content-transfer-encoding; bh=JRAdpUlDYuVJC6owmSS0xl0l6OQQvp9YeJsDfDGwYyc=; b=bd/SE1HvtHdp63NNmuIk3Ue7nowRj1a+5m9DP3NB8Hl8kvPqKn5d9CWoulvszsr58B w+XlAFaeZfoLBlgF7jNGke9a3y5XMw2Zj/ji6dexTqW0hgyfFHCw5Ag5u1JBczsII2ji z7JU6tVK8dx7/zR3Ltb7ziS69VTqpkyR/oV+O05ogFoN7oS7BgZJA7sOBjscA7Fz78YO lU3NY14Jf/Kxfb3airBwTOybyoJeLrH4LxPxYM/fV7t7Znc/DdKHXEPWYlFZh9sy+hAU Vm375V1kpRtc1Hz1Ytgzjp1JFswp8uDYdUSu3z3Q67rKRnjOuJeONA0smEt58Ywmfpry cIPQ== X-Gm-Message-State: AOAM532w/fdRvEcEIu/AgtE19hUgMiEsfFb5nr2jwmCcndvklQw22+Pn HAIzH1EaoBK1C4rP3gc3BoPKsxa2w7bPVg== X-Google-Smtp-Source: ABdhPJzwkp261FUQkhGvIYRkLvOz6M+Bz9nQ/ZRzeIdm8hCPAWD9iM6oCHO8MGtYjckltaGyTK54tg== X-Received: by 2002:a05:6808:1514:b0:2cf:b4c7:19cc with SMTP id u20-20020a056808151400b002cfb4c719ccmr1456314oiw.213.1645041425170; Wed, 16 Feb 2022 11:57:05 -0800 (PST) Received: from [192.168.0.10] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id j8sm1042253otu.40.2022.02.16.11.57.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Feb 2022 11:57:04 -0800 (PST) Message-ID: Date: Wed, 16 Feb 2022 16:57:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 To: ffmpeg-devel@ffmpeg.org References: <20220216192156.13D9C410478@natalya.videolan.org> Content-Language: en-US From: James Almer In-Reply-To: <20220216192156.13D9C410478@natalya.videolan.org> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/af_speechnorm: speed up filtering code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > ffmpeg | branch: master | Paul B Mahol | Wed Feb 16 19:31:31 2022 +0100| [698de27f25bea278ce7155fc387b3d59b478d46b] | committer: Paul B Mahol > > avfilter/af_speechnorm: speed up filtering code > > Reduce some asserts by default. > >> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=698de27f25bea278ce7155fc387b3d59b478d46b > --- > > libavfilter/af_speechnorm.c | 133 ++++++++++++++++++++++++-------------------- > 1 file changed, 73 insertions(+), 60 deletions(-) > > diff --git a/libavfilter/af_speechnorm.c b/libavfilter/af_speechnorm.c > index 212a926f36..7fa87f814a 100644 > --- a/libavfilter/af_speechnorm.c > +++ b/libavfilter/af_speechnorm.c > @@ -128,7 +128,7 @@ static int get_pi_samples(PeriodItem *pi, int start, int end, int remain) > start = 0; > if (pi[start].type == 0) > break; > - av_assert0(pi[start].size > 0); > + av_assert1(pi[start].size > 0); > sum += pi[start].size; > } > > @@ -156,7 +156,7 @@ static void consume_pi(ChannelContext *cc, int nb_samples) > if (cc->pi_size >= nb_samples) { > cc->pi_size -= nb_samples; > } else { > - av_assert0(0); > + av_assert1(0); You removed an assert meant to always trigger if that path is chosen. This has nothing to do with speed. Same at the end of the commit. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".