From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/af_speechnorm: speed up filtering code
Date: Wed, 16 Feb 2022 16:57:02 -0300
Message-ID: <b841da02-7c44-9630-97f3-a500558c3048@gmail.com> (raw)
In-Reply-To: <20220216192156.13D9C410478@natalya.videolan.org>
> ffmpeg | branch: master | Paul B Mahol <onemda at gmail.com> | Wed Feb 16 19:31:31 2022 +0100| [698de27f25bea278ce7155fc387b3d59b478d46b] | committer: Paul B Mahol
>
> avfilter/af_speechnorm: speed up filtering code
>
> Reduce some asserts by default.
>
>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=698de27f25bea278ce7155fc387b3d59b478d46b
> ---
>
> libavfilter/af_speechnorm.c | 133 ++++++++++++++++++++++++--------------------
> 1 file changed, 73 insertions(+), 60 deletions(-)
>
> diff --git a/libavfilter/af_speechnorm.c b/libavfilter/af_speechnorm.c
> index 212a926f36..7fa87f814a 100644
> --- a/libavfilter/af_speechnorm.c
> +++ b/libavfilter/af_speechnorm.c
> @@ -128,7 +128,7 @@ static int get_pi_samples(PeriodItem *pi, int start, int end, int remain)
> start = 0;
> if (pi[start].type == 0)
> break;
> - av_assert0(pi[start].size > 0);
> + av_assert1(pi[start].size > 0);
> sum += pi[start].size;
> }
>
> @@ -156,7 +156,7 @@ static void consume_pi(ChannelContext *cc, int nb_samples)
> if (cc->pi_size >= nb_samples) {
> cc->pi_size -= nb_samples;
> } else {
> - av_assert0(0);
> + av_assert1(0);
You removed an assert meant to always trigger if that path is chosen.
This has nothing to do with speed.
Same at the end of the commit.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
parent reply other threads:[~2022-02-16 19:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220216192156.13D9C410478@natalya.videolan.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b841da02-7c44-9630-97f3-a500558c3048@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git