From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libvpxdec: remove unnecessary init_static_data function
Date: Tue, 28 Feb 2023 17:49:25 -0300
Message-ID: <b7f1474f-f360-772b-3915-7c55fcd4c592@gmail.com> (raw)
In-Reply-To: <CABWgkX+A4LxfoTfJ7JEs6v823R9HWdJtjSK0Esus=w2Y5m67EA@mail.gmail.com>
On 2/28/2023 5:40 PM, James Zern wrote:
> On Tue, Feb 28, 2023 at 4:07 AM James Almer <jamrial@gmail.com> wrote:
>>
>> It's used only by the encoder.
>>
>
> It sets AVCodec.pix_fmts, but maybe the values reported aren't used
> meaningfully.
Indeed, they aren't. AVCodec.pix_fmts is a list of formats an encoder
accepts as input. Decoders don't use that array.
>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>> libavcodec/libvpxdec.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
>> index 0ae19c3f72..8e6291fe20 100644
>> --- a/libavcodec/libvpxdec.c
>> +++ b/libavcodec/libvpxdec.c
>> @@ -391,6 +391,5 @@ FFCodec ff_libvpx_vp9_decoder = {
>> FF_CODEC_DECODE_CB(vpx_decode),
>> .caps_internal = FF_CODEC_CAP_NOT_INIT_THREADSAFE |
>> FF_CODEC_CAP_AUTO_THREADS,
>> - .init_static_data = ff_vp9_init_static,
>> };
>> #endif /* CONFIG_LIBVPX_VP9_DECODER */
>> --
>> 2.39.2
>>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-28 20:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 12:06 James Almer
2023-02-28 12:06 ` [FFmpeg-devel] [PATCH 2/2] libavcodec/libvpxenc: move libvpx-vp9 init_static_data function to the only place it's used James Almer
2023-02-28 20:40 ` [FFmpeg-devel] [PATCH 1/2] avcodec/libvpxdec: remove unnecessary init_static_data function James Zern
2023-02-28 20:49 ` James Almer [this message]
2023-02-28 21:20 ` James Zern
2023-03-02 20:53 ` James Zern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7f1474f-f360-772b-3915-7c55fcd4c592@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git