Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc2enc: Use LUT to assemble interleaved golomb, code

From: Lynne <dev@lynne.ee>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc2enc: Use LUT to assemble interleaved golomb, code
Date: Wed, 12 Mar 2025 05:50:58 +0100
Message-ID: <b7631f2c-f898-4476-8c8d-d822ce4f6d58@lynne.ee> (raw)
In-Reply-To: <GV1P250MB0737DF2E0F59612C1DEA44958FD02@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

[-- Attachment #1.1.1.1: Type: text/plain, Size: 742 bytes --]

On 12/03/2025 04:10, Andreas Rheinhardt wrote:
> Patches attached.
> 
> - Andreas

First patch is wild, its surprising no one considered inverting the way 
decoder parses codes for an encoder yet.
Rather than ORing and using put_bits63, I think it would make more sense 
to write out each chunk using put_bits sequentially. It might be 
possible to reverse the lookups such that you get the MSBs first so you 
wouldn't need to reverse them out of place in a small array.
But either way, LGTM. Feel free to explore this in a follow-up.

Second patch seems a bit pointless. It's just one single call you're 
uninlining? Chasing to save a few extra bytes of binary surely don't 
deserve having a wrapper function for uninlining.

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".