From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: fix timecode with high frame rate content
Date: Wed, 20 Apr 2022 19:59:18 +0200 (CEST)
Message-ID: <b7596963-bce8-c5d6-eb3a-d060d2344020@passwd.hu> (raw)
In-Reply-To: <3886ac2-c9e4-b866-c94e-789977dfbc2@passwd.hu>
On Mon, 11 Apr 2022, Marton Balint wrote:
>
>
> On Mon, 11 Apr 2022, Anton Khirnov wrote:
>
>> Quoting Marton Balint (2022-04-10 20:11:59)
>>> 60 fps content have "Number of Frames" set to 30 in the tmcd atom, but
>>> the
>>> frame duration / timescale reflects the original video frame rate.
>>>
>>> Therefore we multiply the frame count with the quotient of the rounded
>>> timecode
>>> frame rate and the "Number of Frames" per second to get a frame count in
>>> the original
>>> (higher) frame rate.
>>>
>>> Note that the frames part in the timecode will be in high frame rate
>>> which will
>>> make the timecode different to e.g. MediaInfo which seems to show the 30
>>> fps
>>> timecode even for 120 fps content.
>>>
>>> Regression since 428b4aacb1a91a267650de644519882a5f700388.
>>>
>>> Fixes ticket #9710.
>>> Fixes ticket #9492.
>>
>> Sounds like there should be a test for this.
>
> The smallest file I managed to find which is affected by this is
> mov/canon_6d/mvi_9114.mov, but that is still 12 MB, therefore probably not
> fit for addition to fate-samples.
>
> With our muxer, the issue is not reproducible, so remuxing is not an
> option.
Will apply soon.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-04-20 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 18:11 Marton Balint
2022-04-10 18:12 ` [FFmpeg-devel] [PATCH 2/2] avutil/timecode: use timecode fps for number of frame digits Marton Balint
2022-04-11 7:54 ` [FFmpeg-devel] [PATCH 1/2] avformat/mov: fix timecode with high frame rate content Anton Khirnov
2022-04-11 20:57 ` Marton Balint
2022-04-20 17:59 ` Marton Balint [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7596963-bce8-c5d6-eb3a-d060d2344020@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git