From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 0D4FC4B574
for <ffmpegdev@gitmailbox.com>; Mon, 31 Mar 2025 13:03:00 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BB48D687CBE;
Mon, 31 Mar 2025 16:02:55 +0300 (EEST)
Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com
[209.85.208.181])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5316D687AF3
for <ffmpeg-devel@ffmpeg.org>; Mon, 31 Mar 2025 16:02:49 +0300 (EEST)
Received: by mail-lj1-f181.google.com with SMTP id
38308e7fff4ca-307bc125e2eso39636771fa.3
for <ffmpeg-devel@ffmpeg.org>; Mon, 31 Mar 2025 06:02:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=martin-st.20230601.gappssmtp.com; s=20230601; t=1743426168; x=1744030968;
darn=ffmpeg.org;
h=mime-version:references:message-id:in-reply-to:subject:cc:to:from
:date:from:to:cc:subject:date:message-id:reply-to;
bh=LsCnRkn0Q569dOdmY3yYmGbLgTi7+tqK7PpBTWX59ZU=;
b=m4myhuN+ggCuk2QFOnWG93H35u7AwovclU2g63L2LvspouN1mHyWuhbRYjbadZY5ve
q8gBuMPV0AgCrQZmYhiORiLCdFG4bdpEDJgX7cVukggqooQF1BM+aVeQZ27IiRIcYYNq
uVkg5dwnzUoUHIMlE7HtAjdssue+w8dMYgy7w+LGcT+9c+FKFf27iij7h7pHJUwFuyiL
G/i4Bce5XnwGB+3g/doa2P1SAobepxRlReEf63/V1e8m7rzYPzgBF+aTm0tmO8ewijeP
tJrhSYUVeFKrELPwve0l/PeD/udIvHvuJWTtqDTpAiOBC0WJUnFBMm3zvwDqv71bpWCe
X4oA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743426168; x=1744030968;
h=mime-version:references:message-id:in-reply-to:subject:cc:to:from
:date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=LsCnRkn0Q569dOdmY3yYmGbLgTi7+tqK7PpBTWX59ZU=;
b=AzdnC3+FkXOCiQy9hlIeEowlw0wsELlyxpstk3Y0GCs7kbJFXWEAXTxuEB4scGdZwu
8FlplJmhZIzY3xTsgE9YrgIlM4h4nY0IJXXA3rgLSPlLOBKBa0xu936aeC7vL1qqKefN
XdC5o04DEgdy+9RPMXkSvocLtd5W12B0UxjZxpm9IwdFP/jUv2tFNigbNRiBbCvz9fmK
UVlSDL8u3rfZ2LNtFyXCUgYE6BHYpSR6KdhDnFEpGt9YlS4J/z8h7rJ8+ch4soR0cvDH
wLUrRM7CrxDDXQG5rR0UDNfm1XjKh0LysDW/TA6OrECdrtLkt6Rr2vG+C935Xzqj49MS
YpfQ==
X-Gm-Message-State: AOJu0YxoAvKGqFwqg0IEMU9CL6lm/6FxQoaeECJscQWYiXgyrM4mIFeR
1V+5bRHKBvly3/SxNj2BR5+etSqaUsxlUgIrgMqJeud7VIITcsV+aGF5lZEliI9cAc4hk9NBXOi
/4w==
X-Gm-Gg: ASbGnctebBPkqZ5xS1n3XTjUMCZbw7juWHiGYknVXM7hX2Ar5wne9fGVjXLPWeLaf51
x9r5tDtJFg3SJWWasiDLtSmZz23NpaqUjs3KsB4gddRN7bTNwP31uaVHM0v18RWGffYxw9jQDKc
Z0pqEy8lp78GHEAOQNznR0buEUS+Aa4kry0v7a5+xBYULXnJ+u8M4P/0By/UyX0hiM8WrE9hAL6
tcI8LmiAYiUivZ5NnaNgPBaoDdSmrpEA6i5Ziwauin2wigrPl8K8A6XuX0HRK6/D/ax3vMJwVIe
bRfzxmj63c29i7FsMxdx5AqOE8y/p2ZhGK/VGvTR/bsjpAE2UsMwRWEa751WJBfM0rQWLa2rxbk
5PpvzVxE+7E/yDkY9X/ICGiyFrMSTZd3kARn37b1K
X-Google-Smtp-Source: AGHT+IF/A2vfu/hmFImTeUj8Ol1E+8L64ZORHhyVN+9NBeV5p/Y4ka9xvpRjajimLZXSSEbvcy7sVQ==
X-Received: by 2002:a05:651c:1602:b0:30b:b956:53e5 with SMTP id
38308e7fff4ca-30de02493a7mr31596451fa.12.1743426168085;
Mon, 31 Mar 2025 06:02:48 -0700 (PDT)
Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net
(tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2])
by smtp.gmail.com with ESMTPSA id
38308e7fff4ca-30dd35925d7sm13651251fa.91.2025.03.31.06.02.47
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 31 Mar 2025 06:02:47 -0700 (PDT)
Date: Mon, 31 Mar 2025 16:02:46 +0300 (EEST)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <20250331125254.128485-1-ffmpeg@haasn.xyz>
Message-ID: <b750dd8e-b3d0-8267-9df-895a887da5db@martin.st>
References: <20250331125254.128485-1-ffmpeg@haasn.xyz>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] tests/checkasm: fix wrong summation of
bench time
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Niklas Haas <git@haasn.dev>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/b750dd8e-b3d0-8267-9df-895a887da5db@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On Mon, 31 Mar 2025, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
>
> This was changed 8 years ago with the introduction of the linux-perf path,
> with seemingly no justification at the time. Likely a developer oversight
> from testing.
>
> This bug not only made --runs completely ineffective, but also meant that we
> didn't actually correctly filter out outliers.
>
> Fixes: e0d56f097f42bcdbe6c3b2f57df62a4da63f2094
> ---
> tests/checkasm/checkasm.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h
> index ede45bcc2a..922e134bfd 100644
> --- a/tests/checkasm/checkasm.h
> +++ b/tests/checkasm/checkasm.h
> @@ -365,8 +365,8 @@ typedef struct CheckasmPerf {
> }\
> }\
> emms_c();\
> - perf->cycles += t;\
> - perf->iterations++;\
> + perf->cycles += tsum;\
> + perf->iterations += tcount;\
> checkasm_set_signal_handler_state(0);\
> }\
> } while (0)
> --
> 2.48.1
LGTM, thanks for catching this!
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".