From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EC7CC40899 for ; Fri, 24 Dec 2021 02:44:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 74ACF68B1E0; Fri, 24 Dec 2021 04:44:22 +0200 (EET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CF9A968A8A5 for ; Fri, 24 Dec 2021 04:44:14 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640313860; x=1671849860; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=2WAuhhI5PK+v3RpItV+zcKnkIoirbKueEnqTHYgepo8=; b=iZa00eajAZoALOkrg3icEMNRbjoC/m8zh3HwlbKr2EeXs4w2G4FgDd0m gLVLsNxwrNciNUcuVXyZKOFSlxAF4OLIGgZUBClV8dM5kuk0PLebgM+hk Cp/rBdsUdUTEgcEYlqhUJD/YWG81sSj6Oqs/y+1SyL1xNLk6mouwzAdZo YvCPAT/4arePpJ0+uB7qNxN8kM/xBMTa4QtdkWUNVvWvCxUHY6TkQiIAH UNpm9WizGZTMaN2nj5VJ4l5KB2lhuelSToPMXL7/jFD6iSt3KuHXgrJ9P l+Oiynv+QOUhmXrp7GkVyAaulWY50J5Od5uveJf0FijR6fCZORmFYgThF A==; X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="227760717" X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; d="scan'208";a="227760717" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Dec 2021 18:44:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; d="scan'208";a="571136560" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 23 Dec 2021 18:44:11 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 23 Dec 2021 18:44:11 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 23 Dec 2021 18:44:10 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 23 Dec 2021 18:44:10 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 23 Dec 2021 18:44:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XeH5q0QK7GV3KeEw6F8siW0m9YD9RWrX+6eZtTJtPnS6OCRgZI2srOUdmM3ydYmiRf/qmP9MSGVDwmsltDEcqo6N0Mqloz7fnmwFq/SHJ/tS+nhP8EV1KeFcG8+lmYu7vwzLIznNTtaLJINoUg0/GTPWAOIfop5HluHUNqOt6wkuRkdKin57i+tOS4vjMRGXL7qMfO19NjRPa0LnLG23dosXskhiiI3JyOLyp7DofqkhBWZdpYxGDTheon+GrQX771HBXrIuU+ardbNprOxlBQI+O+6YQet6P4FYZEolUZ66QOiZ5+T6AqpBvlXAFbqnBs+mfjfkrZ8gmytObH6iYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2WAuhhI5PK+v3RpItV+zcKnkIoirbKueEnqTHYgepo8=; b=Y8BD9qUkK5IHQiNIpNZDKZPdxmKjpzUVsu36zcekIAG0hLjky2SBqnMvhjrdCud3rd8XI+RwSrz8v4TPN68t4TTR3nSYDDqRpybPcyKGSobiOCrM6iicuz7ETgGgNuPVr3dGeLluwnqkpvoOUTu3GJ2LuRUqBTJ2NSXZRwsxILJGJLX1GvqUaasDAUrS2w/9zVGL/M2JGadxyfHEc1JbBt3vWu9/pwn4KV8Xg8kQqsY5KziquPMr923+aEwiJNk/lOuOX5k/LGUPxpujth10ZJXkD6FcdltufS3VbG5MEO4oeZSpkynWnTNwXvwvMSgyi2GrGXD2gymWXCxkSJ+BFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN9PR11MB5308.namprd11.prod.outlook.com (2603:10b6:408:119::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Fri, 24 Dec 2021 02:44:04 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16%3]) with mapi id 15.20.4801.023; Fri, 24 Dec 2021 02:44:04 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" , "andreas.rheinhardt@outlook.com" Thread-Topic: [FFmpeg-devel] [PATCH 08/11] avcodec/tests/avcodec: Check codec caps for consistency Thread-Index: AQHXsWKqYCSqRgfOLUGG2ozi7GqhY6xBdOgAgAAB8gCAAAaWAA== Date: Fri, 24 Dec 2021 02:44:03 +0000 Message-ID: References: <420d12e0288d42515f1f8dae75c2a70e561084da.camel@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 95939b61-2e72-46d6-6b17-08d9c6873faa x-ms-traffictypediagnostic: BN9PR11MB5308:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tOtuk8tnF7jPjd31mux/ZDmnQ5KleuA/zbbYKGjJVc6ce3sJTlsODt7TutnQNpzzub15QoxXUGjq3V2LMSg8fqT0FFz6uk/nj2oC2MG/hKTFOsA8SE0ktuwkncKKl9sEbeZ4HnSOhzSID9UOTaozDkLzccbW72s6go+TeSAxmGVjftakv3XqHChDbiarfRBGZyjUtPmME7Ci2NwQ+nJxCUTFowGcVH3/2J2EyJ3nnccimFEKvppfZoQ4kQPPtQ9fc3r5l3GzSqgWYTxFm815ZaFVPCUITzT1Ge0llSn9ok3umBo9AkILvKB7mC6/4gZS4DLFWn5/Ps+VdJJ3+fP8HXxsqdOkmZ1FenvKI/mqW1TvrWiVhIhioY3K6hKOZF90/9t1FeitjHRgt0APGvCH/YqqJZUZaQdNy9q/LTEzv024pqXooIM9ji96eCkmT4mGIXrX5LrYE9Lt/inQHYaxtUrzCBwV+YPmWw7KKlIABxhcOE8WJrMO29H9tSNPfyoHCORpUfze2z3tG2apOD385Ma5/ead4aJ1C3Ke6j691/7AQgxHGiKrxe31BiwpmRs/iL7xrwOlvUupd2rCOmhpvMy0/afGXAmyio1gC+mypp4oFb4Y0Cg+4+UbzSRSEGWw7F7MpoMtWR109gtiZ6n0mcSbpP0BSGPxxHnyNlQdS3iKBGOethl0CmWhChzM/murJNdH6rwBkLJow0F0kg73hlPBMRsJIgbQrlAwY92vRLthYtoKd0yRs2ZF40LioA8OtKjHMIQf6+ka4vaCST1Nap2j+/d3Ix8SsLDWW6cEvK1xZElT9/rkQASN7yyWKFC1km37vf/I3uwsugCWtmPCw1ram3AHKlKFhX3AajE4SDQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(110136005)(71200400001)(966005)(38100700002)(6486002)(8676002)(82960400001)(86362001)(5660300002)(6506007)(38070700005)(6512007)(83380400001)(8936002)(122000001)(2906002)(4001150100001)(66446008)(64756008)(66476007)(66556008)(2616005)(36756003)(66946007)(508600001)(91956017)(316002)(76116006)(26005)(186003)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QTMyOEEvZWxKT3hSTVFqSW9GbExBMnZjNFExUkY1RVp5dHpLZXpMY0N2Qlh3?= =?utf-8?B?N2JqSVJMVWRVcm81ZEY1MC9OT055dHBZYWkzRDU0VHZmQ2pZaWJQc3hOWCs4?= =?utf-8?B?cWMrTk9Fb2o1a3B0ZzFIc2RmUEErS2hyOEUrbmo2bVlsei9JS3VYUHZkSG40?= =?utf-8?B?MzlpVlZVVUhsZXVIa3ZmSittYzRhaFFGZnkvOGxhaDNobEh1MjdYUmRiUThX?= =?utf-8?B?TnpaUXBraVRLeDJRb1pVUXY1dTU0Mjk1bW9tTGowcFpkcE84U2tNc0VrdTdE?= =?utf-8?B?TkcrbWhTaDZ6SnovNVlqTzNsc0MyRVUzY3kzYWJkU3pyYUUweklrUlBiYzl3?= =?utf-8?B?YVRCaXFVMW9RQnk3K25BV0pHcEhZeG5OQUFhNXpEOFZ3NWdYdnN4RE54MFJ5?= =?utf-8?B?T1UyMXdyYW1jVGxLemN0cW83TFI0RnE3cFJ2Q2pmZm1jdGErbzMrOHhmYndi?= =?utf-8?B?ZExVbzFTNDcyVkxDK2RzNHpRSTJneDJUUDhhOUI3eHRxUXBwQTFJMEZYWXVO?= =?utf-8?B?aktPMlZvME5weWFwcTcvU013WWFaM2N4UVNLU1hydG1JNWRVUEFWQW11VWR1?= =?utf-8?B?cU5XWnZVUmE5dFNFQjE5OU1FK1B6MktQYW9Rck1SSXc4b2kralduOTBaUFFI?= =?utf-8?B?OFE4TERzaVMxVm5NenYxOGxQR2RraHVOcWJGK1FxTmJqZFB5Skw0YmpTYVY4?= =?utf-8?B?SUhoTUdqSmRNTzBjc1R1NDNkM3RFTUJzN2pDdS9TRUJ4VFgxZG40RVhiMHJP?= =?utf-8?B?UWl5RGY3a2N6MDEwN0ZMTW5LbnVpc0o1QXZTR2VqTmlwazYxNDJISGZmVWcy?= =?utf-8?B?c05HSEsyYXdZaVl1NkRvUjlDRFB1bjJNekpzaFMvd1JtdDdxWE5ma211Tmoy?= =?utf-8?B?V2ZmbW9jL1dvdk1Lcm1RcUxzdXdwSTQwUmhINy8xRGl4ZEJkRDJIblhmelF0?= =?utf-8?B?bjBlNFk1Yk9abTVWcURLdmVnNXFBWkxTbGtyY2wyUTFraitJdWVTUUg4aHAy?= =?utf-8?B?ZnlKUEV1TjVZV25zRlpIT3BtTGR5dXpkV3ZqNXJzZG1OQnFjaE1WYUNQbEs2?= =?utf-8?B?eUJTMlhBdEZacXJhcmZxQ2JiL2tXWHNZSUVyRlE5dEc4TG94MzYzaUQyMldj?= =?utf-8?B?UGhTVGFxZDFxSkRrTzJ1cDBkQ1loYmZMWi9lcWNnVGRxTmFDNXBlRXdJMFE4?= =?utf-8?B?blNkaXR3b1ZFcmc4WVN6YjdFMFdTNnljQTk5QkwrN2dod2QyVVhkM0dacDVm?= =?utf-8?B?Nko3aDd5Vlo3dWpmQk1Wd1JlVzFPSmNoeVlFVnNvT29xamxIaUg3SWpiWUtM?= =?utf-8?B?by91S3NacEViMTdCbzJ0dVZDSytab1lESWZlQ0hLRktMd2MwcVJGRTdTMnVF?= =?utf-8?B?SXV0eitKMWJkU0F6N1IrR2VpRlQxSldmeGZWbWtxOWxpMzFCbE5PRC9HY0ox?= =?utf-8?B?OTVoRHFoUVo4K1pnZnRmNUNMSEpJajVaY1dlQXZKQXVpak9CRU53UmNwVWE3?= =?utf-8?B?U3g3aFEyS0NKRWk0dnR3WFBEQkNpbFVlRUZnZjVZRGh4UHpTTk9uT2g5Z0xa?= =?utf-8?B?QUlmdmRJQ09DY0MzanZNY01aNndJVWE0cW1VMnJ6aWRMU0JxaERWS0M5OFpH?= =?utf-8?B?a01oVmZvMGRwQVZwK2lXVDdSSDJBc3BxeWNvY1ZCT2U2TWk4bGJwTXgwbnVU?= =?utf-8?B?NDlWZG5XY1hxSVpvakRVc0Q0SkN6VFlCWkNvN0puVnJHTFRDZTQ3NDdFTlFQ?= =?utf-8?B?NXVPMFN5VW9MSGRZSWdOQll4cDRIbTkxWTZISGk0cThjZ3YxVkZ4SnRUMW96?= =?utf-8?B?bnZpTG9qV01ibnVjSUhsRlova1ZVY2laQVBvRmdJcjM2QXg1Ry9FZHBYM0g2?= =?utf-8?B?NlFrU2dIU2t0Q0lqdEVrbm5xVXpvc3k4ejVpbm1qTzhRcldqZFYxdlhFL0ZO?= =?utf-8?B?eTJXZmYyNFI4QmZ2OHhOYkJ4MDBlTUZHNmNjc05DV1MzZXlCcDRadW03ako5?= =?utf-8?B?OWU3bUZlMmh3bkxJNzNjU1FXS0FSakI5emZoUUF5c3BoWmxpbEJSU1FnNnlz?= =?utf-8?B?bzdMUWFDK1dEbFBlcGpxK3RScFpTNEJJc2l0WWZrWXRCRzBUMUZWbm5sMlJ1?= =?utf-8?B?M3o0N1lBajVWbDIza01tdzdNSDk4dC92RVRLSHZTZWMxSmRQc1Bmbk9NZGRW?= =?utf-8?Q?7225SewZuWe4/sqIahY11gQ=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95939b61-2e72-46d6-6b17-08d9c6873faa X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 02:44:03.9716 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: exx209yMVhBr8xIK3uxNPGOTaOD1Mv+eFK+uFPJx0aOFqQHW3boJwoKbAHIvdTs2R68aSUhL1GxwcjGxhJTNcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5308 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 08/11] avcodec/tests/avcodec: Check codec caps for consistency X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2021-12-24 at 03:20 +0100, Andreas Rheinhardt wrote: > Xiang, Haihao: > > On Fri, 2021-09-24 at 18:37 +0200, Andreas Rheinhardt wrote: > > > Signed-off-by: Andreas Rheinhardt > > > --- > > > libavcodec/tests/avcodec.c | 38 ++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 38 insertions(+) > > > > > > diff --git a/libavcodec/tests/avcodec.c b/libavcodec/tests/avcodec.c > > > index 5512ae99f7..e26315c368 100644 > > > --- a/libavcodec/tests/avcodec.c > > > +++ b/libavcodec/tests/avcodec.c > > > @@ -19,6 +19,7 @@ > > > #include "libavutil/opt.h" > > > #include "libavcodec/codec.h" > > > #include "libavcodec/codec_desc.h" > > > +#include "libavcodec/internal.h" > > > > > > static const char *get_type_string(enum AVMediaType type) > > > { > > > @@ -78,11 +79,26 @@ int main(void){ > > > if (codec->channel_layouts || codec->sample_fmts || > > > codec->supported_samplerates) > > > ERR("Non-audio codec %s has audio-only fields set\n"); > > > + if (codec->capabilities & (AV_CODEC_CAP_SMALL_LAST_FRAME | > > > + AV_CODEC_CAP_CHANNEL_CONF | > > > + AV_CODEC_CAP_VARIABLE_FRAME_SIZE)) > > > + ERR("Non-audio codec %s has audio-only capabilities > > > set\n"); > > > } > > > if (codec->type != AVMEDIA_TYPE_VIDEO) { > > > if (codec->pix_fmts || codec->supported_framerates) > > > ERR("Non-video codec %s has audio-only fields set\n"); > > > + if (codec->caps_internal & FF_CODEC_CAP_EXPORTS_CROPPING) > > > + ERR("Non-video codec %s exports cropping\n"); > > > } > > > + if (codec->caps_internal & FF_CODEC_CAP_SLICE_THREAD_HAS_MF && > > > + !(codec->capabilities & AV_CODEC_CAP_SLICE_THREADS)) > > > + ERR("Codec %s wants mainfunction despite not being " > > > + "slice-threading capable"); > > > + if (codec->caps_internal & FF_CODEC_CAP_AUTO_THREADS && > > > + !(codec->capabilities & (AV_CODEC_CAP_FRAME_THREADS | > > > + AV_CODEC_CAP_SLICE_THREADS | > > > + AV_CODEC_CAP_OTHER_THREADS))) > > > + ERR("Codec %s has private-only threading support\n"); > > > > > > is_decoder = av_codec_is_decoder(codec); > > > is_encoder = av_codec_is_encoder(codec); > > > @@ -103,6 +119,19 @@ int main(void){ > > > ret = 1; > > > } > > > } > > > + if (codec->caps_internal & (FF_CODEC_CAP_ALLOCATE_PROGRESS | > > > + FF_CODEC_CAP_SETS_PKT_DTS | > > > + FF_CODEC_CAP_SKIP_FRAME_FILL_PARA > > > M | > > > + FF_CODEC_CAP_EXPORTS_CROPPING | > > > + FF_CODEC_CAP_SETS_FRAME_PROPS) || > > > + codec->capabilities & (AV_CODEC_CAP_AVOID_PROBING | > > > + AV_CODEC_CAP_CHANNEL_CONF | > > > + AV_CODEC_CAP_DRAW_HORIZ_BAND | > > > + AV_CODEC_CAP_SUBFRAMES)) > > > + ERR("Encoder %s has decoder-only capabilities set\n"); > > > + if (codec->capabilities & AV_CODEC_CAP_FRAME_THREADS && > > > + codec->capabilities & AV_CODEC_CAP_ENCODER_FLUSH) > > > + ERR("Frame-threaded encoder %s claims to support > > > flushing\n"); > > > > I didn't see such requirement in codec.h and wonder why the two flags can't > > coexist, could you please provide a little more explanation ? > > > > The only reason for this is that it is not implemented to flush an > encoder that uses frame threads. > (Do you have any specific encoder in mind?) Thanks for the answer. ( There is a patch ( https://patchwork.ffmpeg.org/project/ffmpeg/patch/1564549538-25724-1-git-send-email-linjie.fu@intel.com/ ) to support variable resolution encode, and the revised version ( https://github.com/intel-media-ci/cartwheel-ffmpeg/blob/master/patches/0011-fftools-ffmpeg-support-variable-resolution-encode.patch , which is not sent to ML yet) added AV_CODEC_CAP_ENCODER_FLUSH to ff_rawvideo_encoder, and recently AV_CODEC_CAP_FRAME_THREADS was added to ff_rawvideo_encoder in FFmpeg, so this error was triggered in testing) BRs Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".