On 8/3/2025 3:26 PM, Michael Niedermayer wrote:
> On Sun, Aug 03, 2025 at 01:45:17PM +0200, Timo Rothenpieler wrote:
>> On 8/3/2025 9:41 AM, Michael Niedermayer wrote:
>>> Hi
>>>
>>> can we have a tag that causes "automerge on approve" ?
>>>
>>> so that if i open a pr i can set that tag and if someone approves it, its
>>> merged and i dont have to come back and click that button ?
>>
>> That is how it should already work normally.
>> If there is no approval, the merge button turns into a "Auto-Merge when
>> checks succeed", and "at least one approval" is said check.
>>
>> Not sure if being an admin lets you bypass that, but at least I also see the
>> "Rebase then fw (When checks succeed)" button.
> 
> ok lets see if that works
> I saw one button and i clicked it on
> "https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20093"
> 
> lets see if it waits for an approval :)
> 
> btw how exactly does that work when a pull request crosses the area
> of knowledge of 5 people ?
You probably shouldn't mark such PRs for auto-merge on approval.
I'd only use it on more or less obvious/trivial things.