From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 349664526E for ; Mon, 16 Jan 2023 04:19:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A29C968BD45; Mon, 16 Jan 2023 06:19:26 +0200 (EET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3C68568BD0A for ; Mon, 16 Jan 2023 06:19:20 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673842765; x=1705378765; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=6bSettL/FKIhWVf8r9fg7WS+Z+txsnMtxQ4fCN3poTc=; b=ju2Nl7wZJQ2h17r+x/21sFsPjYbD/eu1STgHZEs88ehvvC3mRORtUUwn 83FlfKxHisWP5uU8xfgGpUKGhhw8h3OFWpccgN8iNVjuPTCh++Ibmaq+s DGrHR1BAX54K0bqK3Wv475XE2Rsg35d3bJR/dIr+UmwL/3+bPesapGUX0 xFJAqtlzbEaVVYiFB8e6jPQEAbo9IOh0WsPToV+FfSUTtqfcIbE7petO4 SArnuycf3owIJmrriICam5p/Na6PFRUFUYHgxYDraxbv69P/R5pApjtbH EkwTzr6QM18kEicP4vZpLjyq0UiRHArX+zxQAxro7BffybAbU3vZ1XynR A==; X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="388875164" X-IronPort-AV: E=Sophos;i="5.97,219,1669104000"; d="scan'208";a="388875164" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2023 20:19:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="660847777" X-IronPort-AV: E=Sophos;i="5.97,219,1669104000"; d="scan'208";a="660847777" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 15 Jan 2023 20:19:17 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 15 Jan 2023 20:19:17 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 15 Jan 2023 20:19:16 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 15 Jan 2023 20:19:16 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 15 Jan 2023 20:19:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HLglluXS+BwkSS/XxyFxFPT7z2kQYzXAO9Y2mCsuMmaYjnAXz/v9O3dc1BYYwTTl6taMets2TRSVb5iHaPd1jNMRjz7pzOyUKoRybxN11p+i2nQBgU8ivuJojINLZMJE3lsHu4ccjmFZ55nOIsPPew3k8jMxjZdoAAqiDIP9KYUF5yZJAAZ61tiYN/I0wtWJBnltmL/tlTJ6unvfu4Bn3Xovt6EnYJcZZhlJBtaSoWizr+TNeoAOMk7/t8SFCerohMVcBbFzbDkSs+p0DBS3j2gFRlRAo2l6lL5IdB16HMqN6DFQ6SJmbikh+l1mR+TBBaL5SE5O0VOeOcXrfeZhvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6bSettL/FKIhWVf8r9fg7WS+Z+txsnMtxQ4fCN3poTc=; b=QOpCpRch1DpX0ikDA/+oBCQFP0OEJ8VT1hTsDgUP5GjkTbNb5CvUleF/Wgcx6kESFjxSU4mvdJJQJc63nBbSq8YSgiVxWbITqzBomnJG10cd07tJO30YqihU8xcV1AjD1lzk6K/GCDRW9i1W7zKtWqhk5VVRdpx+sS22G90kV2e1LUx4PResyArUmQueE1c47fjKoIZbh17g5FDF1/7/fESWXxdgm6+yH0IIIo384ubLmFXbpRorvGd/xZ7dzk0al+IoOPWMkhELN0TgaHdrD8Wg/0uSpBMG/bbUBw+vzJ/VLIqE5zVWXROLkByHGcfWQX9Kyf5NWIwWPurwHG2H0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DS0PR11MB6518.namprd11.prod.outlook.com (2603:10b6:8:d2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Mon, 16 Jan 2023 04:19:15 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9%5]) with mapi id 15.20.5986.023; Mon, 16 Jan 2023 04:19:14 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames Thread-Index: AQHZJM0L6r51ATg7w06YMqvhby9sOq6gecIA Date: Mon, 16 Jan 2023 04:19:13 +0000 Message-ID: References: <20230110081723.83586-1-nowrep@gmail.com> In-Reply-To: <20230110081723.83586-1-nowrep@gmail.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|DS0PR11MB6518:EE_ x-ms-office365-filtering-correlation-id: 0978a318-7543-4ff6-9453-08daf778d365 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qmD1IoAiJ2ligb4cish47ZsV49O8ZOhMPmrn/OXtWK80tA0qykiqMmV0PyvxDOrpaRjn9gd+e7jL57dms93okAuY9C4SKkhn0CIZw7HWIWY41Gaz0DMJfkIWmd/a3jbgf8U45uT4as9TR/QWCENvNPLneCJZyUTpSemtal6XIkuihtAniMoBKzZyz+m3shEviw2vghxoy0VVxQ1cY6YBJdDhKKMGr2fLu+POgCxKjb9C8vfvJezYGTpGM2pPiSIfJVX8LZ3e+lhN0VnEriOJJLUzI68EaMCZ/0g1RtnITAhSOlBOelt19mqKIVIoUHdjIEXvEY/TDu8zZbmwzrSMWPEUSOLPNhcUlntM/RTloF0glQ4ne6bULv7kUjvn3jtR6p6rjNB37UdxFB3xgaPUzSbcR/NWqr0g009o2uUfF7Y7IWs00ZWR50vG+2dvAIphoFGKZ+JaqtE3oW2SHvo11TMKJEFCdS2Dr65Q/7uZIsaX6w1aw1OUgG7SqJJJ4+DktD44ea9VfGzbGafVaqlbhChJ/+UDpVwkPznoY6AXxi9rEhbrdWf4gwDpeDMAQM7ccmY85GSUIm3ib11PtF7EHrbfMH+CyWmhVIkt6RIs8L8dcK8NMzlN7yd8Bmcb+yxJbYSC9BJI0bRRKN6O2N77vUdpBJDrwng0/mbVmNnvY3n2C/g8BNJQZVUhon8/CgX5Cfdc1c89plKwF0QQRnJ24g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(136003)(39860400002)(376002)(346002)(366004)(451199015)(71200400001)(2616005)(186003)(26005)(66476007)(64756008)(8676002)(6916009)(4326008)(6512007)(66446008)(76116006)(91956017)(66556008)(66946007)(478600001)(8936002)(41300700001)(83380400001)(5660300002)(2906002)(316002)(6506007)(122000001)(38070700005)(82960400001)(38100700002)(6486002)(86362001)(36756003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TU1oLzN0WVNUQmlzMVVRTGFsTzdxai9WSE85NjNseUJjRERia0hacXNZSXk3?= =?utf-8?B?S3gwQXgyRVVoTVJIb0VldEVFcmNjd2NCd04rc0tTRkRNM3hRZ3JkaFJQYnpG?= =?utf-8?B?ZmVIaVRtL2tiRW9YTkZ3R2FrSEo5cml5V3QzekY4NmZmblh5YjduZmxSbFVi?= =?utf-8?B?Sm1qdjBjYjB4OTBSSlR5T3BqZkVhRTVYMHYzZnk4NXJySm9QbW5XMktpTFA3?= =?utf-8?B?NXNUdzVHYmhsTXg2LzRFeStIcTl5YjIvY01NKzlUOEhROE5CUCtJZEkveHBm?= =?utf-8?B?ZFlRTDBnMXhGUTBSdkhvTzEvZ0I4cllUNTlzOXhKMGgzc3Vzci9IWlRuT0JO?= =?utf-8?B?QVpJdUVHZE1JMmZzU0Q3S0JwRzV2ZkR4MDJ2WmZEQ1kxZW9ZamJ1U2svV0d6?= =?utf-8?B?U2lBWFN2eUh2dGc4c3RLQWlQWGwzQ1d1T3gzWUJzUWtKQnVoc0F6THBWZXIv?= =?utf-8?B?ZXVzQy9wRkcxUWRNYmhqMElCSXZXanpYVDN0U0lGTktlWERRdlhlODlTNGdX?= =?utf-8?B?emFsa2ZnckVPM2NMQWV4M25rVGxIL0E4OFZaYWRyZWlwNnpDbVc5cFEyaVBL?= =?utf-8?B?VnYrZ2YxSTF4S1FnSjJLM2poaEZCSnV2VE9WNjNrbUw4amJiUlJaRTVOQVdh?= =?utf-8?B?LzJEV2ROVGYvMVRiVWpOMk5pYVJZQ2dIWTlCYU5HR0NsZlAzMmdubWMzOGFX?= =?utf-8?B?cmNBQjU1Y1ZROWpFL09YTjhaR3lwbERLVjFwdHlTRDRMaU5KNDNaM05uNW9u?= =?utf-8?B?NXpFYXIyYU16ZkpJczRVRmNVdHB5d3Q2dVJWUnoweVdMNVhHay9kQ0pBUTVC?= =?utf-8?B?VzBTV1F6UVNLY0FjNzEzU3FqdHJlS24zS2RZYkY3VHh3d3psdnEzZ2ltZWpJ?= =?utf-8?B?ZkFnYjYyRjluZFBERGp3SWxkWHdRRDBqK2w0c1QwbnZhTXhGaUQ5Um5QYWFp?= =?utf-8?B?RXh6TjhZYlZiVm8zN3VRaU5ZcDhDZ2xXYkhrMVptYjlhY2NTcEFDSlRwaDkz?= =?utf-8?B?S2tLak5qRzltSVVqRXV5cHh4M2s5bGFzVC9xSSt2RnZsZDlzWFdPc25vcWJ4?= =?utf-8?B?ZVY3NkJoMmlhazNPdVBsdjFNaFBzamtjczNGcWVteHpOSE5YTGZYZCtPbFFr?= =?utf-8?B?alA0NUYzWDZQVEVydzJscnFneWx5OEVveG1ZRzVrUGFXaWJBZjJtZjRmUENE?= =?utf-8?B?RThNS3hkZXk1cXo5b0FzSEc0aXRycXZxczhJMi9jck1UYVVLeVFManVzWklW?= =?utf-8?B?ekhBN1hSenZHeUNJT0dMb3BrenRpOFRrOWpMc2tkcDE2MVQvb2NrSTE4NWdC?= =?utf-8?B?Um9FeG1ENkVNV0FyVitQQWlGMVJmZFF4VGJiU3JkaStBWGVyaEQxK1RBMmVK?= =?utf-8?B?eTA4Uk16Y1lQcXc2TkpubkxoRnE5NnI4SmJYM3FvbWJXVUZ5NnVFWmdoVTN6?= =?utf-8?B?RjFmRjFCaU5iOTg0UkJueTlCNG9oUjRwbi9mNUFnRlRtcDBrUVh4Sm5jWHJl?= =?utf-8?B?OWhxOWpuZzA5ZUxaWnByL09Vak45a2RuT25yc2hRbnk4andwd1VkRHlPaTNs?= =?utf-8?B?MVdlb3JSbDNkb1VTcFFHVVJzcVNiZXI5T2ZvNzA0YUNoMWpMcWVDZzdJdjVm?= =?utf-8?B?elVOWTZza2ZXVFBoS1kxWHNRc0NaZW5rQnowOTJUbCsyYWkwbEVEeVk4TmlP?= =?utf-8?B?QmNBMGF4MjBqNWZjNFRzZzdwWm9VbWZOQ0EzUnJwTFpqa2t5ZHNqR2Z5TjZV?= =?utf-8?B?TkRsaXB6UnN3SDZIM0ZYbEdERThJZWZRM25sR0VKK3JucXgzS0xzeERSWHIv?= =?utf-8?B?S0lMUFloSFlTeTdFSzdkcGlNRG5teTE1YUlKZkV0WmtadGhNZ2tmSTh4UlhY?= =?utf-8?B?OXNabFowZGlNYWZ5dVRvUHJIUU5lOWVaT3hXRlp0YVNLUFJiQnlrR0FsZ2JU?= =?utf-8?B?NW5SZTBqVnlsaStrNDFVTmlLUlpHMzlXbzlPV0I3N1A0QUh1WmlQRFdYVGtR?= =?utf-8?B?NjVnMGg0bm82LzdUUUs0VGYrblBIc0c0ZjNmcnJydUZ1K0cxSy9oUnNiSEFJ?= =?utf-8?B?VFNOano4cHVVM0ppT2tGQjc1Wmd2WU5qY2xCb05jV0luWlZjdTR2RStTWVgy?= =?utf-8?B?NnRpamFpRnlQVFFvak1rTDh5cU51OWNWWm1NRHdEcnNhaXhaMEg1TjZmK0JU?= =?utf-8?B?Vnc9PQ==?= Content-ID: <75A3ECA87CE056489FD075241E7D3F8C@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0978a318-7543-4ff6-9453-08daf778d365 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 04:19:14.0663 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vmZ1h0NZc13yH+yA0zfibR4a9ZDUM+0mwL1s6ueeo5tK4kRljqp1+6YTUoH8cE78SzCIfRrxtzXC0R+qelnEgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6518 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "nowrep@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Di, 2023-01-10 at 09:17 +0100, David Rosca wrote: > v2: frame_num steps by 2 > > --- > libavcodec/vaapi_encode_h264.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c > index 7a6b54ab6f..8093c47179 100644 > --- a/libavcodec/vaapi_encode_h264.c > +++ b/libavcodec/vaapi_encode_h264.c > @@ -349,7 +349,7 @@ static int > vaapi_encode_h264_init_sequence_params(AVCodecContext *avctx) > sps->chroma_format_idc = 1; > > sps->log2_max_frame_num_minus4 = 4; > - sps->pic_order_cnt_type = 0; > + sps->pic_order_cnt_type = ctx->max_b_depth ? 0 : 2; > sps->log2_max_pic_order_cnt_lsb_minus4 = 4; > > sps->max_num_ref_frames = priv->dpb_frames; > @@ -621,7 +621,10 @@ static int > vaapi_encode_h264_init_picture_params(AVCodecContext *avctx, > } else { > av_assert0(prev); > > - hpic->frame_num = hprev->frame_num + prev->is_reference; > + hpic->frame_num = hprev->frame_num; > + if (prev->is_reference) { > + hpic->frame_num += ctx->max_b_depth ? 1 : 2; > + } > > hpic->last_idr_frame = hprev->last_idr_frame; > hpic->idr_pic_id = hprev->idr_pic_id; The coded stream is probably corrupted on Intel's Tiger Lake after applying this change. $ ffmpeg -y -init_hw_device vaapi=va:/dev/dri/renderD128 -f lavfi -i testsrc -vf "format=nv12,hwupload" -bf 0 -c:v h264_vaapi -vframes 100 out.h264 $ ffprobe out.h264 ...... [h264 @ 0x55cc3d7dc200] mmco: unref short failure [h264 @ 0x55cc3d7dc200] number of reference frames (0+2) exceeds max (1; probably corrupt input), discarding one [h264 @ 0x55cc3d7dc200] mmco: unref short failure [h264 @ 0x55cc3d7dc200] number of reference frames (0+2) exceeds max (1; probably corrupt input), discarding one [h264 @ 0x55cc3d7dc200] mmco: unref short failure [h264 @ 0x55cc3d7dc200] number of reference frames (0+2) exceeds max (1; probably corrupt input), discarding one [h264 @ 0x55cc3d7dc200] mmco: unref short failure [h264 @ 0x55cc3d7dc200] number of reference frames (0+2) exceeds max (1; probably corrupt input), discarding one [h264 @ 0x55cc3d7dc200] mmco: unref short failure [h264 @ 0x55cc3d7dc200] number of reference frames (0+2) exceeds max (1; probably corrupt input), discarding one [h264 @ 0x55cc3d7dc200] mmco: unref short failure [h264 @ 0x55cc3d7dc200] number of reference frames (0+2) exceeds max (1; probably corrupt input), discarding one Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".