From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CE00645D20 for ; Sun, 4 Jun 2023 18:36:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D679468C3D4; Sun, 4 Jun 2023 21:36:38 +0300 (EEST) Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BDB0A68BF58 for ; Sun, 4 Jun 2023 21:36:32 +0300 (EEST) Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4QZ56k0VSwz9sWS for ; Sun, 4 Jun 2023 20:36:30 +0200 (CEST) Message-ID: Date: Mon, 5 Jun 2023 00:06:15 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230604180725.24695-1-michael@niedermayer.cc> <20230604181300.GB1391451@pb2> From: Gyan Doshi In-Reply-To: <20230604181300.GB1391451@pb2> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/noise_bsf: Check for wrapped frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2023-06-04 11:43 pm, Michael Niedermayer wrote: > On Sun, Jun 04, 2023 at 08:07:25PM +0200, Michael Niedermayer wrote: >> Wrapped frames contain pointers so they need specific code to >> noise them, the generic code would lead to segfaults >> >> Signed-off-by: Michael Niedermayer >> --- >> libavcodec/noise_bsf.c | 5 +++++ >> 1 file changed, 5 insertions(+) > I intend to apply this soon as noising pointers is not too good Their contents can't be manipulated but they can still be dropped conditionally, so the bsf can still handle them if amount_str is NULL. Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".