From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/noise_bsf: Check for wrapped frames
Date: Mon, 5 Jun 2023 00:06:15 +0530
Message-ID: <b7196da4-90e7-d0df-b640-a05149a34018@gyani.pro> (raw)
In-Reply-To: <20230604181300.GB1391451@pb2>
On 2023-06-04 11:43 pm, Michael Niedermayer wrote:
> On Sun, Jun 04, 2023 at 08:07:25PM +0200, Michael Niedermayer wrote:
>> Wrapped frames contain pointers so they need specific code to
>> noise them, the generic code would lead to segfaults
>>
>> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
>> ---
>> libavcodec/noise_bsf.c | 5 +++++
>> 1 file changed, 5 insertions(+)
> I intend to apply this soon as noising pointers is not too good
Their contents can't be manipulated but they can still be dropped
conditionally, so the bsf can still handle them if amount_str is NULL.
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-04 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 18:07 Michael Niedermayer
2023-06-04 18:13 ` Michael Niedermayer
2023-06-04 18:36 ` Gyan Doshi [this message]
2023-06-04 19:54 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7196da4-90e7-d0df-b640-a05149a34018@gyani.pro \
--to=ffmpeg@gyani.pro \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git