From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8164E4411B for ; Wed, 28 Sep 2022 01:47:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9563868BAF2; Wed, 28 Sep 2022 04:47:49 +0300 (EEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A232D68B7D4 for ; Wed, 28 Sep 2022 04:47:42 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664329667; x=1695865667; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=PK7Eqj6eKaXW+0hC069jsoPJfdybr8A2D2C6SzHCjgQ=; b=MVnYDECpsWC6Lom7iwy7z3//bf9ViAd36FMi7qkMrhhZtRj2GRhqYTBu so219bZQVUJQsbR10ajbatX5CC77/pkVP7fWgIdT2aOkwIufBizWiRKs/ wszvZvjHQTvIa79mFghVJ3TNDX4ZZXR13STjE5dDrMED845J250D9f/Ny NvxgYoqlP/hbPQRM/O5IQDDVDioUQq9/vvVnDvlr5t3V3FL8V5wQp1BS2 8ZcZRrldpKs7n27zi2dUS5cjEVFy4c8UAZ1Hh1Br7cvSnvdYMV2SigMcD ltARRmSK9Mm04d5qbi6mO94IgLYZ2Qya8+lY3aaeSLeKVekmV8V7Odaih w==; X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="281197027" X-IronPort-AV: E=Sophos;i="5.93,350,1654585200"; d="scan'208";a="281197027" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 18:47:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="747253503" X-IronPort-AV: E=Sophos;i="5.93,350,1654585200"; d="scan'208";a="747253503" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 27 Sep 2022 18:47:40 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 18:47:39 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 27 Sep 2022 18:47:39 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 27 Sep 2022 18:47:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=npSTYPIA3rM0ngoeVpseulh2d+h9tJUXodEyR742vT2uaPyrrhnnAHD9AYzwui9FrQjp/egnINOUPqqliZHMaZaDP+1ay8ySX6OT/IR68q7LSQHm9/sZvlMQxUOEXLxwGASTWGayQ4ll61Dzc3dfiilbll+DspisuXYzcX0wUgAIj9LGK40B0qluUSVTnpo/ZqcYSv1GduC07JJuN+Z7X+K47eqPhc6NycPtsBfk3Kubj99AFX7E2MvFanpRCAEZiRhsb560vo3+F3gBdFZmPuyLsjkqP6xqBrW4i82jxCGv9Wz6t9SFGD6M8N6LFv3hpoCYPeytZ62aEdqEqM8bKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PK7Eqj6eKaXW+0hC069jsoPJfdybr8A2D2C6SzHCjgQ=; b=aVeRpu/vdGePL8BzydEOBjxQpTcXJYmY5GMakGZ4g39SdwjD/QpSircIg1oQj2ZEdMMU4XspraU8VA29Z/NnxGPlPb04gbbZEPsoUwl1VpQir+cBijj9gOU3NHyhcDvfwWZ2+bQL5fI95nGVlgVHsSN76rAIp8/dyfMinBeyG8wBANutfj7tlRpzxERFyOOcs9oI0NWKFR5uKjcAze51OTQWuCra6o/x9ZcxnUKkORAEVm2tUrLHzbqRR+2tzx7gbto1Z5U1t9pdVzCm5q6kaL2C8pbgLB2UfvN9S+NaW7drhdm3riTPeGiDpTWBipzpi9di0yPOJnClaQhLWsQGGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MW3PR11MB4553.namprd11.prod.outlook.com (2603:10b6:303:2c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Wed, 28 Sep 2022 01:47:30 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::3804:a5ab:68a9:9304]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::3804:a5ab:68a9:9304%6]) with mapi id 15.20.5654.026; Wed, 28 Sep 2022 01:47:30 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/qsvenc: Let runtime to set default parameter. Thread-Index: AQHY0YwRHFyEuq9YQkeUurfNg1/2aa30FXCA Date: Wed, 28 Sep 2022 01:47:30 +0000 Message-ID: References: <20220926093630.72758-1-wenbin.chen@intel.com> In-Reply-To: <20220926093630.72758-1-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|MW3PR11MB4553:EE_ x-ms-office365-filtering-correlation-id: 0756ddbb-eef0-4aad-8f09-08daa0f367ea x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WYAzvwfVY+FmLa3DCqrslhxj5Mtk+Tz7SokEDaaJ03wVDLo3+qdfToPb5EvId5Wz5PLqGlj03eEbAn/cmkFn3s9cexg3AzH01QPb+34wMJarw6TI2TMMs5f0X/PjVpMsJsKEch+K+AWy0q6KBg98jNeRKMMfVtF5MxHXh9Dbp/3fHsrnPtdfZAY1+LpmQnBPfVSGhE8knZkI9W3ma+gK0sGBLMOhcBjpRraWlongRObQQzVLis/0lM1WiLM5VURq4Fd4HojK78ca7XxiwzpPSreDSDQjia+2nJjdAlvMaYwUppMdq62m7FTGV94qP2MS0U0BudFs5fNMetc3BuBfblZ1SOhy10zGjWSlU0q3iZjEFB5Q6MDTVLZJcB7DCjR5tujqqXBdRMLdB7fq1SVNfputwG9qaoosDVzT2thWTQU9btMKIhJZMBzQ+gosABcAFgmCiRyKLOLkT9dz9QpKZjKlJCmC8QL1FcszRL5wiLGCQxjnnL+oTchiI/JqSNFiZf325/GYFtqhUBBX3gnLrnKKiTi9zqwGFOA1ARSFoco2Os8VsRfwxyowu9l8PkB0hojCnLf68EEkwWlK44La8ss3k7L/iUjpakLCzaBDXcqq5/VsaTGtM8bn029yYD8W73tT5ITqzc/Ky2MBtcDBAM4HVaY/skqcWkPK8GB0FgZBV3vLHVlMaX9vr0JEdvXc77LUE9r1TqQQ0UHc++/wZ9L+hYQI9SoN8MONqD71I6oe2dZiL4+bFxfNrKMq0xW7pv9AQfo2gYqD8rpCw6pTIs1k2AP76dL5PwWTv7rctuE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(346002)(136003)(39860400002)(396003)(376002)(451199015)(8936002)(86362001)(66946007)(66446008)(66476007)(71200400001)(66556008)(64756008)(76116006)(91956017)(6916009)(8676002)(6486002)(478600001)(316002)(2906002)(36756003)(5660300002)(38070700005)(122000001)(82960400001)(26005)(41300700001)(38100700002)(2616005)(186003)(83380400001)(6512007)(6506007)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b3Y4WVhkc0RmZzNlRjRURm5wYkk3S2E5ZU1IYXp0SjZ1V2Q0WXZoQXNZeFNo?= =?utf-8?B?dmF6MTd1UDRva2E4VWFrMXFNTEd1cTRRL0RETTRhZWdxSEd2YTg2UlJhQmtP?= =?utf-8?B?UkltQ0xzSm5wcEFmT2NGNjlPT0d0WjBsbzB2cmsxMm1FdjdNQ1ExeHRWWWlS?= =?utf-8?B?L1FaZ3l3WXlFM1VReHg2UC9kVitIOUY1Y1cvcXR5Vk5tRi83bUw3N3JpN1dR?= =?utf-8?B?QWpDdVgzdjU4YXZBcGMxOE1UaWFFcjZsVUEyM3FYTjdXRDdYY0k3RER4L1By?= =?utf-8?B?NnNydVdmZ01DS1pudGNTS21mRlNxcmEvbGdTemowcC9tYmFrbE5VSzBHWGlB?= =?utf-8?B?bS9YZDl6d082R3BaaFkrY1RtYjlxMzA3ODc0VzNtTmZKN0RGV0V2bE1oZFhR?= =?utf-8?B?STRxNkV1Y3VmaTJRbWVvd2JocnRZOFQ0M0J5ZXNlek1qa1BYVis5OW1VSUJi?= =?utf-8?B?akdKZmdRV1FNSUlzeGtYZTRibkhCdE1UTGdpK1VQc3VBV0ViVExHVWpXMER4?= =?utf-8?B?Q0hFTTFkYWNhN1RIeGNiQXNQbGQ0dHZwN1NBaFA2Y3oyeFh6bDlaejR1eWJs?= =?utf-8?B?Nk5YcVRTOXYwV1prTGZxT2VRR08zY0hiWHRXZU9LK2MzUWtxcnFWdkd6cGUz?= =?utf-8?B?RW9CRTFIRmNPYlBoeVA5RXB1N2NLM0VLbDZlSDQxNW12aU1vUHhQQkdLNHA2?= =?utf-8?B?eU9FSmpTWUEyQUFSM0VXbmxOV0tnNVZVOUo4K3U3NlRsNitmVlhxUEFPVDll?= =?utf-8?B?SFZhbjhsNDdYM0NPbnNjNUlyczJkbTZya2ROdE8zcFJOS2d1emlTYVB2WXJn?= =?utf-8?B?Y2lzWnVhUWFVS1RmN1k4allFa0haOG51SEpYNjgxUlFHR2dZbHJGUURxWjJ3?= =?utf-8?B?bUJOR2o3T0FicTdXREJxdENpYjh1VE8rbXkramluczI2N2w0UVBqSWRhQy9X?= =?utf-8?B?OWhpV2lpUStwa0xVaEtFeEpZdGRMWFdFY1hsV3lHVlkxOXlzNTllYUtCaW5q?= =?utf-8?B?eWF4MXRYOHpvQ09ESUZna21vVnVXQnB6MVBmVXdPaW1uenJFUWpxQms3ZWEx?= =?utf-8?B?eXk4Q3JWcFQyMXRDQzZhODhIUUhZZnVtS0ErY25zNFJsSnpZK3BFWmk0d3J6?= =?utf-8?B?RnFQdTZjRGxHYVZJYi9FMzQ0cUhDU2UwYjRneU1lN3RNQnp6TC9PeUpBUlh4?= =?utf-8?B?OTVheS8wa2ozTTZWZG1EckkveFBjWDYwbk9CWlR5a3lyWXFqekcvMlM3dnJM?= =?utf-8?B?d1Bwa2JPeS9OVUV5ckt2N3MwU2swWk12UkhWOXV6OTZtZW50NCtiTk1iT1NR?= =?utf-8?B?WjlBU2NoTGZvei9Bczg5M1A1Tmtta09GYUpxWGF4MWxOY1ZFQlZ0cjBsN1Ru?= =?utf-8?B?ZmpZZ2psMFJzUXo5YnFIRWpMb09hbUdJOFZSMFpENG54bVZkYSszVFR2ZGFs?= =?utf-8?B?cjdIUTVhUjd3dTAzekFiUkdlUmpQdXQzcWw4ZENyWGxWVFZNcjAvZVVlYXJT?= =?utf-8?B?VHpnV0M2eUEyYk1lbmxFb3FLUFRTelVmQS9hUjYyRnArZGJzc3h1OWlqK2g4?= =?utf-8?B?d24wakloQWVlUndmM3dxNlV6TXk2eWdWeGx0NGxUVGNoY3NEMU9SdXFlMXVa?= =?utf-8?B?ODJGeGxYVWdZL0RJY3EzS1pLTy9nSU5JelhiSDRibVZ1dVVxYlVqcjdYcnI2?= =?utf-8?B?RUZxK1FyMnlNR2VhSmk5dGRCNnF2bCtVMDAwbEJ2TzZ0SXBlSjVHMTZ1a1lo?= =?utf-8?B?NWRoUUVaaVFKU2lWL0RoSHNQRkdDU0VuZkV2dG5UYlBaSUxkZGFwK1hlaElh?= =?utf-8?B?cU9qeFYybk5WRWVGL0lYdFhIbmVkTkdMalBxVW41OVcvV0xMZis4c1lURFJp?= =?utf-8?B?QWw4VWJxM2JNZW1rNEtBMC9mcUNrNkpIMjdIbmZPeTBkalEzT0JzNExhWHVE?= =?utf-8?B?S2N5WkkrS3hUaVE5WW1zOURyUUk3YldDNHBIVWdXUkFaZ1FTeks1ak9BQ0F2?= =?utf-8?B?WFVtbDZ3azVFUjdDWnR2RGNGOUUwS2Y3VkdxN1kwbndrK09jVkFtQ2RxUkNK?= =?utf-8?B?VUY1MzB1UkV2eGxNSWI2RjdON2F0eUVBY1ZJU3J5RkxITFEvUXhNcjVHY0kz?= =?utf-8?B?OUt6eEpVNS9vVURkUGY1OVhRV29TYjdkaHV6ZHZLRUNTYnk2NXRBNEtXU3dJ?= =?utf-8?B?V3c9PQ==?= Content-ID: <067808723831F24983DD5D7B8689074F@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0756ddbb-eef0-4aad-8f09-08daa0f367ea X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 01:47:30.7112 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hvLL+7pyjxLAYkobG82vQgjjckpQZKAUOdqiscDgRtWwWupw/Aca+S+B11bjFcq2vqHJ89BRp5MnEXbseiQRtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4553 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/qsvenc: Let runtime to set default parameter. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-09-26 at 17:36 +0800, Wenbin Chen wrote: > Unset qsv_h264 and qsv_hevc's default settings. Let runtime to decide > these parameters, so that it can choose the best parameter and ffmpeg-qsv > can keep up with runtime's update. > > Signed-off-by: Wenbin Chen > --- > libavcodec/qsvenc_h264.c | 5 ++--- > libavcodec/qsvenc_hevc.c | 3 +-- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c > index 85826ae4be..11aaabbd1b 100644 > --- a/libavcodec/qsvenc_h264.c > +++ b/libavcodec/qsvenc_h264.c > @@ -176,9 +176,8 @@ static const AVClass class = { > static const FFCodecDefault qsv_enc_defaults[] = { > { "b", "1M" }, > { "refs", "0" }, > - // same as the x264 default > - { "g", "250" }, > - { "bf", "3" }, > + { "g", "-1" }, > + { "bf", "-1" }, > { "qmin", "-1" }, > { "qmax", "-1" }, > { "trellis", "-1" }, > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > index 6ec6230999..a5bf915954 100644 > --- a/libavcodec/qsvenc_hevc.c > +++ b/libavcodec/qsvenc_hevc.c > @@ -289,8 +289,7 @@ static const AVClass class = { > static const FFCodecDefault qsv_enc_defaults[] = { > { "b", "1M" }, > { "refs", "0" }, > - // same as the x264 default > - { "g", "248" }, > + { "g", "-1" }, > { "bf", "-1" }, > { "qmin", "-1" }, > { "qmax", "-1" }, Patchset LGTM, will apply. -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".