From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2DBB74B50F for ; Tue, 28 Oct 2025 12:29:28 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'BbfKBe50kBIc8AWJpsaxQOGc1UAavFg2eR1lSRftGhs=', expected b'9JGJGyzYqiPD62QCAttwB8m98rKMsMaMZF4NwjZAxdM=')) header.d=hanwha.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1761654554; h=to : date : message-id : mime-version : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=ukkASGFW3x2qEWHtTMiBq+SRxs34U1y6zaG50mIG6IE=; b=enn57DuXz4PV/VMLmlbM2A8zsCPd0p2um6osADJfaO+Zi3wAYnpBlmYuhmSrdyAmOLFVz k1Xk/i1NAsou6ha9UzmZRA5H0wRehMX83eMjNHiEfteJGTpEEiabVfvDjd5+MHBRAOxKmrK NaclZQiG8vAABCrbxENNCdxN96DBuwyYL9R9G7fjPfESCkxcuRVcwPXmVApERO3pVFq5uvI B9HFeY0SUIq9r2aa+cqb/QXabg3MJxK1xrUjrmjLjL5v3kHhCrMy2pleUD+uA7ZV4BgqXQd h+E18ZknXci+ajWrrALIVFyQtOdiQuxXfUJjQlwEFsz2e8Fx8EgY6HV2zirg== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 820AC68F7BA; Tue, 28 Oct 2025 14:29:14 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1761654540; b=R0rMBFh0o2+4MiFM9KQCA+jhDyBPj4XUL7ZU0G/KVB1/iwIZWmF9/C+JmZf9GsZPg3hJ+ FXhvhjNwjeVYpNbKAFPlllnvPhpWIBlQZgPjicNBt3vVjP/hfMPcfpI0R9Omv0IXZktDX04 3gLJtwgLfv7jq0W96kJFHYYdUlqAwRyPbHo0DEAGSh/WIWoArZk70h3cRwcVtDyta+E5LoP WDyHG7O094PxfWa4BgIAh2AWhfVd5pDik1LhnWKbahg+Nd4A8fVdj080Nq/taP5AyrIqOk6 S6pGTz/t/t+7xpFE6WLYaLbKw/gb1g407i7rZcKc/KnjVQaV5rpg5MOH2vDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1761654540; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=BbfKBe50kBIc8AWJpsaxQOGc1UAavFg2eR1lSRftGhs=; b=T6lA70ubyxIJxtBme/ew6gZRBHcHFSQNcnrhPa91LjEIq9VA3xoQFYHoBKMJMyta6BVLu iVpYB+zN9kmh9DH4fRmlpKFy+lfmZ311LmBkM2RUIef42K/WVriLbLzdof+dtmZst32qDzL Vc0bd3JGDN41HWphRdaal27yZo3thEyVPGWUwAdWblRp9owYFf8zygEdrkL8djR4R/gnkw0 jdwqoDjcfUMyIFJd0idMW4NFpNdtyyvcjK+CsPaFLVy2U5BaeMVlNZq/JCRlYtFciO1r7p4 dRodd7Tse4oW41nQFbMhNxwjkOWeCwwnf6u2gyDZwso5pvN423TWq0pu2/Uw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=hanwha.com; arc=none; dmarc=pass header.from=hanwha.com policy.dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=hanwha.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=hanwha.com policy.dmarc=none Received: from mscreen.ep.hanwha.com (mscreen.ep.hanwha.com [218.146.32.13]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id DC59D68F79B for ; Tue, 28 Oct 2025 14:28:48 +0200 (EET) Received: from unknown (HELO autodiscover.ep.hanwha.com) (10.42.199.61) by 10.42.199.131 with ESMTP; 28 Oct 2025 21:28:40 +0900 X-Original-SENDERIP: 10.42.199.61 X-Original-MAILFROM: hh3.kim@hanwha.com X-Original-RCPTTO: ffmpeg-devel@ffmpeg.org Content-Language: ko-KR DKIM-Signature: v=1; a=rsa-sha256; d=hanwha.com; s=20220405; c=relaxed/relaxed; t=1761654520; h=from:subject:to:date:message-id; bh=9JGJGyzYqiPD62QCAttwB8m98rKMsMaMZF4NwjZAxdM=; b=axJSLW+Qq1FKyCAwR3DnHvzo8z7ZDOQ5fCm+SPEQnuRh/JQShJrLmnfjQgfHYQ1i7o20b7Gae7G 9LlEUd83/qKOCZa0/Ki1fJkjkUlLl80F2uGv4pn2Z9oYI9JIr80xM2ayNenyhspn4Kld4eyB6WDDN Y1rViy5hctThlh15oZCQXOLs+E2eDUO0rVrZK1UpoC1F+lGl2LtLbzDR+jePIspmMA969g1eIU2hA JOe0d3AJPhCWYnB3KL2orh8o7jLs9RF+5w5jGukg0LpDyhbwHWUC95FxqJ+3rKjP18aCAJJ7QO8HG arigK9d5b0vDXLF2IXJE+Ztnqt7zV5EwUiaw== Received: from EP-EX02P.EP.hanwha.com (10.42.199.62) by EP-EX01P.EP.hanwha.com (10.42.199.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.55; Tue, 28 Oct 2025 21:28:40 +0900 Received: from EP-EX02P.EP.hanwha.com ([fe80::25fc:9759:17fb:6e22]) by EP-EX02P.EP.hanwha.com ([fe80::25fc:9759:17fb:6e22%11]) with mapi id 15.01.2507.055; Tue, 28 Oct 2025 21:28:40 +0900 To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH] avcodec/qsv: Multiple calls to qsv_decode_init_context() cause memory leaks. Thread-Index: AdxIAvOyo3RgpLd8SJ2yXioXWh/IVg== Date: Tue, 28 Oct 2025 12:28:40 +0000 Message-ID: Accept-Language: ko-KR, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [55.101.66.208] MIME-Version: 1.0 Message-ID-Hash: IJQDHKFXPOWJOGWAQN3IN3JMO2AAYE3Q X-Message-ID-Hash: IJQDHKFXPOWJOGWAQN3IN3JMO2AAYE3Q X-MailFrom: SRS0=vqN+=5F=hanwha.com=hh3.kim@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/qsv: Multiple calls to qsv_decode_init_context() cause memory leaks. List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?b?6rmA7ZiE7Zi4KEhZVU4gSE8gS0lNKSB2aWEgZmZtcGVnLWRldmVs?= Cc: =?utf-8?B?6rmA7ZiE7Zi4KEhZVU4gSE8gS0lNKQ==?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: Calling qsv_decode_flush() results in qsv_decode_init_context() being called again during the next decoding cycle. If q->pool has already been created, this causes a memory leak because new memory is allocated to q->pool without cleaning up the existing memory through av_buffer_pool_uninit(). If q->pool already exists, we can simply reuse it, avoiding further memory allocation and potential leaks. Signed-off-by: Hyunho Kim --- libavcodec/qsvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index 039ba62484..8a17a52da8 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -412,7 +412,7 @@ static int qsv_decode_init_context(AVCodecContext *avctx, QSVContext *q, mfxVide q->frame_info = param->mfx.FrameInfo; - if (!avctx->hw_frames_ctx) { + if (!avctx->hw_frames_ctx && !q->pool) { ret = av_image_get_buffer_size(avctx->pix_fmt, FFALIGN(avctx->coded_width, 128), FFALIGN(avctx->coded_height, 64), 1); if (ret < 0) return ret; -- 2.48.1.windows.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org