From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/libjxlenc: support negative linesizes
Date: Tue, 30 Jan 2024 12:16:19 -0300
Message-ID: <b6c07393-b6ce-4456-85ab-81b18f81fe84@gmail.com> (raw)
In-Reply-To: <e9e81d58-085a-4b14-93fe-54df8fa924ab@gmail.com>
On 1/30/2024 12:06 PM, Leo Izen wrote:
> On 1/30/24 09:57, Andreas Rheinhardt wrote:
>>
>> Please don't rely on the type of jxl_fmt.align here (which is out of our
>> control). E.g. in the future it may be that libjxl supports only 32bit
>> align values (i.e. uses uint32_t or so for it), but that we support
>> 64bit (ptrdiff_t) linesizes and allocations, so that jxl_fmt.align *
>> (info.ysize - 1) may overflow this even when -linesize fits into
>> jxl_fmt.align.
>> (Very unlikely given that align is size_t and they will likely not go
>> back from this, but it could happen.)
>>
>
> This would be an ABI break though, wouldn't it? Why do we need to work
> around a potential future ABI break?
Point is, we have control over frame->linesize[0], but not over
jxl_fmt.align, so the former is better to calculate offsets in our code.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-30 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 14:46 Leo Izen
2024-01-30 14:46 ` Leo Izen
2024-01-30 14:57 ` Andreas Rheinhardt
2024-01-30 15:06 ` Leo Izen
2024-01-30 15:16 ` James Almer [this message]
2024-01-30 15:24 ` [FFmpeg-devel] [PATCH v3] " Leo Izen
2024-01-30 15:25 ` Leo Izen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c07393-b6ce-4456-85ab-81b18f81fe84@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git