From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8DE4845828 for ; Mon, 26 Jun 2023 07:27:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3C23168C289; Mon, 26 Jun 2023 10:27:00 +0300 (EEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 79D0868BF7E for ; Mon, 26 Jun 2023 10:26:52 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687764417; x=1719300417; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=g34VBkwAQWCH5wxQ9RU9WGBuD8/FHyadLGRL/iNe6Gw=; b=mdY3swRRngR0tW0io7JMEAfisvnIjVzsnioFtdlhOIlHgXOO8CSoAqxE tO3GljYum66j0XqfD8B5ceVpekcMTXCmnp02s4CVA2WfoNr9VtkFB8O78 3uU4FaMWqbMjwuGTADwBOD92UXNGlPw9MOyA9xoCYmaqP5YPxJfuLrls+ BVUmBRp1bWr3t3h4Jfi9DsfpP2qZF3g3hcnDdmrRZMsTGYojwx0vetTjQ IV7tvWolWX2p1noqcaBJ1pEuN8V5y9bAv9sPOTz+CNFJAETy8FZdTBlVE o+f/m2n6mC1yCrWVXZ6vUwpEVnrvT1h2nvPWwt/63ntf6i1/DduEazdBI Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="363745838" X-IronPort-AV: E=Sophos;i="6.01,158,1684825200"; d="scan'208";a="363745838" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 00:26:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="962682414" X-IronPort-AV: E=Sophos;i="6.01,158,1684825200"; d="scan'208";a="962682414" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 26 Jun 2023 00:26:48 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 26 Jun 2023 00:26:47 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 26 Jun 2023 00:26:47 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 26 Jun 2023 00:26:47 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 26 Jun 2023 00:26:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l3qBBnp8SqFpcH1wkf5eGwEhLFT7s0YYzYheLcDU00yrtYcHgmZTdhxjz61mG52UAkj5EpudTkxWIxL6/3g8O6VqJC8WxHWOrZ6xu0Veww6p64pmm2UtOqKmQXXhLfEnDADmj3DBd3u+bII+czeVB51fRW9dghrVaW5+8/gLB9pxZzLJw7unA5bzZouMvxrELpwm/O4M2fxr0dUjaUySc53QtNLJM0zXRcmmVfVj8bsMpn3HT9JDjMZAHxe/zNqLYXCcGO1iskYy2r0BP9YqJUMQnxpvkxHviTjrrj89md+eJJaQa/9/VJSXMjzzkdRnDAFYbLEpKquPvAfA1ei2gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g34VBkwAQWCH5wxQ9RU9WGBuD8/FHyadLGRL/iNe6Gw=; b=UKAXRepqOBb4wcYVBZTJQzAIuOPLtl2ljTjdtBu7D7R1rEvWBORCdEWS95OJDGkaW7IW28WaaOjU5Oobm5twYtKKeUZ8rFmC3qJfOH43PJAmzUGFLu3BB9TRaEVRI2FYTrfh/D6xy+qKEYH1yacs7Sqp94O0fvK9LqwAgbrh38b9I0LZ7gPgZtqNCqPuqkgA3+CYja3Mj/Apc9uoovfk3mVgxGhw0LhjIaZmVdIEMDwIaZowtm1LJu3FJCml74e4PqFk8uMwQQq2qk/B1W11uc7izDT2M4LIoJB8W0jkPt1kLVpasTUwvmZigjSVszuEdL1TutSX4ZLaxAZloNyccA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by DS7PR11MB6104.namprd11.prod.outlook.com (2603:10b6:8:9f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Mon, 26 Jun 2023 07:26:45 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::f8ae:2ef7:e0e7:dca4]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::f8ae:2ef7:e0e7:dca4%4]) with mapi id 15.20.6521.020; Mon, 26 Jun 2023 07:26:45 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg_dec: Don't keep sending frame to filters in flushing Thread-Index: AQHZnN60d+ExaxDkUUeh8GyE8q25ra+bIHGAgAF8aICAACiCAA== Date: Mon, 26 Jun 2023 07:26:45 +0000 Message-ID: References: <20230612033311.363757-1-fei.w.wang@intel.com> <203afd22d315c4d12e76a88320bc3d8cbbb74a72.camel@intel.com> <7788c26cd6c0fcb400f57ff1523b7598cb7ad309.camel@intel.com> In-Reply-To: <7788c26cd6c0fcb400f57ff1523b7598cb7ad309.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|DS7PR11MB6104:EE_ x-ms-office365-filtering-correlation-id: 324af139-3ce5-4a1c-3837-08db7616b239 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fvuLuqVjnL6vFo2TJ7VJNn8DczP7gflUhmBT2QbdXIeFC3prR6LQuPnKkPxBYmCv7whw77AFs9ZN9/w8TzTK760v57ipnVXZAwpUj5NMkQilsOjtjkBGFdHl8/wOZMnZvogH5s0iOIWRLaJJZaySOSDikaqtH+mam7Vp9R/52aD1Xco1+G7bCmTeQyhk0ke+Knww/Es2TlccgNqt/1cTdyeWDtenKx/AUDTcS043exwrLKjE00kfuh/TPItiO68NRxgncgTusGmHpZgphc/Io4b+8Ts+6nF+9mST6eRGQy1ydms6fjdFKtTwr86jMHQAp7ssELX6WMO61pzqqnzX1TlfV61/jl3Y4Ob+gXdQ3EO8xEpFjs0nM2E+j22eXQgJFd1LHNtSH43AUHsBAEwn869BFjGo+OPx6g6WIOwn/RFahef8M4yVGr8MAzPG1ELTNj+R/qror9CNDZPblrfPREaAZUC3UvYtcWq02JweNYt/1jMwvrXEayTowufZbKSNke3A/SZOG7HJIuYT69hwC5x/ZpykNv4NtlmJnw5xMeOp18UM4e4hx9eO4PtnkutqkNLcH12EZRFxxF088/SLQTna+EsCT1e8SxlflXOT9cE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(39860400002)(136003)(376002)(396003)(346002)(451199021)(82960400001)(122000001)(38100700002)(38070700005)(83380400001)(36756003)(86362001)(478600001)(2616005)(966005)(6486002)(71200400001)(91956017)(76116006)(66946007)(41300700001)(6916009)(316002)(8936002)(8676002)(66556008)(66476007)(64756008)(66446008)(6506007)(186003)(6512007)(26005)(2906002)(5660300002)(66899021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Rzc5TVpVWEx3UjZFRHlSdjdOMDdDcW91Z1ZQdVRoMlRjZ1lPaDhzN1B0bTJJ?= =?utf-8?B?MTZIZkZmOWRSL253QTVNd0xQdEErSVZJQzJCRm9pejBqdUJsVEdWMXh2emd4?= =?utf-8?B?RlQvUnR5WFh6WlRDa2pnTUJsZFFZSnMzR2dzbmduN0xNM3JyamtJUEJlTXBL?= =?utf-8?B?UGVkOTNxZHZhR2xFQjBDQk1NdnZ5N3BHMEVWOGF2SEFnMHlRdGxhdktJOTNy?= =?utf-8?B?N0hjNGNxaXdJbTJhN1BBVnJHb3o5aWxLR20wbmsvbUthNnozcTlvRk1CVndH?= =?utf-8?B?V0ppQ2UxWWhFK3RoRWZGT1VESndNTVJ5YmJDM0RTZkRRVDdYNVlPTUI5T1p3?= =?utf-8?B?RDBZS2k2cmpEcy9nMEZhZnFMRkczaFA4OEJYUFRORHdsNGNNekcvaTExZzF3?= =?utf-8?B?cDdZYkdPWWpNQUJWcVYvQXcrVjVQK0IyVHg1VmhsQ0Y1KzBJRjRjZ3QydHZt?= =?utf-8?B?L2RHMjZuZGRoc21pakgyTkFkQzhsTjFwZ20xNGlPUmh2TWRJcEpNcWZKZ0dk?= =?utf-8?B?WFE3NGhoMU1mek44MmQrYVJuTlQ5TFhSUTgvSUc1b1M5aDZ0bWJHN3BsWVRR?= =?utf-8?B?YmEzVmxacUYvSjVTYmc2ZUFacmdKN05kSjAxa0M5M0h1ODNrWUFQb012Y01J?= =?utf-8?B?bzVDZG5PbW9Va0FuZGVJdzV5OGxVRlFNLzNzbXk4R3ovcHJ6WG9sVTkwZy9F?= =?utf-8?B?aHkwWGpSdHBkQ3NSekRHaVVUTnpLZiswOGRGVU1IYnNyRVRBTVpqTzA2TEtD?= =?utf-8?B?djArNkFXY3BJTTNEYUVlMUFESXJBN3NRTWZsUUhFL1dDSVBYdWdNdWMxcGV2?= =?utf-8?B?VDc3eVF1bXZkVzl2S0JrMC9OWDRuU05KTkpXVTNyU2lCaFdkSldTM1FHb1VK?= =?utf-8?B?dUk5WXg5OHZidFFwS28xVmR0aGJ5alRyc0ttZTllc3BMclFhSE1HYzFGMkly?= =?utf-8?B?emJPUlg0RUdrbElQQ0dwaXI0UHVyTWZFMTkrSWRKeE9hUzlmc01TMlljN0gy?= =?utf-8?B?NjFEOWUzd3VlUW9JdTJUU1I5V29nMTlXOGxKZ2dBWHpWdzBiaVpoZW5pckZr?= =?utf-8?B?TVhETlkwNTRIL2V6eGsvc0t6d0FpOG14b1hxaE1obHRZUmQxdDd2M1ZXOG5u?= =?utf-8?B?bHc5c1M0WnlrLzI4YVlNOVhFMFp5ZXkrcjNpcTdFazRnMFkzZG55ckdMblhm?= =?utf-8?B?bDBVN3BTSjdKTk1Vcmx6Z0RCTzF4STFEZmh4UElOM0w5ajVWVWxHaVNOeTMx?= =?utf-8?B?dWRaZC9VNkRKSVRtVlI3NDRtdFh4RTVhNXpHY1AzNnN2cU9pRkdud1QvdDlu?= =?utf-8?B?RVkxb0Z3bSt4UW52d2t4OGZpVUtLZDZ3SWg5aEEzZkNUelczY1praTg4bjZ0?= =?utf-8?B?a0V3TE1OVXkwS1dDTklna09ZMC9EalVBQjVhU3JEUEVLd0xPcVhDOTZTNENu?= =?utf-8?B?VXY5NHFIZFIyR1VMVVdocTRQeU9xbmxMaVhOWWJNYURKcklOOUVobHFrZlYy?= =?utf-8?B?S0o0Yys4NUZ1TnFJUTNXZzdzWEdqdDludG95VWYyRkR2dW5SckduSWh3TXhP?= =?utf-8?B?MUw5VmRvQWx5bC9TN2hhR1pmaTYxcWFubldVcHdvTEhqTFBraWxsTDJvRVN3?= =?utf-8?B?UklHSWdpM1IrdWJUTzlkYlQxZ2ZMbWdFbDkreFFwQVVndmM2Z3I3QlM4dng5?= =?utf-8?B?Wmx4MnVWUnE5ZTVpM09QRHVUZk8wVWw4cm9ldytzK1hPRnNBMy9YZm41VklV?= =?utf-8?B?S2tscmpIT2VCT2g0RHFhMkJCck90a2h3TE95YzJpTUovaDNWNE5FZUJveHZh?= =?utf-8?B?YjNCcXg0T2JleGlBS01obVFJa0RmQ0FheW1zWnhBQm9id0NubFJ2b242SFVm?= =?utf-8?B?dXhaK0xjZmRBVEZUTEd0dlZBVmd0Tyszc0hwTmNHcW9zY3NZZ0Ztb2tsbTl2?= =?utf-8?B?Qi84dWtWMGh6b3M1OE5IMnNuaVRLZ2hFM0xNL2JRY3RvUDJuamh1N0w3Rkpo?= =?utf-8?B?SjBJSWVJMUczb20xQXphQVNJdWFLbDVPR2M2V1VmNlYxV3VNTkxHL1VpVFV5?= =?utf-8?B?bHZPNUxxWWQyVnFpOU1GKy9JNmRNM0gxQjYvTnZCY2NLakxaRDczckwwUEJr?= =?utf-8?Q?fS4hwEjqeUtdI4RuaiBl/POgL?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 324af139-3ce5-4a1c-3837-08db7616b239 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2023 07:26:45.4169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n0N6SMwwZKj/53Ehw5tcflo7+nsXL40G6pUPlumJDi2NmBPBPTRJNWrHF8bxygnmuA9U+ViTLEQMsjKwjrONTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6104 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg_dec: Don't keep sending frame to filters in flushing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2023-06-26 at 05:01 +0000, Xiang, Haihao wrote: > On So, 2023-06-25 at 06:20 +0000, Xiang, Haihao wrote: > > On Ma, 2023-06-12 at 11:33 +0800, Fei Wang wrote: > > > Filter may has a limited frame pool size. Do not always send > > > frame to > > > filters without reaping. > > > > > > Fix the regression of commit 5fa00b38e6. > > > > > > Example cmd: > > > $ ffmpeg -threads 20 -init_hw_device > > > vaapi=hw:/dev/dri/renderD128 \ > > > -hwaccel_output_format vaapi -hwaccel vaapi -i > > > avc_1080P.mp4 \ > > > -vf 'scale_vaapi=w=720:h=480' -f null - > > > > > > Signed-off-by: Fei Wang > > > --- > > > fftools/ffmpeg_dec.c | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/fftools/ffmpeg_dec.c b/fftools/ffmpeg_dec.c > > > index 799be63215..d6b34402f8 100644 > > > --- a/fftools/ffmpeg_dec.c > > > +++ b/fftools/ffmpeg_dec.c > > > @@ -531,6 +531,12 @@ int dec_packet(InputStream *ist, const > > > AVPacket *pkt, > > > int > > > no_eof) > > > av_frame_unref(frame); > > > if (ret < 0) > > > exit_program(1); > > > + > > > + // During flushing, break out to reap filter once send a > > > frame to > > > filters to > > > + // avoid drain out filter's output frame pool. > > > Especially for HW > > > filters which > > > + // always have a limited frame pool size. > > > + if (!pkt) > > > + return 0; > > > > Looks good and it works well for me. I'm going to push it if no > > objection > > > > There is a conflict when applying your patch to the latest FFmpeg, > could you > rebase the patch ? Rebased with V2. Thanks Fei > > Thanks > Haihao > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".