[FFmpeg-devel] [PATCH] avfilter/vf_crop: prevent integer overflows when calculating SAR

[FFmpeg-devel] [PATCH] avfilter/vf_crop: prevent integer overflows when calculating SAR

[James Almer]

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavfilter/vf_crop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c
index 6361209941..d4966323f5 100644
--- a/libavfilter/vf_crop.c
+++ b/libavfilter/vf_crop.c
@@ -206,7 +206,7 @@ static int config_input(AVFilterLink *link)
         AVRational dar = av_mul_q(link->sample_aspect_ratio,
                                   (AVRational){ link->w, link->h });
         av_reduce(&s->out_sar.num, &s->out_sar.den,
-                  dar.num * s->h, dar.den * s->w, INT_MAX);
+                  (int64_t)dar.num * s->h, (int64_t)dar.den * s->w, INT_MAX);
     } else
         s->out_sar = link->sample_aspect_ratio;
 
-- 
2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_crop: prevent integer overflows when calculating SAR

[James Almer]

On 7/9/2024 5:32 PM, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>   libavfilter/vf_crop.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c
> index 6361209941..d4966323f5 100644
> --- a/libavfilter/vf_crop.c
> +++ b/libavfilter/vf_crop.c
> @@ -206,7 +206,7 @@ static int config_input(AVFilterLink *link)
>           AVRational dar = av_mul_q(link->sample_aspect_ratio,
>                                     (AVRational){ link->w, link->h });
>           av_reduce(&s->out_sar.num, &s->out_sar.den,
> -                  dar.num * s->h, dar.den * s->w, INT_MAX);
> +                  (int64_t)dar.num * s->h, (int64_t)dar.den * s->w, INT_MAX);
>       } else
>           s->out_sar = link->sample_aspect_ratio;

Will apply.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".