From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AC52549475 for ; Thu, 11 Jul 2024 12:44:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A346868DAA1; Thu, 11 Jul 2024 15:44:18 +0300 (EEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 39AEF68D951 for ; Thu, 11 Jul 2024 15:44:12 +0300 (EEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1fbd1c26f65so4557475ad.2 for ; Thu, 11 Jul 2024 05:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720701849; x=1721306649; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=+pIMCxBzUdDFeykpFSeztQJ3e5bSkQPrF+eSGtliItU=; b=PVQRVn8UV/x/ITK1dcBSGg9tUovHesR/4aGTb4XFEAsWdyBGqLKN4PC0UJks8jJ0+i 4l+OEmZFThFU+DBgGkJYKqVeZvbRkl+1CgAV1TykH+tyeamjL8im+SQIvxYqeLKNJS2U f3b4Ik9VbbWr6DAjIxRCEl0aFrVDwrknxWcit6X4YMvMLQYoARFWdwslBKNiu0q5wNWG 1P2yK6b0I/eSvn2lTnTXCzOrvUzK1G13abVJ17cTf+ODJ2RRUE618UMlMLLvT0lcwPdm m7Z6H8DgBAtZ666MNco8rwhfKaGrOkpqu/XggbpyLeZr/D9b5DPqQtt4eCQSXTzbdiFD +cAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720701849; x=1721306649; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+pIMCxBzUdDFeykpFSeztQJ3e5bSkQPrF+eSGtliItU=; b=FBpoV7sZOhApmLZlszJanBX3wkBSeSZfT1gVtILsOpe4bqXH2gMTPSBmZTivHPa9l0 9CvXV7DRIvQQ2L5JrrZdhkXDCozvYNYiQmfq2Tvp1eTkEUCypa+Bmb9n6xv6e4qKH4uh xS/LLuN2D9KpshHS+WotxS4mhxO7mkLif3memM9G2GN4HtF8wlE+CtKSoOAOsBqev4sr RDLL8qFfJo22AjcN5GycYFLlJSUdSP1oMPzgRsWl4GebvseIwxPKEXigwrVy6GT+Zqty Q7QpwlSEh0iu8f++/oejgKN6PsFHIakJ22IUXnT1E3hJ4Abpc09/IAcEJh0DqIvY+SzB X7Fw== X-Gm-Message-State: AOJu0YwybnlAUMHBM0/uyBy9IHkGIVbUsluiSRXs07vxMrhnuZ7+RSPF TzBUUvs18uh7BTuFUtcqMTqVM/gvA7k5CibRHOG4d1WLfFNIz19VDbgoBg== X-Google-Smtp-Source: AGHT+IGObZqcb4u7XdSovWmsAeMFSetay0KONLFP7P6cPibQEsd7T3p56PKPE1MzAJ/1y523TMtqJQ== X-Received: by 2002:a17:902:e84a:b0:1fb:6ddf:655a with SMTP id d9443c01a7336-1fbb6f0fa71mr74739165ad.69.1720701849313; Thu, 11 Jul 2024 05:44:09 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6a11757sm49654205ad.35.2024.07.11.05.44.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 05:44:08 -0700 (PDT) Message-ID: Date: Thu, 11 Jul 2024 09:44:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20240709203241.41569-1-jamrial@gmail.com> Content-Language: en-US In-Reply-To: <20240709203241.41569-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_crop: prevent integer overflows when calculating SAR X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/9/2024 5:32 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/vf_crop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c > index 6361209941..d4966323f5 100644 > --- a/libavfilter/vf_crop.c > +++ b/libavfilter/vf_crop.c > @@ -206,7 +206,7 @@ static int config_input(AVFilterLink *link) > AVRational dar = av_mul_q(link->sample_aspect_ratio, > (AVRational){ link->w, link->h }); > av_reduce(&s->out_sar.num, &s->out_sar.den, > - dar.num * s->h, dar.den * s->w, INT_MAX); > + (int64_t)dar.num * s->h, (int64_t)dar.den * s->w, INT_MAX); > } else > s->out_sar = link->sample_aspect_ratio; Will apply. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".