From: Mark Thompson <sw@jkqxz.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/amfenc: add smart access video option
Date: Mon, 27 Nov 2023 13:14:43 +0000
Message-ID: <b5fdc0f1-1330-40f5-8b40-f9220a4ae16f@jkqxz.net> (raw)
In-Reply-To: <CADXbNkRKwQWjXB4jwewOK5rvphpta-vwtEbgVEQiQrpg+FS_5Q@mail.gmail.com>
On 26/11/2023 14:40, Dmitrii Ovchinnikov wrote:
>>> The code looks significantly duplicated.
>
> This is not moved to amfenc.c since the property has different names
> for different encoders, and many other properties (also common to
> different encoders, but with different names) are separated in this way.
Seems like we could template this to avoid the duplication, something like:
#define PER_CODEC_OPTION(name) \
(ctx->codec == AV1 ? AMF_VIDEO_ENCODER_AV1_ ## name : \
ctx->codec == HEVC ? AMF_VIDEO_ENCODER_HEVC_ ## name : \
AMF_VIDEO_ENCODER_ ## name)
?
Thanks,
- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-27 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 9:41 Evgeny Pavlov
2023-11-24 8:45 ` Dmitrii Ovchinnikov
2023-11-26 10:32 ` Anton Khirnov
2023-11-26 14:40 ` Dmitrii Ovchinnikov
2023-11-27 13:14 ` Mark Thompson [this message]
2023-11-28 14:18 ` Evgeny Pavlov
2023-11-27 13:09 ` Mark Thompson
2023-11-28 13:52 ` [FFmpeg-devel] [PATCH v3] " Evgeny Pavlov
-- strict thread matches above, loose matches on Subject: below --
2023-07-20 16:17 [FFmpeg-devel] [PATCH] libavcodec/amfenc: " Evgeny Pavlov
2023-07-24 11:15 ` [FFmpeg-devel] [PATCH, v2] avcodec/amfenc: " Evgeny Pavlov
2023-11-20 15:57 ` Evgeny Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5fdc0f1-1330-40f5-8b40-f9220a4ae16f@jkqxz.net \
--to=sw@jkqxz.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git