From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6E92B405A9 for ; Sun, 23 Apr 2023 18:43:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 95D1968BEDA; Sun, 23 Apr 2023 21:43:23 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF44468B104 for ; Sun, 23 Apr 2023 21:43:16 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 3D217E84AE for ; Sun, 23 Apr 2023 20:42:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XQSH-PMrtB17 for ; Sun, 23 Apr 2023 20:42:41 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 38B5AE6B32 for ; Sun, 23 Apr 2023 20:42:41 +0200 (CEST) Date: Sun, 23 Apr 2023 20:42:41 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <1682111554-31597-1-git-send-email-dheitmueller@ltnglobal.com> Message-ID: References: <1682111554-31597-1-git-send-email-dheitmueller@ltnglobal.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 0/2] Implement SMPTE 2038 output support over Decklink SDI X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 21 Apr 2023, Devin Heitmueller wrote: > This patch series implements output of SMPTE 2038 VANC over SDI, building > on the prior patch series which added it in the TS domain. Note that > we moved the AVPacketQueue to be common code within libavdevice so it > can be shared by both the decklink input and output. > > Comments/feedback are welcome. In general, queueing packets in specific components should be avoided if possible. Muxed packets are normally ordered by DTS and stream id, generic code ensures that. If you want something other than that, then I think the perferred way of doing it is by providing a custom interleave function. (e.g. to ensure you get data packets before video even if data stream has a higher stream ID.) If you are only using the queue to store multiple data packets for a single frame then one way to avoid it is to parse them as soon as they arrive via the KLV library. If you insist on queueing them (maybe because not every packet will be parased by the KLV lib), then I'd rather see you use avpriv_packet_list_*() functions, and not a custom decklink implementation. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".