From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 0/2] Implement SMPTE 2038 output support over Decklink SDI
Date: Sun, 23 Apr 2023 20:42:41 +0200 (CEST)
Message-ID: <b5eadd-1f72-df86-d444-94a855d6856b@passwd.hu> (raw)
In-Reply-To: <1682111554-31597-1-git-send-email-dheitmueller@ltnglobal.com>
On Fri, 21 Apr 2023, Devin Heitmueller wrote:
> This patch series implements output of SMPTE 2038 VANC over SDI, building
> on the prior patch series which added it in the TS domain. Note that
> we moved the AVPacketQueue to be common code within libavdevice so it
> can be shared by both the decklink input and output.
>
> Comments/feedback are welcome.
In general, queueing packets in specific components should be avoided if
possible. Muxed packets are normally ordered by DTS and stream id, generic
code ensures that. If you want something other than that, then I think
the perferred way of doing it is by providing a custom interleave
function. (e.g. to ensure you get data packets before video even if data
stream has a higher stream ID.)
If you are only using the queue to store multiple data packets for a
single frame then one way to avoid it is to parse them as soon as they
arrive via the KLV library. If you insist on queueing them (maybe because
not every packet will be parased by the KLV lib), then I'd rather see you
use avpriv_packet_list_*() functions, and not a custom decklink
implementation.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-04-23 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 21:12 Devin Heitmueller
2023-04-21 21:12 ` [FFmpeg-devel] [PATCH 1/2] decklink: Move AVPacketQueue into decklink_common Devin Heitmueller
2023-04-21 21:12 ` [FFmpeg-devel] [PATCH 2/2] decklink_enc: add support for SMPTE 2038 VANC packet output Devin Heitmueller
2023-04-23 18:42 ` Marton Balint [this message]
2023-04-24 14:11 ` [FFmpeg-devel] [PATCH 0/2] Implement SMPTE 2038 output support over Decklink SDI Devin Heitmueller
2023-04-25 21:58 ` Marton Balint
2023-04-26 14:45 ` Devin Heitmueller
2023-04-26 7:35 ` Marton Balint
2023-04-26 14:30 ` Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5eadd-1f72-df86-d444-94a855d6856b@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git