Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] tests: Add fate-bsf-dv-error-marker
@ 2022-03-15 18:30 Michael Niedermayer
  2022-03-15 18:35 ` James Almer
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Niedermayer @ 2022-03-15 18:30 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 tests/Makefile                     | 1 +
 tests/fate/dvvideo.mak             | 6 ++++++
 tests/ref/fate/bsf-dv-error-marker | 1 +
 3 files changed, 8 insertions(+)
 create mode 100644 tests/fate/dvvideo.mak
 create mode 100644 tests/ref/fate/bsf-dv-error-marker

diff --git a/tests/Makefile b/tests/Makefile
index c4c31ae871..9f33394856 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -133,6 +133,7 @@ include $(SRC_PATH)/tests/fate/dfa.mak
 include $(SRC_PATH)/tests/fate/dnn.mak
 include $(SRC_PATH)/tests/fate/dnxhd.mak
 include $(SRC_PATH)/tests/fate/dpcm.mak
+include $(SRC_PATH)/tests/fate/dvvideo.mak
 include $(SRC_PATH)/tests/fate/ea.mak
 include $(SRC_PATH)/tests/fate/exif.mak
 include $(SRC_PATH)/tests/fate/ffmpeg.mak
diff --git a/tests/fate/dvvideo.mak b/tests/fate/dvvideo.mak
new file mode 100644
index 0000000000..3122a24f76
--- /dev/null
+++ b/tests/fate/dvvideo.mak
@@ -0,0 +1,6 @@
+
+fate-bsf-dv-error-marker: CMD = md5 -i $(TARGET_SAMPLES)/dv/dvcprohd_720p50.mov -flags +bitexact -fflags +bitexact -c:v copy -bsf noise=100,dv_error_marker=color=blue -f avi
+FATE_DVVIDEO-$(call ALLYES, MOV_DEMUXER DV_ERROR_MARKER_BSF NOISE_BSF AVI_MUXER) += fate-bsf-dv-error-marker
+
+FATE_SAMPLES_FFMPEG += $(FATE_DVVIDEO-yes)
+fate-dvvideo: $(FATE_DVVIDEO-yes)
diff --git a/tests/ref/fate/bsf-dv-error-marker b/tests/ref/fate/bsf-dv-error-marker
new file mode 100644
index 0000000000..513c9d72a3
--- /dev/null
+++ b/tests/ref/fate/bsf-dv-error-marker
@@ -0,0 +1 @@
+4e884d3e8045299d0d45ec920fa58a44
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [FFmpeg-devel] [PATCH] tests: Add fate-bsf-dv-error-marker
  2022-03-15 18:30 [FFmpeg-devel] [PATCH] tests: Add fate-bsf-dv-error-marker Michael Niedermayer
@ 2022-03-15 18:35 ` James Almer
  2022-03-15 21:53   ` Michael Niedermayer
  0 siblings, 1 reply; 3+ messages in thread
From: James Almer @ 2022-03-15 18:35 UTC (permalink / raw)
  To: ffmpeg-devel



On 3/15/2022 3:30 PM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>   tests/Makefile                     | 1 +
>   tests/fate/dvvideo.mak             | 6 ++++++
>   tests/ref/fate/bsf-dv-error-marker | 1 +
>   3 files changed, 8 insertions(+)
>   create mode 100644 tests/fate/dvvideo.mak
>   create mode 100644 tests/ref/fate/bsf-dv-error-marker
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index c4c31ae871..9f33394856 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -133,6 +133,7 @@ include $(SRC_PATH)/tests/fate/dfa.mak
>   include $(SRC_PATH)/tests/fate/dnn.mak
>   include $(SRC_PATH)/tests/fate/dnxhd.mak
>   include $(SRC_PATH)/tests/fate/dpcm.mak
> +include $(SRC_PATH)/tests/fate/dvvideo.mak
>   include $(SRC_PATH)/tests/fate/ea.mak
>   include $(SRC_PATH)/tests/fate/exif.mak
>   include $(SRC_PATH)/tests/fate/ffmpeg.mak
> diff --git a/tests/fate/dvvideo.mak b/tests/fate/dvvideo.mak
> new file mode 100644
> index 0000000000..3122a24f76
> --- /dev/null
> +++ b/tests/fate/dvvideo.mak
> @@ -0,0 +1,6 @@
> +
> +fate-bsf-dv-error-marker: CMD = md5 -i $(TARGET_SAMPLES)/dv/dvcprohd_720p50.mov -flags +bitexact -fflags +bitexact -c:v copy -bsf noise=100,dv_error_marker=color=blue -f avi

Add

fate-bsf-dv-error-marker: CMP = oneline
fate-bsf-dv-error-marker: REF = 4e884d3e8045299d0d45ec920fa58a44

So there's no need for the ref file below.

> +FATE_DVVIDEO-$(call ALLYES, MOV_DEMUXER DV_ERROR_MARKER_BSF NOISE_BSF AVI_MUXER) += fate-bsf-dv-error-marker
> +
> +FATE_SAMPLES_FFMPEG += $(FATE_DVVIDEO-yes)
> +fate-dvvideo: $(FATE_DVVIDEO-yes)
> diff --git a/tests/ref/fate/bsf-dv-error-marker b/tests/ref/fate/bsf-dv-error-marker
> new file mode 100644
> index 0000000000..513c9d72a3
> --- /dev/null
> +++ b/tests/ref/fate/bsf-dv-error-marker
> @@ -0,0 +1 @@
> +4e884d3e8045299d0d45ec920fa58a44
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [FFmpeg-devel] [PATCH] tests: Add fate-bsf-dv-error-marker
  2022-03-15 18:35 ` James Almer
@ 2022-03-15 21:53   ` Michael Niedermayer
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Niedermayer @ 2022-03-15 21:53 UTC (permalink / raw)
  To: FFmpeg development discussions and patches


[-- Attachment #1.1: Type: text/plain, Size: 1873 bytes --]

On Tue, Mar 15, 2022 at 03:35:08PM -0300, James Almer wrote:
> 
> 
> On 3/15/2022 3:30 PM, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >   tests/Makefile                     | 1 +
> >   tests/fate/dvvideo.mak             | 6 ++++++
> >   tests/ref/fate/bsf-dv-error-marker | 1 +
> >   3 files changed, 8 insertions(+)
> >   create mode 100644 tests/fate/dvvideo.mak
> >   create mode 100644 tests/ref/fate/bsf-dv-error-marker
> > 
> > diff --git a/tests/Makefile b/tests/Makefile
> > index c4c31ae871..9f33394856 100644
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -133,6 +133,7 @@ include $(SRC_PATH)/tests/fate/dfa.mak
> >   include $(SRC_PATH)/tests/fate/dnn.mak
> >   include $(SRC_PATH)/tests/fate/dnxhd.mak
> >   include $(SRC_PATH)/tests/fate/dpcm.mak
> > +include $(SRC_PATH)/tests/fate/dvvideo.mak
> >   include $(SRC_PATH)/tests/fate/ea.mak
> >   include $(SRC_PATH)/tests/fate/exif.mak
> >   include $(SRC_PATH)/tests/fate/ffmpeg.mak
> > diff --git a/tests/fate/dvvideo.mak b/tests/fate/dvvideo.mak
> > new file mode 100644
> > index 0000000000..3122a24f76
> > --- /dev/null
> > +++ b/tests/fate/dvvideo.mak
> > @@ -0,0 +1,6 @@
> > +
> > +fate-bsf-dv-error-marker: CMD = md5 -i $(TARGET_SAMPLES)/dv/dvcprohd_720p50.mov -flags +bitexact -fflags +bitexact -c:v copy -bsf noise=100,dv_error_marker=color=blue -f avi
> 
> Add
> 
> fate-bsf-dv-error-marker: CMP = oneline
> fate-bsf-dv-error-marker: REF = 4e884d3e8045299d0d45ec920fa58a44
> 
> So there's no need for the ref file below.

ok will apply with that change

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-03-15 21:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-15 18:30 [FFmpeg-devel] [PATCH] tests: Add fate-bsf-dv-error-marker Michael Niedermayer
2022-03-15 18:35 ` James Almer
2022-03-15 21:53   ` Michael Niedermayer

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git