From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id F08C74D415 for ; Tue, 17 Jun 2025 07:29:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 45E6068CD9F; Tue, 17 Jun 2025 10:29:10 +0300 (EEST) Received: from smtp-bc0a.mail.infomaniak.ch (smtp-bc0a.mail.infomaniak.ch [45.157.188.10]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id EDE5068C2A0 for ; Tue, 17 Jun 2025 10:29:03 +0300 (EEST) Received: from smtp-3-0000.mail.infomaniak.ch (unknown [IPv6:2001:1600:4:17::246b]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4bLz5C3y4kzJl9 for ; Tue, 17 Jun 2025 09:29:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=regaud-chapuy.fr; s=20201206; t=1750145343; bh=x7QjUV2uCX8yduH/pRqxId1tkBKbe9QpgdnlFh8YWlA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=uXtGJgLcV9iuFpIypAyxEc9Kk4INXAflr1OJ3djVZlDFzYnw4QP4GKlRrMivkCuaq cSLIDEAN/ozfbN/4neDByYA8msS/uBT4EYT88I2FrfEQdR4tVK+N4oTINbYFgZwRzm wXV8yX7NAkg3QaFX4mWkvsEMv0hmXrD2d8kxnD6k= Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4bLz5C00TQzHG8 for ; Tue, 17 Jun 2025 09:29:02 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------FWrtTP1eVjebAJJqytsSgMtA" Message-ID: Date: Tue, 17 Jun 2025 09:29:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <2dc54cad-932f-4c30-9f9d-0a943e0a7be3@regaud-chapuy.fr> <639a031a-06c7-4855-8d97-de61626ba194@regaud-chapuy.fr> Content-Language: fr, en-US From: Timothee In-Reply-To: X-Infomaniak-Routing: alpha Subject: [FFmpeg-devel] [PATCH v3] avcodec/h264: fixed qp table attach for h264 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is a multi-part message in MIME format. --------------FWrtTP1eVjebAJJqytsSgMtA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Context from the first version : > Here is a patch where I fixed the attach of per-macroblock qp tables for > H.264. It was implemented for MPEG2 so I have only extended it. > > I tested the functionality with the codecview filter using the following > command: `./ffmpeg -export_side_data 4 -i input.mp4 -vf codecview=qp=1 > output.mp4` Andreas : > 1. Commits should be small atomic units; changes to different libraries > in the same commit are almost always not of this type. > 2. Both ff_h264_decode_mb_cabac() and ff_h264_decode_mb_cavlc() already > set qscale_table on their own (on success), so that all the changes to > h264_slice.c seem completely redundant. > > - Andreas Here is a new version of the patch without the redundant lines. Thanks, Timothée --------------FWrtTP1eVjebAJJqytsSgMtA Content-Type: text/x-patch; charset=UTF-8; name="0001-avcodec-h264-fixed-qp-table-attach-for-h264.patch" Content-Disposition: attachment; filename="0001-avcodec-h264-fixed-qp-table-attach-for-h264.patch" Content-Transfer-Encoding: base64 RnJvbSA0MjJlOGRiZGMzZDc5YjI0YzZjY2IxMWI3ZjM4NGZjMDg0MDZlZTc0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGhlZSA8dGltb3RoZWUuaW5mb3JtYXRpcXVl QHJlZ2F1ZC1jaGFwdXkuZnI+CkRhdGU6IEZyaSwgMTMgSnVuIDIwMjUgMTQ6MjE6MjggKzAy MDAKU3ViamVjdDogW1BBVENIXSBhdmNvZGVjL2gyNjQ6IGZpeGVkIHFwIHRhYmxlIGF0dGFj aCBmb3IgaDI2NAoKU2lnbmVkLW9mZi1ieTogVGltb3RoZWUgPHRpbW90aGVlLmluZm9ybWF0 aXF1ZUByZWdhdWQtY2hhcHV5LmZyPgotLS0KIGxpYmF2Y29kZWMvaDI2NF9zbGljZS5jIHwg MTYgKysrKysrKysrKysrLS0tLQogbGliYXZmaWx0ZXIvcXBfdGFibGUuYyAgfCAgMyArKy0K IGxpYmF2ZmlsdGVyL3FwX3RhYmxlLmggIHwgIDEgKwogMyBmaWxlcyBjaGFuZ2VkLCAxNSBp bnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpYmF2ZmlsdGVy L3FwX3RhYmxlLmMgYi9saWJhdmZpbHRlci9xcF90YWJsZS5jCmluZGV4IDgxMzdkYzAxOWYu LmE5OWI5OWU3N2EgMTAwNjQ0Ci0tLSBhL2xpYmF2ZmlsdGVyL3FwX3RhYmxlLmMKKysrIGIv bGliYXZmaWx0ZXIvcXBfdGFibGUuYwpAQCAtNDAsNyArNDAsOCBAQCBpbnQgZmZfcXBfdGFi bGVfZXh0cmFjdChBVkZyYW1lICpmcmFtZSwgaW50OF90ICoqdGFibGUsIGludCAqdGFibGVf dywgaW50ICp0YWJsZQogICAgIGlmICghc2QpCiAgICAgICAgIHJldHVybiAwOwogICAgIHBh ciA9IChBVlZpZGVvRW5jUGFyYW1zKilzZC0+ZGF0YTsKLSAgICBpZiAocGFyLT50eXBlICE9 IEFWX1ZJREVPX0VOQ19QQVJBTVNfTVBFRzIgfHwKKyAgICBpZiAoKHBhci0+dHlwZSAhPSBB Vl9WSURFT19FTkNfUEFSQU1TX01QRUcyCisgICAgICAgJiYgcGFyLT50eXBlICE9IEFWX1ZJ REVPX0VOQ19QQVJBTVNfSDI2NCkgfHwKICAgICAgICAgKHBhci0+bmJfYmxvY2tzICE9IDAg JiYgcGFyLT5uYl9ibG9ja3MgIT0gbmJfbWIpKQogICAgICAgICByZXR1cm4gQVZFUlJPUihF Tk9TWVMpOwogCmRpZmYgLS1naXQgYS9saWJhdmZpbHRlci9xcF90YWJsZS5oIGIvbGliYXZm aWx0ZXIvcXBfdGFibGUuaAppbmRleCA0NDA3YmFjYjBlLi5jMWE4MGQxODMwIDEwMDY0NAot LS0gYS9saWJhdmZpbHRlci9xcF90YWJsZS5oCisrKyBiL2xpYmF2ZmlsdGVyL3FwX3RhYmxl LmgKQEAgLTQwLDYgKzQwLDcgQEAgc3RhdGljIGlubGluZSBpbnQgZmZfbm9ybV9xc2NhbGUo aW50IHFzY2FsZSwgZW51bSBBVlZpZGVvRW5jUGFyYW1zVHlwZSB0eXBlKQogewogICAgIHN3 aXRjaCAodHlwZSkgewogICAgIGNhc2UgQVZfVklERU9fRU5DX1BBUkFNU19NUEVHMjogcmV0 dXJuIHFzY2FsZSA+PiAxOworICAgIGNhc2UgQVZfVklERU9fRU5DX1BBUkFNU19IMjY0OiAg cmV0dXJuIHFzY2FsZTsKICAgICB9CiAgICAgcmV0dXJuIHFzY2FsZTsKIH0KLS0gCjIuMzku NQoK --------------FWrtTP1eVjebAJJqytsSgMtA Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --------------FWrtTP1eVjebAJJqytsSgMtA--