From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3E4B2451DB for ; Wed, 11 Jan 2023 16:54:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B7C8B68BC72; Wed, 11 Jan 2023 18:54:07 +0200 (EET) Received: from mail.hhi.fraunhofer.de (mail.HHI.FRAUNHOFER.DE [193.174.67.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7DE0368B265 for ; Wed, 11 Jan 2023 18:54:00 +0200 (EET) Received: from mail.hhi.fraunhofer.de (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2512B7C133 for ; Wed, 11 Jan 2023 17:53:59 +0100 (CET) X-IMSS-DKIM-Authentication-Result: mail.hhi.fraunhofer.de; sigcount=0 Received: from mail.hhi.fraunhofer.de (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0F2CD7C12E for ; Wed, 11 Jan 2023 17:53:59 +0100 (CET) Received: from mx.fe.hhi.de (unknown [172.16.0.105]) by mail.hhi.fraunhofer.de (Postfix) with ESMTPS for ; Wed, 11 Jan 2023 17:53:59 +0100 (CET) Received: from mxsrv2.fe.hhi.de (172.16.0.105) by mxsrv2.fe.hhi.de (172.16.0.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1118.20; Wed, 11 Jan 2023 17:53:58 +0100 Received: from mxsrv2.fe.hhi.de ([fe80::a6ac:c6a3:8cbe:4317]) by mxsrv2.fe.hhi.de ([fe80::a6ac:c6a3:8cbe:4317%6]) with mapi id 15.02.1118.020; Wed, 11 Jan 2023 17:53:58 +0100 From: "Helmrich, Christian" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] Request for adding XPSNR avfilter Thread-Index: AQHZJSrwOOZOGq7jyUGmIcLheMkTf66YDTMAgAEKYbr///KxAIAAAT8AgABiAvs= Date: Wed, 11 Jan 2023 16:53:58 +0000 Message-ID: References: <4a40a9d140aa477fb34cf5704034bd4c@hhi.fraunhofer.de> , In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.22.100] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] Request for adding XPSNR avfilter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Stoffers, Christian" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, > Also please fix style of code, ... example vf_psnr.c filter ... "for () {\n" instead of "for () \n{\n}" Done, I aligned block encapsulation, indentation, and some other things with those in vf_psnr.c > Compare clang compiled ffmpeg without this asm code and with it, and tell if any difference. > I'might do it anyway later. Strange, the asm code is now only barely (a few percent at most) faster than the C-loop code on our side. Maybe the compilers or CPUs have improved since we last tested? Anway, we decided to make a new patch without the asm file, but keep the function pointers in case we manage to write better SIMD for the highds, diff1st, and diff2nd function later (for a smaller patch then). I prepared a new avfilter_xpsnr_v2.patch. Do I need to change the email (thread) title somehow so that a new pipeline is being triggered? Best, Christian Helmrich Fraunhofer HHI, Video Coding and Analytics Department ________________________________ Von: ffmpeg-devel im Auftrag von Paul B Mahol Gesendet: Mittwoch, 11. Januar 2023 12:53 An: FFmpeg development discussions and patches Cc: Stoffers, Christian Betreff: Re: [FFmpeg-devel] [PATCH] Request for adding XPSNR avfilter On 1/11/23, Paul B Mahol wrote: > On 1/11/23, Helmrich, Christian > wrote: >> Hi, >> >> >>> So its better to use that instead of human written assembly? Does clang >>> generate faster code without this asm? >> >> >> I'm not sure I fully understand your questions, but I hope the following >> answers it. The reason why we auto-converted our intrinsics code to asm >> is >> not a technical one, we unfortunately just don't have the knowledge or >> resources to manually write asm code. If I remember correctly, the SIMD >> optimized code runs about twice as fast as the C code, especially on UHD >> input. > > Compare clang compiled ffmpeg without this asm code and with it, and > tell if any difference. > I'might do it anyway later. Also please fix style of code, look at other filters in codebase, for example vf_psnr.c filter Use "for () {\n" instead of "for () \n{\n}" > >> >> >>> Please remove SLICE_THREADS related flag as there is no call to execute >>> to >>> filter in slices. Please remove stdbool.h header and adapt code to >>> compile >>> without it. >> >> >> Done, please find attached a second version (v1) of the XPSNR avfilter >> patch. >> >> >> Thanks and best, >> >> >> Christian Helmrich >> >> Fraunhofer HHI, Video Coding and Analytics Department >> >> >> ________________________________ >> Von: ffmpeg-devel im Auftrag von Paul B >> Mahol >> Gesendet: Dienstag, 10. Januar 2023 21:43 >> An: FFmpeg development discussions and patches >> Cc: Stoffers, Christian >> Betreff: Re: [FFmpeg-devel] [PATCH] Request for adding XPSNR avfilter >> >> On 1/10/23, Helmrich, Christian >> wrote: >>> Hi, >>> >>> please find attached a patch (relative to FFmpeg master as of early >>> January >>> 10, 2023) >>> adding avfilter support for extended perceptually weighted peak >>> signal-to-noise ratio >>> (XPSNR) measurements for videos, as described in the related addition to >>> filters.texi. >>> >>> The XPSNR code was originally vectorized using SIMD intrinsics, but we >>> concluded that >>> FFmpeg code requires asm instead of such intrinsics, so we let gcc >>> auto-convert these >> >> So its better to use that instead of human written assembly? >> Does clang generate faster code without this asm? >> >>> instructions to pure assembly; see the vf_xpsnr.asm file. If the added >>> asm >>> code is too >>> lengthy, intrinsics would be possible, or something else is missing, >>> please >>> let us know. >>> >> >> Please remove SLICE_THREADS related flag as there is no call to >> execute to filter in slices. >> Please remove stdbool.h header and adapt code to compile without it. >> >>> Best, >>> >>> Christian Helmrich and Christian Stoffers >>> Fraunhofer HHI >>> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".