From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C3A1D4084A for ; Wed, 1 Jun 2022 14:13:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4B3AF68B6FF; Wed, 1 Jun 2022 17:13:34 +0300 (EEST) Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C11FC68B65A for ; Wed, 1 Jun 2022 17:13:28 +0300 (EEST) Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-e5e433d66dso2874951fac.5 for ; Wed, 01 Jun 2022 07:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:references:in-reply-to:content-transfer-encoding; bh=74sR8f9UAQXH9T0+4zJB8Sg6zCMemmZHeYKfrY0UC6g=; b=aimTTtLu/RgtcM23/iEaHiP0Xfu27jdl7fpZDMEp7VvznK8WcFCkw316agRrPTDoyF HdVQcPWl0Nse2cs05ZAG7b1zM9ZIZ9cMxGXil/tVRKZ1QKZ1ubunRuZgkhoozarH/J1w R+ybGuUd5AmUkkU8/5t9GTVpAigRY4IVRX9kVzydOXyu21c1BUypLPxIsZvxljpBVvh9 2TnCYAFmSSo3kOivvaENdwzqh5ksrdo01VVt4n17lx4+/8TkwAh8jLlDuzx6B0cmAF6o fPon+hCmaAx35xX6u+oAo/P5EKyQAhCjRVIaNGnYW+49JfFoQf60uuqh+JGMIH5i0PcZ grmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=74sR8f9UAQXH9T0+4zJB8Sg6zCMemmZHeYKfrY0UC6g=; b=diVJ65bvBvrt3QVS3G42hMyD+EcqktXSwk1FUWu8mNMo5eGeca+0Mj2rNp1EwWqj++ bUMYiAf0Chm2kZps0D5BJBqBLyOcgrESJltCrlYFfLGoVK/AptKvJmk4og0GFs1Vtann pdtDOHeyi5tUfp1IeEWJNxNJfc60Q+cLCky4+y9LMBWkuuHfgJ4cUTx+cozdwu5dupTV Q/NQpuUmXvfUdRK8WOlkEwOdLWe/Kz7eI+a/dad+cX08JngEol3rQre4nC/5X9fixEuK vNW1GgxlTErZVcRylBVa49OH7ETGU+nTow8hVU5gMvv0F59Vv6CbGCyDGKcRpxvp0/E+ Htww== X-Gm-Message-State: AOAM531tnnP7/cFw+hQ1Hr9Za3KTG3l47mqwXolD5ILVtXyLs3s0W01N jq6nT8wXbT7Ej4vmKApIbgGE/wyC2Gc= X-Google-Smtp-Source: ABdhPJz5bHwD3sm5i18Uv3TwYlsYsge/2tNTLOQ7mLoh44H9j9Zm2ofXDUfYOYM7ma7HnbLea6t03Q== X-Received: by 2002:a05:6870:5896:b0:e6:6c21:3584 with SMTP id be22-20020a056870589600b000e66c213584mr4960oab.220.1654092806445; Wed, 01 Jun 2022 07:13:26 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.204]) by smtp.gmail.com with ESMTPSA id u13-20020a056871008d00b000f5d4e5b9a0sm715781oaa.2.2022.06.01.07.13.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 07:13:25 -0700 (PDT) Message-ID: Date: Wed, 1 Jun 2022 11:13:23 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20220525171516.64893-1-jamrial@gmail.com> In-Reply-To: <20220525171516.64893-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avutil/avframe: fix channel layout checks in av_frame_copy() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/25/2022 2:15 PM, James Almer wrote: > Normally, both the source and dest frame would have only the old API fields > set, only the new API fields set, or both set. But in some cases, like when > calling av_frame_ref() using a non reference counted source frame where only > the old channel layout API fields were populated, the result would be the dst > frame having both the new and old fields populated. > > This commit takes this into account and fixes the checks by calling > av_channel_layout_compare() only if the source frame has the new API fields > set, and doing sanity checks for the source frame old API fields if the new > ones are not set. > > Signed-off-by: James Almer > --- > libavutil/frame.c | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) Will apply. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".