From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avutil/avframe: fix channel layout checks in av_frame_copy()
Date: Wed, 1 Jun 2022 11:13:23 -0300
Message-ID: <b51bab44-1025-1816-08c3-bfe58ce6c43c@gmail.com> (raw)
In-Reply-To: <20220525171516.64893-1-jamrial@gmail.com>
On 5/25/2022 2:15 PM, James Almer wrote:
> Normally, both the source and dest frame would have only the old API fields
> set, only the new API fields set, or both set. But in some cases, like when
> calling av_frame_ref() using a non reference counted source frame where only
> the old channel layout API fields were populated, the result would be the dst
> frame having both the new and old fields populated.
>
> This commit takes this into account and fixes the checks by calling
> av_channel_layout_compare() only if the source frame has the new API fields
> set, and doing sanity checks for the source frame old API fields if the new
> ones are not set.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavutil/frame.c | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
Will apply.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-06-01 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 17:15 James Almer
2022-05-27 8:12 ` Tomas Härdin
2022-05-27 14:07 ` James Almer
2022-06-01 14:13 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b51bab44-1025-1816-08c3-bfe58ce6c43c@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git