Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avutil/attributes: add support for clang in AV_NOWARN_DEPRECATED
Date: Wed, 16 Mar 2022 12:30:40 -0300
Message-ID: <b4f44817-cae6-6457-b71b-3ebb27e6d27f@gmail.com> (raw)
In-Reply-To: <9821a7e8-abc7-efaf-5e3-329ecb71b2df@martin.st>



On 3/16/2022 11:18 AM, Martin Storsjö wrote:
> On Wed, 16 Mar 2022, James Almer wrote:
> 
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>> libavutil/attributes.h | 2 +-
>> libavutil/version.h    | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavutil/attributes.h b/libavutil/attributes.h
>> index 5cb9fe3452..04c615c952 100644
>> --- a/libavutil/attributes.h
>> +++ b/libavutil/attributes.h
>> @@ -110,7 +110,7 @@
>>  * scheduled for removal.
>>  */
>> #ifndef AV_NOWARN_DEPRECATED
>> -#if AV_GCC_VERSION_AT_LEAST(4,6)
>> +#if AV_GCC_VERSION_AT_LEAST(4,6) || defined(__clang__)
>> #    define AV_NOWARN_DEPRECATED(code) \
>>         _Pragma("GCC diagnostic push") \
>>         _Pragma("GCC diagnostic ignored \"-Wdeprecated-declarations\"") \
>> diff --git a/libavutil/version.h b/libavutil/version.h
>> index d9d0e0564b..6735c20090 100644
>> --- a/libavutil/version.h
>> +++ b/libavutil/version.h
>> @@ -80,7 +80,7 @@
>>
>> #define LIBAVUTIL_VERSION_MAJOR  57
>> #define LIBAVUTIL_VERSION_MINOR  24
>> -#define LIBAVUTIL_VERSION_MICRO 100
>> +#define LIBAVUTIL_VERSION_MICRO 101
>>
>> #define LIBAVUTIL_VERSION_INT   AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
>>                                                LIBAVUTIL_VERSION_MINOR, \
>> -- 
>> 2.35.1
> 
> This seems to work for me, tested with a recent Apple Clang. (The number 
> of build warnings drop by 2 when this is applied.)

How 2? AV_NOWARN_DEPRECATED is currently used in a single place.

Pushed, thanks.

> 
> // Martin
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2022-03-16 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 14:04 James Almer
2022-03-16 14:18 ` Martin Storsjö
2022-03-16 15:30   ` James Almer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4f44817-cae6-6457-b71b-3ebb27e6d27f@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git