From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E60E544BFA for ; Wed, 12 Apr 2023 11:27:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B199268BBA2; Wed, 12 Apr 2023 14:26:58 +0300 (EEST) Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0C07F680C25 for ; Wed, 12 Apr 2023 14:26:51 +0300 (EEST) Received: by mail-oi1-f180.google.com with SMTP id cd20so1039715oib.0 for ; Wed, 12 Apr 2023 04:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681298810; x=1683890810; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=gwFW1qJjhLHCaESrhO2fZDkQgCf6oMV8+VEI0JGr4Ws=; b=g8PT4QatevtknCRakrgorxyC0IdZFtv0sGTokB5zKeZa4w8SIES4BdVcAuYREKg9Xt jXQ9jUcjGiWeG2TZ6c9nRGuFqrHKBl45Af1YrYGdzGiqif3A9TqWxqpjSRXq1M26APZV 4WIxW8FiRb4S23WdFdtHUByQMlVkYem4T1wtDfJySeVMaeHTN1QSfs3osjzStxHAo1Vj BfGNz/G+QjOON4HaULNOT+tpDLit43jiBIpQUYbikVwfdNYUFAdQfwx+ylI7sXEYVxEE 8+3+BmOFMsFJW5K4uskFRfwbZhM1dC/Ozgt6qO6o1CFaA6/njPggRNEVg13XMKP5qIs1 14EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681298810; x=1683890810; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gwFW1qJjhLHCaESrhO2fZDkQgCf6oMV8+VEI0JGr4Ws=; b=o+EhCYEklUfDFSivf+wp0OkJOSu4BvO5N5asN8VAjpOMLFzKfMNwwZuUtWOIKVUc5z 4GmprP6SrrfUQD0zr8LOGrDwzbKgwSYXbv6d2o7r7i5NmFPmkNPV8MPRjGotSCzmLS9X ZcMwAgCQDuyJI2J78G+G2W2wohyVbqDo/+/nokReKmaWafkC62DDQWTx2DW7MMSEB3tP znAyajI7PRL3GeqDzVenkZhfw/X2MeWsLI7bk2lLQ28w32r2trE5XsLDgOfIRspzh4Hw EZjAf1yEEz6kqUx1OiQqUdAXsqtHF6oF5KAP0Ck+G8sBtS6BHd7ZRSGJykcuzBUpT046 0k0Q== X-Gm-Message-State: AAQBX9ehEBH6Z9ou7Yu2CKTLqoUjJZqk1gAuQM/c9lS++8onmks8XN9V mam3UUAVCcV0CH7kmnaGyLJ0aOUyQys= X-Google-Smtp-Source: AKy350b7HQLO1u3+tbNSySoD/l+nE5CWhIEiCdd4W+Gk0m1DZeCobpphzMOawC+54ng9HinDgLbxOA== X-Received: by 2002:a05:6808:90c:b0:38b:fc00:6728 with SMTP id w12-20020a056808090c00b0038bfc006728mr427924oih.19.1681298810148; Wed, 12 Apr 2023 04:26:50 -0700 (PDT) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id b14-20020a056830104e00b0069457b86060sm6474261otp.47.2023.04.12.04.26.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 04:26:48 -0700 (PDT) Message-ID: Date: Wed, 12 Apr 2023 08:26:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 To: ffmpeg-devel@ffmpeg.org References: <20230411203851.65044-1-jamrial@gmail.com> <20230411203851.65044-2-jamrial@gmail.com> <168128699197.27013.12977793193161732244@lain.khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <168128699197.27013.12977793193161732244@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec: use the new event flags field instead of setting AVFrame.palette_has_changed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/12/2023 5:09 AM, Anton Khirnov wrote: > Quoting James Almer (2023-04-11 22:38:50) >> diff --git a/doc/APIchanges b/doc/APIchanges >> index 59216231f9..85060768b3 100644 >> --- a/doc/APIchanges >> +++ b/doc/APIchanges >> @@ -4,6 +4,7 @@ API changes, most recent first: >> >> 2023-04-11 - xxxxxxxxxx - lavc 60.10.100 - avcodec.h >> Add event_flags to AVCodecContext. >> + Add AVCTX_EVENT_FLAG_PALETTE_HAS_CHANGED. > > I think we should first figure out how is the field supposed to be > useful to our users. Maybe it's not and we can just remove it. That's fine. I have no idea if it's actually used or useful (You can always just memcmp(prev->data[1], cur->data[1], 256) on every frame after all), but removing without replacement tends to be controversial, hence why i did this. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".