From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec: use the new event flags field instead of setting AVFrame.palette_has_changed
Date: Wed, 12 Apr 2023 08:26:48 -0300
Message-ID: <b4c6c928-3ebd-a8ce-4962-efde2d61b2ce@gmail.com> (raw)
In-Reply-To: <168128699197.27013.12977793193161732244@lain.khirnov.net>
On 4/12/2023 5:09 AM, Anton Khirnov wrote:
> Quoting James Almer (2023-04-11 22:38:50)
>> diff --git a/doc/APIchanges b/doc/APIchanges
>> index 59216231f9..85060768b3 100644
>> --- a/doc/APIchanges
>> +++ b/doc/APIchanges
>> @@ -4,6 +4,7 @@ API changes, most recent first:
>>
>> 2023-04-11 - xxxxxxxxxx - lavc 60.10.100 - avcodec.h
>> Add event_flags to AVCodecContext.
>> + Add AVCTX_EVENT_FLAG_PALETTE_HAS_CHANGED.
>
> I think we should first figure out how is the field supposed to be
> useful to our users. Maybe it's not and we can just remove it.
That's fine. I have no idea if it's actually used or useful (You can
always just memcmp(prev->data[1], cur->data[1], 256) on every frame
after all), but removing without replacement tends to be controversial,
hence why i did this.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-04-12 11:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 20:38 [FFmpeg-devel] [PATCH 1/3] avcodec/avcodec: add an event flags field to AVCodecContext James Almer
2023-04-11 20:38 ` [FFmpeg-devel] [PATCH 2/3] avcodec: use the new event flags field instead of setting AVFrame.palette_has_changed James Almer
2023-04-12 8:09 ` Anton Khirnov
2023-04-12 11:26 ` James Almer [this message]
2023-04-12 11:55 ` Anton Khirnov
2023-04-12 11:59 ` James Almer
2023-04-12 12:39 ` Anton Khirnov
2023-04-11 20:38 ` [FFmpeg-devel] [PATCH 3/3] avutil/frame: deprecate palette_has_changed James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4c6c928-3ebd-a8ce-4962-efde2d61b2ce@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git