From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id C34C145E65
	for <ffmpegdev@gitmailbox.com>; Thu, 13 Apr 2023 13:11:37 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6FB1268BCF0;
	Thu, 13 Apr 2023 16:11:34 +0300 (EEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 402BB6807B4;
 Thu, 13 Apr 2023 16:11:23 +0300 (EEST)
Received: from [192.168.1.184] (pool-108-28-73-40.washdc.fios.verizon.net
 [108.28.73.40])
 by linux.microsoft.com (Postfix) with ESMTPSA id E85822179253;
 Thu, 13 Apr 2023 06:11:21 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E85822179253
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1681391482;
 bh=PoYQ2T8S99ArWhVbkwe/qKDx9N9uWbV+o/cPGGwzVTM=;
 h=Subject:To:References:From:Date:In-Reply-To:From;
 b=nBquc/Llhbx8H+ZEtvyDit/4DIll5OqTnqbZoGZqjXLWFFjy0e34Tcj7KtleOyk9E
 DTn9Ix32sOh1V2MRNNE217w20Xh0bymLoYP2iC5aEMnUta4DCAWkVfTQ645DUczuuX
 UHxGpqhMbTxUwZTdw+gpUp+ylrjxqoWwnrWK9Ahc=
To: ffmpeg-devel-bounces@ffmpeg.org, ffmpeg-devel@ffmpeg.org
References: <20230412122741.474-1-sivileri@microsoft.com>
 <20230412122741.474-3-sivileri@microsoft.com>
 <CA+anqdykxUSveAH6wCAMXJy597GgyiAmUtB6f2pJ=nYaOU=69w@mail.gmail.com>
 <BL1PR21MB3354B2FAD414E1222FC1AB7CE5989@BL1PR21MB3354.namprd21.prod.outlook.com>
From: Sil Vilerino <sivileri@linux.microsoft.com>
Message-ID: <b48d11cb-fdef-f3ac-f858-be0e4eda6d9c@linux.microsoft.com>
Date: Thu, 13 Apr 2023 09:11:20 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <BL1PR21MB3354B2FAD414E1222FC1AB7CE5989@BL1PR21MB3354.namprd21.prod.outlook.com>
Content-Language: en-US
Subject: Re: [FFmpeg-devel] [PATCH v3 3/3] Update QSV after adding support
 for VAAPI on Windows:
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/b48d11cb-fdef-f3ac-f858-be0e4eda6d9c@linux.microsoft.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 4/12/2023 12:18 PM, Hendrik Leppkes wrote:
>> -#if CONFIG_VAAPI
>> +#if CONFIG_VAAPI && !_WIN32 // Do not enable for libva-win32 on
>> +Windows
> 
> Shouldn't this be defined(_WIN32), same below?
> 

Great catch, thanks for pointing this out. Will change to 
defined(_WIN32) on both files qsv_internal.h and hwcontext_qsv.c, will 
wait a couple more days for comments on V3 before sending V4 with those 
changes.

-- 
Sil Vilerino
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".