From: Sil Vilerino <sivileri@linux.microsoft.com>
To: ffmpeg-devel-bounces@ffmpeg.org, ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3 3/3] Update QSV after adding support for VAAPI on Windows:
Date: Thu, 13 Apr 2023 09:11:20 -0400
Message-ID: <b48d11cb-fdef-f3ac-f858-be0e4eda6d9c@linux.microsoft.com> (raw)
In-Reply-To: <BL1PR21MB3354B2FAD414E1222FC1AB7CE5989@BL1PR21MB3354.namprd21.prod.outlook.com>
On 4/12/2023 12:18 PM, Hendrik Leppkes wrote:
>> -#if CONFIG_VAAPI
>> +#if CONFIG_VAAPI && !_WIN32 // Do not enable for libva-win32 on
>> +Windows
>
> Shouldn't this be defined(_WIN32), same below?
>
Great catch, thanks for pointing this out. Will change to
defined(_WIN32) on both files qsv_internal.h and hwcontext_qsv.c, will
wait a couple more days for comments on V3 before sending V4 with those
changes.
--
Sil Vilerino
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-04-13 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 12:27 [FFmpeg-devel] [PATCH v3 1/3] Add support for VAAPI on Windows in hwcontext_vaapi using vaGetDisplayWin32 Sil Vilerino
2023-04-12 12:27 ` [FFmpeg-devel] [PATCH v3 2/3] Update -device argument usage in VAAPI documentation to indicate now also DirectX Adapter indices are supported Sil Vilerino
2023-04-12 12:27 ` [FFmpeg-devel] [PATCH v3 3/3] Update QSV after adding support for VAAPI on Windows: Sil Vilerino
2023-04-12 16:18 ` Hendrik Leppkes
[not found] ` <BL1PR21MB3354B2FAD414E1222FC1AB7CE5989@BL1PR21MB3354.namprd21.prod.outlook.com>
2023-04-13 13:11 ` Sil Vilerino [this message]
2023-04-12 22:37 ` Neal Gompa
[not found] ` <BL1PR21MB3354D2B6E5BD3B88AF554073E5989@BL1PR21MB3354.namprd21.prod.outlook.com>
2023-04-13 13:08 ` Sil Vilerino
2023-04-12 12:57 ` [FFmpeg-devel] [PATCH v3 1/3] Add support for VAAPI on Windows in hwcontext_vaapi using vaGetDisplayWin32 Fahad Mustafa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b48d11cb-fdef-f3ac-f858-be0e4eda6d9c@linux.microsoft.com \
--to=sivileri@linux.microsoft.com \
--cc=ffmpeg-devel-bounces@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git